)]}'
{"tempest/api/compute/security_groups/base.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"7832b5355d92e1b3fdf2535587d9d216112a5424","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        super(BaseSecurityGroupsTest, cls).setup_credentials()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"},{"line_number":33,"context_line":"    def generate_not_existing_id():"},{"line_number":34,"context_line":"        if (CONF.service_available.neutron and"},{"line_number":35,"context_line":"            test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027)):"},{"line_number":36,"context_line":"            return data_utils.rand_uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_d7e21d9f","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":32},"updated":"2017-01-13 11:59:05.000000000","message":"I agree that it\u0027s quite unlikely that a newly generated ID would conflict with an existing one, however the name of the method is not appropriate, since we are not verifying in any way that that is the case.\n\nNormally I would not -1 on a method name, but since this is the main purpose of this change, I think the method should be called generate_random_security_group_id or something like that.","commit_id":"b989fcaf15d737bf837de3c082d634bad6ac3b19"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bfc1e12094a42fbb937b662eff49525fba9f1666","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027)):"},{"line_number":36,"context_line":"            return data_utils.rand_uuid()"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            return data_utils.rand_int_id(start\u003d999)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_05c1af80","line":38,"updated":"2017-01-10 10:09:46.000000000","message":"rand_int_id() generates a value between 0 and 2147483647 so I think it\u0027s super unlikely that the secgroup id will be already used.","commit_id":"b989fcaf15d737bf837de3c082d634bad6ac3b19"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3ceed47ba2f64d32be9c971e88f60e7cf531594","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027)):"},{"line_number":36,"context_line":"            return data_utils.rand_uuid()"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            return data_utils.rand_int_id(start\u003d999)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_cf0884dc","line":38,"range":{"start_line":38,"start_character":43,"end_line":38,"end_character":51},"updated":"2017-01-16 08:14:31.000000000","message":"998 rules in cloud very unlikly but not impossible :) But should be ok and we can append 1 more 9 if anyone report failure.","commit_id":"75f4fa7dcf3bb8a18861975325eae0d4d4ebc5cb"}],"tempest/api/compute/security_groups/test_security_group_rules_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3ceed47ba2f64d32be9c971e88f60e7cf531594","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SecurityGroupRulesNegativeTestJSON(base.BaseSecurityGroupsTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_0fe1acfe","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":18},"updated":"2017-01-16 08:14:31.000000000","message":"we do not need this now.","commit_id":"75f4fa7dcf3bb8a18861975325eae0d4d4ebc5cb"}]}