)]}'
{"tempest/api/compute/flavors/test_flavors_negative.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0b501ff22bc3fdcd83666b18717e0b1d97303249","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import random"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.compute import base"},{"line_number":20,"context_line":"from tempest.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_69edf48d","line":17,"updated":"2017-02-02 17:01:50.000000000","message":"Import are not well grouped. Please read http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"ae9ad14a3a507f7e3c4dbfcb4487c51599553f3f"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"045a1084161ba79d8f6dea12977c840391e96c00","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import random"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.compute import base"},{"line_number":20,"context_line":"from tempest.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_239dc259","line":17,"in_reply_to":"3a461143_69edf48d","updated":"2017-02-05 09:41:56.000000000","message":"Done","commit_id":"ae9ad14a3a507f7e3c4dbfcb4487c51599553f3f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0b501ff22bc3fdcd83666b18717e0b1d97303249","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"},{"line_number":38,"context_line":"        \u0027\u0027\u0027Try boot a vm with lower than min ram"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            Create an image with min_ram value"},{"line_number":41,"context_line":"            Try to create server with flavor of insufficient ram size from"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_a9e7dcaa","line":38,"updated":"2017-02-02 17:01:50.000000000","message":"Use \"\"\"","commit_id":"ae9ad14a3a507f7e3c4dbfcb4487c51599553f3f"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"045a1084161ba79d8f6dea12977c840391e96c00","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"},{"line_number":38,"context_line":"        \u0027\u0027\u0027Try boot a vm with lower than min ram"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            Create an image with min_ram value"},{"line_number":41,"context_line":"            Try to create server with flavor of insufficient ram size from"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_03b1a6e1","line":38,"in_reply_to":"3a461143_a9e7dcaa","updated":"2017-02-05 09:41:56.000000000","message":"Done","commit_id":"ae9ad14a3a507f7e3c4dbfcb4487c51599553f3f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0b501ff22bc3fdcd83666b18717e0b1d97303249","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"},{"line_number":38,"context_line":"        \u0027\u0027\u0027Try boot a vm with lower than min ram"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            Create an image with min_ram value"},{"line_number":41,"context_line":"            Try to create server with flavor of insufficient ram size from"},{"line_number":42,"context_line":"            that image"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_c9ec2892","line":40,"updated":"2017-02-02 17:01:50.000000000","message":"Weird indentation.","commit_id":"ae9ad14a3a507f7e3c4dbfcb4487c51599553f3f"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"045a1084161ba79d8f6dea12977c840391e96c00","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"},{"line_number":38,"context_line":"        \u0027\u0027\u0027Try boot a vm with lower than min ram"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            Create an image with min_ram value"},{"line_number":41,"context_line":"            Try to create server with flavor of insufficient ram size from"},{"line_number":42,"context_line":"            that image"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_23b4e2cf","line":40,"in_reply_to":"3a461143_c9ec2892","updated":"2017-02-05 09:41:56.000000000","message":"Done","commit_id":"ae9ad14a3a507f7e3c4dbfcb4487c51599553f3f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3fa2fe08d19690ad0124d9450d28b1fcee9c2f2b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(min_img_ram, image[\u0027min_ram\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Try to create server with flavor of insufficient ram size"},{"line_number":67,"context_line":"        self.assertRaises(lib_exc.BadRequest, self.create_test_server,"},{"line_number":68,"context_line":"                          image_id\u003dimage[\u0027id\u0027], flavor\u003dflavor[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_24abf6d7","line":67,"updated":"2017-02-06 09:59:29.000000000","message":"Could you use assertRaisesRegexp(.., Flavor\u0027s memory is too small for requested image,..) ? just to be sure that the BadRequest we got is the badrequest we expected. Because badrequest here a bit too generic.","commit_id":"88b20f191e6817ee620d14501aeb9a3e23f000b8"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"940652f73df875425ec94c2a1cbdf3983867e890","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(min_img_ram, image[\u0027min_ram\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Try to create server with flavor of insufficient ram size"},{"line_number":67,"context_line":"        self.assertRaises(lib_exc.BadRequest, self.create_test_server,"},{"line_number":68,"context_line":"                          image_id\u003dimage[\u0027id\u0027], flavor\u003dflavor[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_325faf42","line":67,"in_reply_to":"1a430d35_24abf6d7","updated":"2017-02-06 12:52:10.000000000","message":"Done","commit_id":"88b20f191e6817ee620d14501aeb9a3e23f000b8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe6422986cdc77f8a655cae969f3402247199d29","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_477b71f5","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"updated":"2017-02-07 09:46:11.000000000","message":"glance have both API v1 or v2 so based on that only client should be used.\n\n        cls.images_client \u003d cls.os.image_client_v2\n        if CONF.image_feature_enabled.api_v1:\n            cls.images_client \u003d cls.os.image_client","commit_id":"9e49e358bbafbf6df6880b975ecdaed7a2c77479"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"0f04b4154ba6a5a7f6966e030ceee567f9f17c6a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_5c8b091f","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"in_reply_to":"1a430d35_477b71f5","updated":"2017-02-08 12:06:15.000000000","message":"I was under the impression that Glance V1 was deprecated : http://docs.openstack.org/developer/glance/glanceapi.html\n\nDo we still want to cover Glance V1 api in new tests ?","commit_id":"9e49e358bbafbf6df6880b975ecdaed7a2c77479"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9d320cdbb5f7fa4fb4a74e805b638346889ef19","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_d8dc0f1b","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"in_reply_to":"1a430d35_5c8b091f","updated":"2017-02-10 06:04:41.000000000","message":"yea those are deprecated not yet removed and tempest can be run against any cloud where people still using v1. based on config tests can consume cloud enabled API.","commit_id":"9e49e358bbafbf6df6880b975ecdaed7a2c77479"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe6422986cdc77f8a655cae969f3402247199d29","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"},{"line_number":38,"context_line":"        \"\"\"Try boot a vm with lower than min ram"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_a738953e","line":36,"range":{"start_line":36,"start_character":61,"end_line":36,"end_character":63},"updated":"2017-02-07 09:46:11.000000000","message":"please add below decorator in this tests\n\n@test.attr(type\u003d[\u0027negative\u0027])\n @test.services(\u0027image\u0027)","commit_id":"9e49e358bbafbf6df6880b975ecdaed7a2c77479"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"0f04b4154ba6a5a7f6966e030ceee567f9f17c6a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u002790f0d93a-91c1-450c-91e6-07d18172cefe\u0027)"},{"line_number":37,"context_line":"    def test_boot_with_low_ram(self):"},{"line_number":38,"context_line":"        \"\"\"Try boot a vm with lower than min ram"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_fcf755d0","line":36,"range":{"start_line":36,"start_character":61,"end_line":36,"end_character":63},"in_reply_to":"1a430d35_a738953e","updated":"2017-02-08 12:06:15.000000000","message":"Done","commit_id":"9e49e358bbafbf6df6880b975ecdaed7a2c77479"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"799875fb29de49ecdacb1fc49a060b3fceccb584","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":37,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_b8903bee","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"updated":"2017-02-10 06:08:36.000000000","message":"we need to fix this as per previous PS comment.\n\nRemember that we do have config options to check whether v1 or v2 enabled. If you will run this tests against cloud where v1 still exist, it will fail.\n\nTill v1 goes away completely from glance and from all stable branches we have to make tests able to consume both APIs not only runnable on Cloud if they have v2.","commit_id":"3c435efaf95341bf97b5fbecba5d29d80463fd84"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84298188b08d883134bb50a391bd1b6a6080cb9f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":37,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_8a2275a1","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"in_reply_to":"fa31d9ce_2f5be688","updated":"2017-02-15 12:19:58.000000000","message":"@Benny actually we are not duplicating tests for version 1. this tests create image using glance API and then server with nova API which is right thing to do. But here glance API can be v1 or v2 depends on testing Cloud. So we have to use v1 or v2 glance client accordingly.","commit_id":"3c435efaf95341bf97b5fbecba5d29d80463fd84"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"e903248c3b265277c079d460dbc7b5c8b5e79a1e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":37,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_9cdce0e5","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"in_reply_to":"fa31d9ce_2f5be688","updated":"2017-02-13 17:57:49.000000000","message":"Done","commit_id":"3c435efaf95341bf97b5fbecba5d29d80463fd84"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"e903248c3b265277c079d460dbc7b5c8b5e79a1e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":37,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_7cd56cb7","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"in_reply_to":"fa31d9ce_b8903bee","updated":"2017-02-13 17:57:49.000000000","message":"Done","commit_id":"3c435efaf95341bf97b5fbecba5d29d80463fd84"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"795a4841885bbb4c5668e926363ac6bb4fa6f09c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(FlavorsV2TestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        cls.images_client \u003d cls.os.image_client_v2"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":37,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_2f5be688","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":50},"in_reply_to":"fa31d9ce_b8903bee","updated":"2017-02-12 07:02:45.000000000","message":"Hi , i am a little bit confused here , the test is a nova test that checks a flavor limit, why we should duplicate this test with glance version 1 ?  \n\nBenny","commit_id":"3c435efaf95341bf97b5fbecba5d29d80463fd84"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8bac176342700ecb484554c97ca2c7e1dfe9a1a5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FlavorsV2TestJSON(base.BaseV2ComputeTest):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_7213d30d","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":23},"updated":"2017-02-13 18:31:37.000000000","message":"In new test classes, JSON is not necessary because all tests are only for JSON, not XML.\nIn addition, all negative test classes should contain Negative as the other classes. So here should be \n\n s/FlavorsV2TestJSON/FlavorsV2NegativeTest/","commit_id":"b1020c2b5f3f28c9e77c7fba7c065d9ca5137cd6"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"c6790fd1afd9380f2fa426ef2d8b2a9b11cbbe9d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FlavorsV2TestJSON(base.BaseV2ComputeTest):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_6d24d4ae","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":23},"in_reply_to":"fa31d9ce_7213d30d","updated":"2017-02-13 18:46:04.000000000","message":"Done","commit_id":"b1020c2b5f3f28c9e77c7fba7c065d9ca5137cd6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8bac176342700ecb484554c97ca2c7e1dfe9a1a5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            self.images_client.store_image_file(image[\u0027id\u0027], data\u003dimage_file)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.addCleanup(self.images_client.delete_image, image[\u0027id\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self.assertEqual(min_img_ram, image[\u0027min_ram\u0027])"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_72b833e6","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":68},"updated":"2017-02-13 18:31:37.000000000","message":"This addCleanup() could be moved to line 73 for covering the failures of update_image()/store_image_file().","commit_id":"b1020c2b5f3f28c9e77c7fba7c065d9ca5137cd6"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"7b1a45caa80428720fd92235242f0d914fa0d3f6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            self.images_client.store_image_file(image[\u0027id\u0027], data\u003dimage_file)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.addCleanup(self.images_client.delete_image, image[\u0027id\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self.assertEqual(min_img_ram, image[\u0027min_ram\u0027])"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_f13c0cca","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":68},"in_reply_to":"fa31d9ce_2d081c91","updated":"2017-02-14 07:14:55.000000000","message":"Done","commit_id":"b1020c2b5f3f28c9e77c7fba7c065d9ca5137cd6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"419209915d7a5918da3e3e2f0f8228199e62e9ff","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            self.images_client.store_image_file(image[\u0027id\u0027], data\u003dimage_file)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.addCleanup(self.images_client.delete_image, image[\u0027id\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self.assertEqual(min_img_ram, image[\u0027min_ram\u0027])"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_2d081c91","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":68},"in_reply_to":"fa31d9ce_72b833e6","updated":"2017-02-13 18:58:31.000000000","message":"not done..","commit_id":"b1020c2b5f3f28c9e77c7fba7c065d9ca5137cd6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a60109d324fb7666627ad89eceff3928d3e96ed6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        flavor \u003d self.flavors_client.show_flavor("},{"line_number":55,"context_line":"            CONF.compute.flavor_ref)[\u0027flavor\u0027]"},{"line_number":56,"context_line":"        min_img_ram \u003d int(flavor[\u0027ram\u0027]) + 1"},{"line_number":57,"context_line":"        size \u003d random.randint(1024, 4096)"},{"line_number":58,"context_line":"        image_file \u003d six.BytesIO(data_utils.random_bytes(size))"},{"line_number":59,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_1d48d1cb","line":56,"range":{"start_line":56,"start_character":26,"end_line":56,"end_character":39},"updated":"2017-02-14 09:20:19.000000000","message":"It\u0027s already an \u0027int\u0027 type","commit_id":"863b9b99f8e0aecd83f69420ba4573431401d76d"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"62f891ba83269c717e213ead40f6f65f8a423aac","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        flavor \u003d self.flavors_client.show_flavor("},{"line_number":55,"context_line":"            CONF.compute.flavor_ref)[\u0027flavor\u0027]"},{"line_number":56,"context_line":"        min_img_ram \u003d int(flavor[\u0027ram\u0027]) + 1"},{"line_number":57,"context_line":"        size \u003d random.randint(1024, 4096)"},{"line_number":58,"context_line":"        image_file \u003d six.BytesIO(data_utils.random_bytes(size))"},{"line_number":59,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_96de4d0f","line":56,"range":{"start_line":56,"start_character":26,"end_line":56,"end_character":39},"in_reply_to":"fa31d9ce_13042f48","updated":"2017-02-14 16:09:00.000000000","message":"Done","commit_id":"863b9b99f8e0aecd83f69420ba4573431401d76d"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"62f891ba83269c717e213ead40f6f65f8a423aac","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        flavor \u003d self.flavors_client.show_flavor("},{"line_number":55,"context_line":"            CONF.compute.flavor_ref)[\u0027flavor\u0027]"},{"line_number":56,"context_line":"        min_img_ram \u003d int(flavor[\u0027ram\u0027]) + 1"},{"line_number":57,"context_line":"        size \u003d random.randint(1024, 4096)"},{"line_number":58,"context_line":"        image_file \u003d six.BytesIO(data_utils.random_bytes(size))"},{"line_number":59,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_36c9215a","line":56,"range":{"start_line":56,"start_character":26,"end_line":56,"end_character":39},"in_reply_to":"fa31d9ce_1d48d1cb","updated":"2017-02-14 16:09:00.000000000","message":"Done","commit_id":"863b9b99f8e0aecd83f69420ba4573431401d76d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"392562c07713337386852f203b0624b320b54f6a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        flavor \u003d self.flavors_client.show_flavor("},{"line_number":55,"context_line":"            CONF.compute.flavor_ref)[\u0027flavor\u0027]"},{"line_number":56,"context_line":"        min_img_ram \u003d int(flavor[\u0027ram\u0027]) + 1"},{"line_number":57,"context_line":"        size \u003d random.randint(1024, 4096)"},{"line_number":58,"context_line":"        image_file \u003d six.BytesIO(data_utils.random_bytes(size))"},{"line_number":59,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_13042f48","line":56,"range":{"start_line":56,"start_character":26,"end_line":56,"end_character":39},"in_reply_to":"fa31d9ce_1d48d1cb","updated":"2017-02-14 15:55:21.000000000","message":"Good catch, that should be int as Liron said like\n\ntempest/lib/api_schema/response/compute/v2_1/flavors.py\n 44 common_flavor_info \u003d {\n 45     \u0027type\u0027: \u0027object\u0027,\n 46     \u0027properties\u0027: {\n 47         \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},\n 48         \u0027links\u0027: parameter_types.links,\n 49         \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027},          \u003cHERE\u003e\n 50         \u0027vcpus\u0027: {\u0027type\u0027: \u0027integer\u0027},\n\non jsonschema.\n\nSo it would be nice to remove int() call.","commit_id":"863b9b99f8e0aecd83f69420ba4573431401d76d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2b9c3c02b779dac8ff106a099187a88e04aee328","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027min_ram\u0027: min_img_ram"},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if CONF.image_feature_enabled.api_v1:"},{"line_number":67,"context_line":"            params.update({\u0027is_public\u0027: False})"},{"line_number":68,"context_line":"            params \u003d {\u0027headers\u0027: common_image.image_meta_to_headers(**params)}"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            params.update({\u0027visibility\u0027: \u0027private\u0027})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        image \u003d self.images_client.create_image(**params)"},{"line_number":73,"context_line":"        image \u003d image[\u0027image\u0027] if \u0027image\u0027 in image else image"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa31d9ce_2a3a6999","line":70,"range":{"start_line":66,"start_character":0,"end_line":70,"end_character":52},"updated":"2017-02-15 12:25:21.000000000","message":"this could have been done with default or public one but this is also fine.","commit_id":"27fd84ee459f81ecef08ea3650c285f76c5a303a"}]}