)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04b653c6fcc2d8c42a94e336c92adc94fb5a9b65","unresolved":false,"context_lines":[{"line_number":151,"context_line":"flavor_extra_enabled \u003d true"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Print nova req-ids to stdout"},{"line_number":154,"context_line":"print_req_id \u003d True"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"[whitebox]"},{"line_number":157,"context_line":"# Whitebox options for compute. Whitebox options enable the"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAARH%2F%2F9l4%3D","line":154,"updated":"2013-08-14 15:07:20.000000000","message":"Since this is sort of related to logging and could probably be used globally later for other tests (thinking cinder/neutron), you could move this up to the DEFAULT section by the logging configuration options so they are more logically grouped together.","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"50380d70b04d3ebc1e4c7d26904161cb117970ff","unresolved":false,"context_lines":[{"line_number":151,"context_line":"flavor_extra_enabled \u003d true"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Print nova req-ids to stdout"},{"line_number":154,"context_line":"print_req_id \u003d True"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"[whitebox]"},{"line_number":157,"context_line":"# Whitebox options for compute. Whitebox options enable the"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAARH%2F%2F9dM%3D","line":154,"in_reply_to":"AAAARH%2F%2F9l4%3D","updated":"2013-08-14 15:30:34.000000000","message":"I put it in the compute section because the request id response should only be coming from nova. I feel that it would make more sense in default if it was an option to print the req-ids from all the projects, not just nova. But, I\u0027m not sure if all the projects even return the ids I\u0027ll check. If so I\u0027ll rework this to do that and move it into the default group.","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"}],"tempest/common/rest_client.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"83934f0a2e2554a7419178141710ee0a84204a35","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        del headers[\u0027status\u0027]"},{"line_number":309,"context_line":"        if headers.get(\u0027x-compute-request-id\u0027):"},{"line_number":310,"context_line":"            if self.config.compute.print_req_id:"},{"line_number":311,"context_line":"                print(\"Nova request id: %s\" %"},{"line_number":312,"context_line":"                      headers.get(\u0027x-compute-request-id\u0027))"},{"line_number":313,"context_line":"            self.LOG.info(\"Nova request id: %s\" %"},{"line_number":314,"context_line":"                          headers.pop(\u0027x-compute-request-id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F9k4%3D","line":311,"updated":"2013-08-14 15:09:57.000000000","message":"Is this method used by other non-nova tests?  If so, printing out \u0027Nova\u0027 in here would be confusing.","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"eda47df58e045ab140739edc425017ddc4c9c866","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        del headers[\u0027status\u0027]"},{"line_number":309,"context_line":"        if headers.get(\u0027x-compute-request-id\u0027):"},{"line_number":310,"context_line":"            if self.config.compute.print_req_id:"},{"line_number":311,"context_line":"                print(\"Nova request id: %s\" %"},{"line_number":312,"context_line":"                      headers.get(\u0027x-compute-request-id\u0027))"},{"line_number":313,"context_line":"            self.LOG.info(\"Nova request id: %s\" %"},{"line_number":314,"context_line":"                          headers.pop(\u0027x-compute-request-id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F9h8%3D","line":311,"updated":"2013-08-14 15:15:32.000000000","message":"Why to print ? And why just this ?\nWhy not just use a logger ?","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0f9a279afae85ca713fe822f4ac3a9e6013b9aa3","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        del headers[\u0027status\u0027]"},{"line_number":309,"context_line":"        if headers.get(\u0027x-compute-request-id\u0027):"},{"line_number":310,"context_line":"            if self.config.compute.print_req_id:"},{"line_number":311,"context_line":"                print(\"Nova request id: %s\" %"},{"line_number":312,"context_line":"                      headers.get(\u0027x-compute-request-id\u0027))"},{"line_number":313,"context_line":"            self.LOG.info(\"Nova request id: %s\" %"},{"line_number":314,"context_line":"                          headers.pop(\u0027x-compute-request-id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F9N0%3D","line":311,"in_reply_to":"AAAARH%2F%2F9eE%3D","updated":"2013-08-14 16:27:18.000000000","message":"Ah yes, but logstash is going to make all of our dreams come true right?!","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"50380d70b04d3ebc1e4c7d26904161cb117970ff","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        del headers[\u0027status\u0027]"},{"line_number":309,"context_line":"        if headers.get(\u0027x-compute-request-id\u0027):"},{"line_number":310,"context_line":"            if self.config.compute.print_req_id:"},{"line_number":311,"context_line":"                print(\"Nova request id: %s\" %"},{"line_number":312,"context_line":"                      headers.get(\u0027x-compute-request-id\u0027))"},{"line_number":313,"context_line":"            self.LOG.info(\"Nova request id: %s\" %"},{"line_number":314,"context_line":"                          headers.pop(\u0027x-compute-request-id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F9eE%3D","line":311,"in_reply_to":"AAAARH%2F%2F9h8%3D","updated":"2013-08-14 15:30:34.000000000","message":"The goal here was to add this message and only this message to stdout for when a test fails, to help with debugging. Having the request id is useful for tracing the request through the nova debug logs, but it is normally only generally useful during failures.\n\nSince we \u0027ve moved to testr as the default test runner and we\u0027ve configured testr to capture stdout and stderror and only print them on failures. Just printing the message here will produce the desired result of displaying the req id during failures. I do change how the headers here logged here too so that the req-id will get it\u0027s own line in the log. But I don\u0027t feel that having the request id is all that useful in the log. You still have to do the manual effort of matching the log entry to the test. (and find the appropriate test in the log)","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"50380d70b04d3ebc1e4c7d26904161cb117970ff","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        del headers[\u0027status\u0027]"},{"line_number":309,"context_line":"        if headers.get(\u0027x-compute-request-id\u0027):"},{"line_number":310,"context_line":"            if self.config.compute.print_req_id:"},{"line_number":311,"context_line":"                print(\"Nova request id: %s\" %"},{"line_number":312,"context_line":"                      headers.get(\u0027x-compute-request-id\u0027))"},{"line_number":313,"context_line":"            self.LOG.info(\"Nova request id: %s\" %"},{"line_number":314,"context_line":"                          headers.pop(\u0027x-compute-request-id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F9f4%3D","line":311,"in_reply_to":"AAAARH%2F%2F9k4%3D","updated":"2013-08-14 15:30:34.000000000","message":"This request id will only be in the header for responses from nova. So if a test makes an api request to nova then it will print the request id. I was just trying to point out the request id was from nova and not another service.","commit_id":"b55e11dc9452e2b9e59a84f99350c4f71788882c"}]}