)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"573c78368ba011b36785594e36c614e17508f8ec","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            for host_record in body"},{"line_number":57,"context_line":"            if (host_record[\u0027service\u0027] \u003d\u003d \u0027compute\u0027"},{"line_number":58,"context_line":"                and (host_record[\u0027zone\u0027] \u003d\u003d availability_zone"},{"line_number":59,"context_line":"                     or availability_zone is None))"},{"line_number":60,"context_line":"        ]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _get_server_details(self, server_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_10dd9642","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":49},"updated":"2017-01-13 09:03:41.000000000","message":"(not availability_zone)\nthus you needn\u0027t change \u0027\u0027 to None in line 95","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"070f9375f7e6ed9fbe9897ec16b7ec5bb01827a0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            for host_record in body"},{"line_number":57,"context_line":"            if (host_record[\u0027service\u0027] \u003d\u003d \u0027compute\u0027"},{"line_number":58,"context_line":"                and (host_record[\u0027zone\u0027] \u003d\u003d availability_zone"},{"line_number":59,"context_line":"                     or availability_zone is None))"},{"line_number":60,"context_line":"        ]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _get_server_details(self, server_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_0e2615ce","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":49},"in_reply_to":"7a3c09a3_10dd9642","updated":"2017-01-16 05:14:43.000000000","message":"\"availability_zone is None\" is used to return all compute hosts.\nI mean, If \"availability_zone\" is set to None, return all hosts whose \"service\" is compute.\n\nI have updated line 95, for this i set defaults of config params to None.","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"573c78368ba011b36785594e36c614e17508f8ec","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                CONF.compute.live_migration_src_availability_zone"},{"line_number":91,"context_line":"        return self.create_test_server(*args, **kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_host_in_dest_zone_other_than(self, host):"},{"line_number":94,"context_line":"        availability_zone \u003d CONF.compute.live_migration_dest_availability_zone"},{"line_number":95,"context_line":"        if availability_zone \u003d\u003d \u0027\u0027:"},{"line_number":96,"context_line":"            availability_zone \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_b0c5a25c","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":54},"updated":"2017-01-13 09:03:41.000000000","message":"You can merge _get_host_in_dest_zone_other_than and _get_host_other_than into one function","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"070f9375f7e6ed9fbe9897ec16b7ec5bb01827a0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                CONF.compute.live_migration_src_availability_zone"},{"line_number":91,"context_line":"        return self.create_test_server(*args, **kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_host_in_dest_zone_other_than(self, host):"},{"line_number":94,"context_line":"        availability_zone \u003d CONF.compute.live_migration_dest_availability_zone"},{"line_number":95,"context_line":"        if availability_zone \u003d\u003d \u0027\u0027:"},{"line_number":96,"context_line":"            availability_zone \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_09fa8fbd","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":54},"in_reply_to":"7a3c09a3_b0c5a25c","updated":"2017-01-16 05:14:43.000000000","message":"Done","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"573c78368ba011b36785594e36c614e17508f8ec","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_host_in_dest_zone_other_than(self, host):"},{"line_number":94,"context_line":"        availability_zone \u003d CONF.compute.live_migration_dest_availability_zone"},{"line_number":95,"context_line":"        if availability_zone \u003d\u003d \u0027\u0027:"},{"line_number":96,"context_line":"            availability_zone \u003d None"},{"line_number":97,"context_line":"        return self._get_host_other_than("},{"line_number":98,"context_line":"            host, availability_zone\u003davailability_zone)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_30b0d2f4","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":36},"updated":"2017-01-13 09:03:41.000000000","message":"no need to do this","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20f5a30b23a22437e9d4e8e9ca16c8cae1c5095f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                              volume_backed, *block* migration is not used."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        # Live migrate an instance to another host"},{"line_number":106,"context_line":"        server_id \u003d self._create_test_server_in_src_zone("},{"line_number":107,"context_line":"            wait_until\u003d\"ACTIVE\", volume_backed\u003dvolume_backed)[\u0027id\u0027]"},{"line_number":108,"context_line":"        actual_host \u003d self._get_host_for_server(server_id)"},{"line_number":109,"context_line":"        target_host \u003d self._get_host_other_than(actual_host)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_5478ab2b","line":107,"range":{"start_line":106,"start_character":20,"end_line":107,"end_character":67},"updated":"2017-01-16 07:56:03.000000000","message":"You can directly pass the AZ. Nova does it default to None so if it si not configured None will be passed and ll be ok.\n\nself.create_test_server(wait_until\u003d\"ACTIVE\",\n                        volume_backed\u003dvolume_backed)[\u0027id\u0027],\n                        availability_zone\u003dCONF.compute.live_migration_src_availability_zone","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1301217914a998576af99b6620e371c4c652e0d1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                              volume_backed, *block* migration is not used."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        # Live migrate an instance to another host"},{"line_number":106,"context_line":"        server_id \u003d self._create_test_server_in_src_zone("},{"line_number":107,"context_line":"            wait_until\u003d\"ACTIVE\", volume_backed\u003dvolume_backed)[\u0027id\u0027]"},{"line_number":108,"context_line":"        actual_host \u003d self._get_host_for_server(server_id)"},{"line_number":109,"context_line":"        target_host \u003d self._get_host_other_than(actual_host)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3b193989","line":107,"range":{"start_line":106,"start_character":20,"end_line":107,"end_character":67},"in_reply_to":"7a3c09a3_5478ab2b","updated":"2017-01-16 15:04:18.000000000","message":"Done","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20f5a30b23a22437e9d4e8e9ca16c8cae1c5095f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                      block_migrate_cinder_iscsi,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not configured for iSCSI\u0027)"},{"line_number":153,"context_line":"    def test_iscsi_volume(self):"},{"line_number":154,"context_line":"        server \u003d self._create_test_server_in_src_zone("},{"line_number":155,"context_line":"            wait_until\u003d\"ACTIVE\")"},{"line_number":156,"context_line":"        server_id \u003d server[\u0027id\u0027]"},{"line_number":157,"context_line":"        actual_host \u003d self._get_host_for_server(server_id)"},{"line_number":158,"context_line":"        target_host \u003d self._get_host_other_than(actual_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_94721348","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":32},"updated":"2017-01-16 07:56:03.000000000","message":"ditto","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1301217914a998576af99b6620e371c4c652e0d1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                      block_migrate_cinder_iscsi,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not configured for iSCSI\u0027)"},{"line_number":153,"context_line":"    def test_iscsi_volume(self):"},{"line_number":154,"context_line":"        server \u003d self._create_test_server_in_src_zone("},{"line_number":155,"context_line":"            wait_until\u003d\"ACTIVE\")"},{"line_number":156,"context_line":"        server_id \u003d server[\u0027id\u0027]"},{"line_number":157,"context_line":"        actual_host \u003d self._get_host_for_server(server_id)"},{"line_number":158,"context_line":"        target_host \u003d self._get_host_other_than(actual_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_7b13c166","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":32},"in_reply_to":"7a3c09a3_94721348","updated":"2017-01-16 15:04:18.000000000","message":"Done","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"}],"tempest/config.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"573c78368ba011b36785594e36c614e17508f8ec","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                     \u0027be utilized by some multinode specific tests to ensure \u0027"},{"line_number":299,"context_line":"                     \u0027that requests match the expected size of the cluster \u0027"},{"line_number":300,"context_line":"                     \u0027you are testing with.\u0027)),"},{"line_number":301,"context_line":"    cfg.StrOpt(\u0027live_migration_src_availability_zone\u0027,"},{"line_number":302,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":303,"context_line":"               help\u003d\"The availability zone of the source host for live \""},{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_b073e24c","line":301,"range":{"start_line":301,"start_character":14,"end_line":301,"end_character":52},"updated":"2017-01-13 09:03:41.000000000","message":"according to bug #1626101\u0027s description, it seems no need to add two config items, is it possible to create server in zone1 and migrate it to zone2?","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"070f9375f7e6ed9fbe9897ec16b7ec5bb01827a0","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                     \u0027be utilized by some multinode specific tests to ensure \u0027"},{"line_number":299,"context_line":"                     \u0027that requests match the expected size of the cluster \u0027"},{"line_number":300,"context_line":"                     \u0027you are testing with.\u0027)),"},{"line_number":301,"context_line":"    cfg.StrOpt(\u0027live_migration_src_availability_zone\u0027,"},{"line_number":302,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":303,"context_line":"               help\u003d\"The availability zone of the source host for live \""},{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_3b979291","line":301,"range":{"start_line":301,"start_character":14,"end_line":301,"end_character":52},"in_reply_to":"7a3c09a3_b073e24c","updated":"2017-01-16 05:14:43.000000000","message":"I am not sure about this behavior.\nCurrently it seems both param should be same. But i think two params can lead to more usecases in future. Or may be if original author(bug reported and provided patch for this) can be tracked we can have some feedback against keeping two params.\nDo you have some idea about this behaviour?","commit_id":"691d9819c92fe94c6d9ade9a0133018ac0b76f5c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d7b54503c9be37cedb41d5c84c1805e0f1c80a2d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                     \u0027be utilized by some multinode specific tests to ensure \u0027"},{"line_number":299,"context_line":"                     \u0027that requests match the expected size of the cluster \u0027"},{"line_number":300,"context_line":"                     \u0027you are testing with.\u0027)),"},{"line_number":301,"context_line":"    cfg.StrOpt(\u0027live_migration_src_availability_zone\u0027,"},{"line_number":302,"context_line":"               default\u003dNone,"},{"line_number":303,"context_line":"               help\u003d\"The availability zone of the source host for live \""},{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_ea0feede","line":301,"range":{"start_line":301,"start_character":15,"end_line":301,"end_character":52},"updated":"2017-01-16 08:33:58.000000000","message":"I think if in the near future we have the possibility to have such scenario, we can add two items. If recently we are not likely to have such scenario, or that scenario is not common, then maybe we can add it later.","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1301217914a998576af99b6620e371c4c652e0d1","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                     \u0027be utilized by some multinode specific tests to ensure \u0027"},{"line_number":299,"context_line":"                     \u0027that requests match the expected size of the cluster \u0027"},{"line_number":300,"context_line":"                     \u0027you are testing with.\u0027)),"},{"line_number":301,"context_line":"    cfg.StrOpt(\u0027live_migration_src_availability_zone\u0027,"},{"line_number":302,"context_line":"               default\u003dNone,"},{"line_number":303,"context_line":"               help\u003d\"The availability zone of the source host for live \""},{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3e004701","line":301,"range":{"start_line":301,"start_character":15,"end_line":301,"end_character":52},"in_reply_to":"7a3c09a3_ea0feede","updated":"2017-01-16 15:04:18.000000000","message":"Please suggest what would be appropriate.","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20f5a30b23a22437e9d4e8e9ca16c8cae1c5095f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                     \u0027you are testing with.\u0027)),"},{"line_number":301,"context_line":"    cfg.StrOpt(\u0027live_migration_src_availability_zone\u0027,"},{"line_number":302,"context_line":"               default\u003dNone,"},{"line_number":303,"context_line":"               help\u003d\"The availability zone of the source host for live \""},{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"},{"line_number":305,"context_line":"    cfg.StrOpt(\u0027live_migration_dest_availability_zone\u0027,"},{"line_number":306,"context_line":"               default\u003dNone,"},{"line_number":307,"context_line":"               help\u003d\"The availability zone of the destination host for live \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_f40c3796","line":304,"range":{"start_line":303,"start_character":21,"end_line":304,"end_character":66},"updated":"2017-01-16 07:56:03.000000000","message":"\"The availability zone of the source host for live \"\n\"migration. Test server for live migration will be booted from this availability zone .\"","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1301217914a998576af99b6620e371c4c652e0d1","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                     \u0027you are testing with.\u0027)),"},{"line_number":301,"context_line":"    cfg.StrOpt(\u0027live_migration_src_availability_zone\u0027,"},{"line_number":302,"context_line":"               default\u003dNone,"},{"line_number":303,"context_line":"               help\u003d\"The availability zone of the source host for live \""},{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"},{"line_number":305,"context_line":"    cfg.StrOpt(\u0027live_migration_dest_availability_zone\u0027,"},{"line_number":306,"context_line":"               default\u003dNone,"},{"line_number":307,"context_line":"               help\u003d\"The availability zone of the destination host for live \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_fb07b119","line":304,"range":{"start_line":303,"start_character":21,"end_line":304,"end_character":66},"in_reply_to":"7a3c09a3_f40c3796","updated":"2017-01-16 15:04:18.000000000","message":"Done","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20f5a30b23a22437e9d4e8e9ca16c8cae1c5095f","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"},{"line_number":305,"context_line":"    cfg.StrOpt(\u0027live_migration_dest_availability_zone\u0027,"},{"line_number":306,"context_line":"               default\u003dNone,"},{"line_number":307,"context_line":"               help\u003d\"The availability zone of the destination host for live \""},{"line_number":308,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"},{"line_number":309,"context_line":"    cfg.StrOpt(\u0027hypervisor_type\u0027,"},{"line_number":310,"context_line":"               default\u003dNone,"},{"line_number":311,"context_line":"               help\u003d\"Hypervisor type of the test target on heterogeneous \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_b479cffe","line":308,"range":{"start_line":307,"start_character":20,"end_line":308,"end_character":66},"updated":"2017-01-16 07:56:03.000000000","message":"\"The availability zone of the destination host for live \"\n\"migration. Test server will be migrated to compute host under this availability zone .\"","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1301217914a998576af99b6620e371c4c652e0d1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"},{"line_number":305,"context_line":"    cfg.StrOpt(\u0027live_migration_dest_availability_zone\u0027,"},{"line_number":306,"context_line":"               default\u003dNone,"},{"line_number":307,"context_line":"               help\u003d\"The availability zone of the destination host for live \""},{"line_number":308,"context_line":"                    \"migration. Leave empty if it doesn\u0027t matter.\"),"},{"line_number":309,"context_line":"    cfg.StrOpt(\u0027hypervisor_type\u0027,"},{"line_number":310,"context_line":"               default\u003dNone,"},{"line_number":311,"context_line":"               help\u003d\"Hypervisor type of the test target on heterogeneous \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_1b039d10","line":308,"range":{"start_line":307,"start_character":20,"end_line":308,"end_character":66},"in_reply_to":"7a3c09a3_b479cffe","updated":"2017-01-16 15:04:18.000000000","message":"Done","commit_id":"bca81fe29eae6eac3f6a0d38affeced0eb0b3464"}]}