)]}'
{"tempest/api/compute/admin/test_baremetal_nodes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"092559308aa2c7d496acf6f963174916e995a030","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            skip_msg \u003d (\u0027%s skipped as Ironic is not available\u0027 % cls.__name__)"},{"line_number":30,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":31,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":32,"context_line":"        cls.ironic_client \u003d cls.os_adm.baremetal_client"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @test.attr(type\u003d[\u0027baremetal\u0027])"},{"line_number":35,"context_line":"    @test.idempotent_id(\u0027e475aa6e-416d-4fa4-b3af-28d5e84250fb\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_bd853d5a","side":"PARENT","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":55},"updated":"2017-01-15 23:52:09.000000000","message":"this is something we need to fix. Update Ironic plugin to register baremetal client via new mechanism and then use i there.","commit_id":"3125625e0f7904f138e1ed0c5a9e5321c68f686c"}],"tempest/api/compute/admin/test_hypervisor.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"794c9a240068b70ac179d805e2175aa50b61e421","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        # Verify that GET shows the specified hypervisor uptime"},{"line_number":80,"context_line":"        hypers \u003d self._list_hypervisors()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Ironic will register each baremetal node as a \u0027hypervisor\u0027,"},{"line_number":83,"context_line":"        # so the hypervisor list can contain many hypervisors of type"},{"line_number":84,"context_line":"        # \u0027ironic\u0027. If they are ALL ironic, skip this test since ironic"},{"line_number":85,"context_line":"        # doesn\u0027t support hypervisor uptime. Otherwise, remove them"},{"line_number":86,"context_line":"        # from the list of hypervisors to test."},{"line_number":87,"context_line":"        ironic_only \u003d True"},{"line_number":88,"context_line":"        hypers_without_ironic \u003d []"},{"line_number":89,"context_line":"        for hyper in hypers:"},{"line_number":90,"context_line":"            details \u003d (self.client.show_hypervisor(hyper[\u0027id\u0027])"},{"line_number":91,"context_line":"                       [\u0027hypervisor\u0027])"},{"line_number":92,"context_line":"            if details[\u0027hypervisor_type\u0027] !\u003d \u0027ironic\u0027:"},{"line_number":93,"context_line":"                hypers_without_ironic.append(hyper)"},{"line_number":94,"context_line":"                ironic_only \u003d False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if ironic_only:"},{"line_number":97,"context_line":"            raise self.skipException("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_fefe1404","side":"PARENT","line":94,"range":{"start_line":82,"start_character":0,"end_line":94,"end_character":35},"updated":"2017-01-25 21:53:14.000000000","message":"I feel a concern about this removal.\n\nWe have removed Ironic API tests and it is nice to remove it if Tempest still has.\n\nHowever, I don\u0027t think Tempest should not support/consider OpenStack cloud which consist of Ironic as one of backends.\nYes, this code seems a little tricky and OpenStack abstraction layer doesn\u0027t work very well. But this test class is an admin test class and administrators need to consider backends as their own responsibility. So it is good to keep this code I think.","commit_id":"4f25fc846a572d43e3d1de2fd75286692e850e55"}],"tempest/hacking/checks.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"092559308aa2c7d496acf6f963174916e995a030","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import pep8"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"PYTHON_CLIENTS \u003d [\u0027cinder\u0027, \u0027glance\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027swift\u0027, \u0027neutron\u0027,"},{"line_number":22,"context_line":"                  \u0027heat\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"PYTHON_CLIENT_RE \u003d re.compile(\u0027import (%s)client\u0027 % \u0027|\u0027.join(PYTHON_CLIENTS))"},{"line_number":25,"context_line":"TEST_DEFINITION \u003d re.compile(r\u0027^\\s*def test.*\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_dda5a904","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":25},"updated":"2017-01-15 23:52:09.000000000","message":"Nice catch, this can be cleaned up","commit_id":"fa47993e0c9ad1a8d39631d076585c05f7c38441"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"794c9a240068b70ac179d805e2175aa50b61e421","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import pep8"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"PYTHON_CLIENTS \u003d [\u0027cinder\u0027, \u0027glance\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027swift\u0027, \u0027neutron\u0027,"},{"line_number":22,"context_line":"                  \u0027heat\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"PYTHON_CLIENT_RE \u003d re.compile(\u0027import (%s)client\u0027 % \u0027|\u0027.join(PYTHON_CLIENTS))"},{"line_number":25,"context_line":"TEST_DEFINITION \u003d re.compile(r\u0027^\\s*def test.*\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_fe2534ae","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":25},"updated":"2017-01-25 21:53:14.000000000","message":"This change is good for me.","commit_id":"2eb2703ab1e6e379805f6f7418786ba6aaf7f148"}]}