)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"6e22e03421246c75b3a70ddaf2eebaef171bf970","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Cleanup: Add common \"create_server\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In scenario tests, there are many \"create server\" methods and their"},{"line_number":10,"context_line":"behaviors are almost same. They creates a server with randam name,"},{"line_number":11,"context_line":"default image and default flavor, and waits for server status \"ACTIVE\"."},{"line_number":12,"context_line":"So this patch adds a common \"create_server\" method and uses the method"},{"line_number":13,"context_line":"instead of each implementation for code-cleanup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAARH%2F%2F2sk%3D","line":10,"updated":"2013-08-16 06:35:39.000000000","message":"\"random\"","commit_id":"049f371d56c7ece0cc7740e313a6ad2f7ae14fc8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"45b93f0f29be686ee2bf452802b63771c40ba32a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Cleanup: Add common \"create_server\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In scenario tests, there are many \"create server\" methods and their"},{"line_number":10,"context_line":"behaviors are almost same. They creates a server with randam name,"},{"line_number":11,"context_line":"default image and default flavor, and waits for server status \"ACTIVE\"."},{"line_number":12,"context_line":"So this patch adds a common \"create_server\" method and uses the method"},{"line_number":13,"context_line":"instead of each implementation for code-cleanup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAARH%2F%2F2ro%3D","line":10,"in_reply_to":"AAAARH%2F%2F2sk%3D","updated":"2013-08-16 06:40:11.000000000","message":"Oops, thanks.","commit_id":"049f371d56c7ece0cc7740e313a6ad2f7ae14fc8"}],"tempest/scenario/manager.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4ceaaf3fb2f693c71e8a2bdaa8bb54bb93b25544","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        LOG.debug(\"Creating a server (name: %s, image: %s, flavor: %s)\","},{"line_number":270,"context_line":"                  name, image, flavor)"},{"line_number":271,"context_line":"        server \u003d client.servers.create(name, image, flavor, **create_kwargs)"},{"line_number":272,"context_line":"        try:"},{"line_number":273,"context_line":"            self.assertEqual(server.name, name)"},{"line_number":274,"context_line":"            self.set_resource(name, server)"},{"line_number":275,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARH%2F%2F2DY%3D","line":272,"updated":"2013-08-16 12:32:04.000000000","message":"what is the reason to catch this particular exception here? when would it be raised? can\u0027t we just let the test to fail?","commit_id":"61f272b03dc79f97f475af2cb6e3f2cf86bedf84"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"62c8b434b80385c44b8c922fbad57bd953820966","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        LOG.debug(\"Creating a server (name: %s, image: %s, flavor: %s)\","},{"line_number":270,"context_line":"                  name, image, flavor)"},{"line_number":271,"context_line":"        server \u003d client.servers.create(name, image, flavor, **create_kwargs)"},{"line_number":272,"context_line":"        try:"},{"line_number":273,"context_line":"            self.assertEqual(server.name, name)"},{"line_number":274,"context_line":"            self.set_resource(name, server)"},{"line_number":275,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARH%2F%2F1ks%3D","line":272,"in_reply_to":"AAAARH%2F%2F11Y%3D","updated":"2013-08-16 14:14:09.000000000","message":"I can\u0027t recall. But not this change introduces it, so it is out of scope now.","commit_id":"61f272b03dc79f97f475af2cb6e3f2cf86bedf84"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d18c5c596191bb86b25a5f075aa1299505e97218","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        LOG.debug(\"Creating a server (name: %s, image: %s, flavor: %s)\","},{"line_number":270,"context_line":"                  name, image, flavor)"},{"line_number":271,"context_line":"        server \u003d client.servers.create(name, image, flavor, **create_kwargs)"},{"line_number":272,"context_line":"        try:"},{"line_number":273,"context_line":"            self.assertEqual(server.name, name)"},{"line_number":274,"context_line":"            self.set_resource(name, server)"},{"line_number":275,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARH%2F%2F11Y%3D","line":272,"in_reply_to":"AAAARH%2F%2F12o%3D","updated":"2013-08-16 12:57:37.000000000","message":"but what is that could be raising an AttributeErrror exception?","commit_id":"61f272b03dc79f97f475af2cb6e3f2cf86bedf84"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"485835180251a39289139eac8c950718ddba0242","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        LOG.debug(\"Creating a server (name: %s, image: %s, flavor: %s)\","},{"line_number":270,"context_line":"                  name, image, flavor)"},{"line_number":271,"context_line":"        server \u003d client.servers.create(name, image, flavor, **create_kwargs)"},{"line_number":272,"context_line":"        try:"},{"line_number":273,"context_line":"            self.assertEqual(server.name, name)"},{"line_number":274,"context_line":"            self.set_resource(name, server)"},{"line_number":275,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAARH%2F%2F12o%3D","line":272,"in_reply_to":"AAAARH%2F%2F2DY%3D","updated":"2013-08-16 12:54:06.000000000","message":"I think in this case we\u0027ll end up with a more useful error message by catching the attribute error. Otherwise people will have to dig through the code more","commit_id":"61f272b03dc79f97f475af2cb6e3f2cf86bedf84"}]}