)]}'
{"tempest/api/compute/admin/test_networks.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            configured_network \u003d CONF.compute.fixed_network_name"},{"line_number":62,"context_line":"            self.assertIn(configured_network, [x[\u0027label\u0027] for x in networks])"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            network_name \u003d list(map(lambda x: x[\u0027label\u0027], networks))"},{"line_number":65,"context_line":"            self.assertGreaterEqual(len(network_name), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_a449e6d2","line":64,"updated":"2017-01-19 10:37:32.000000000","message":"Use a list comprehension. list(map(lambda  is starting to get a bit heavy.","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"295d9c2e6c4f8490e03527468e9db190b5ed48e8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            configured_network \u003d CONF.compute.fixed_network_name"},{"line_number":62,"context_line":"            self.assertIn(configured_network, [x[\u0027label\u0027] for x in networks])"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            network_name \u003d list(map(lambda x: x[\u0027label\u0027], networks))"},{"line_number":65,"context_line":"            self.assertGreaterEqual(len(network_name), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_2ba2c3ae","line":64,"in_reply_to":"5a3905b3_a449e6d2","updated":"2017-01-20 20:00:31.000000000","message":"Done","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"}],"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":102,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue, **params)"},{"line_number":103,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":104,"context_line":"        servers_name \u003d list(map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":105,"context_line":"        self.assertNotIn(self.s1_name, servers_name)"},{"line_number":106,"context_line":"        self.assertNotIn(self.s2_name, servers_name)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_e4784efb","line":104,"updated":"2017-01-19 10:37:32.000000000","message":"same","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"295d9c2e6c4f8490e03527468e9db190b5ed48e8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        params \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":102,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue, **params)"},{"line_number":103,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":104,"context_line":"        servers_name \u003d list(map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":105,"context_line":"        self.assertNotIn(self.s1_name, servers_name)"},{"line_number":106,"context_line":"        self.assertNotIn(self.s2_name, servers_name)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_4ba54fb3","line":104,"in_reply_to":"5a3905b3_e4784efb","updated":"2017-01-20 20:00:31.000000000","message":"Done","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: tenant_id}"},{"line_number":110,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue, **params)"},{"line_number":111,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":112,"context_line":"        servers_name \u003d list(map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":113,"context_line":"        self.assertIn(self.s1_name, servers_name)"},{"line_number":114,"context_line":"        self.assertIn(self.s2_name, servers_name)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_c47432ff","line":112,"updated":"2017-01-19 10:37:32.000000000","message":"same","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"295d9c2e6c4f8490e03527468e9db190b5ed48e8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: tenant_id}"},{"line_number":110,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue, **params)"},{"line_number":111,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":112,"context_line":"        servers_name \u003d list(map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":113,"context_line":"        self.assertIn(self.s1_name, servers_name)"},{"line_number":114,"context_line":"        self.assertIn(self.s2_name, servers_name)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_6baccba0","line":112,"in_reply_to":"5a3905b3_c47432ff","updated":"2017-01-20 20:00:31.000000000","message":"Done","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: admin_tenant_id}"},{"line_number":119,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue, **params)"},{"line_number":120,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":121,"context_line":"        servers_name \u003d list(map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":122,"context_line":"        self.assertNotIn(self.s1_name, servers_name)"},{"line_number":123,"context_line":"        self.assertNotIn(self.s2_name, servers_name)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_245a5684","line":121,"updated":"2017-01-19 10:37:32.000000000","message":"same","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"295d9c2e6c4f8490e03527468e9db190b5ed48e8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        params \u003d {\u0027all_tenants\u0027: \u0027\u0027, \u0027tenant_id\u0027: admin_tenant_id}"},{"line_number":119,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue, **params)"},{"line_number":120,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":121,"context_line":"        servers_name \u003d list(map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":122,"context_line":"        self.assertNotIn(self.s1_name, servers_name)"},{"line_number":123,"context_line":"        self.assertNotIn(self.s2_name, servers_name)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_ab96b349","line":121,"in_reply_to":"5a3905b3_245a5684","updated":"2017-01-20 20:00:31.000000000","message":"Done","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"}],"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(VolumesBackupsAdminV2Test, cls).skip_checks()"},{"line_number":33,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":34,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":35,"context_line":"        if not CONF.service_available.swift:"},{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":37,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_e4edae8f","line":35,"updated":"2017-01-19 10:37:32.000000000","message":"That\u0027s wrong. Swift is not the only backend for Volume backups.","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"295d9c2e6c4f8490e03527468e9db190b5ed48e8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(VolumesBackupsAdminV2Test, cls).skip_checks()"},{"line_number":33,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":34,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":35,"context_line":"        if not CONF.service_available.swift:"},{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":37,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_2bde4311","line":35,"in_reply_to":"5a3905b3_e4edae8f","updated":"2017-01-20 20:00:31.000000000","message":"What others are there Jordan? I see other people end up doing this too http://git.openstack.org/cgit/openstack/murano/tree/murano_tempest_tests/tests/scenario/application_catalog/test_cinder_volumes.py#n438","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8d394b7f81deb84ea4bb7cbeb5cdc1295adf425c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(VolumesBackupsAdminV2Test, cls).skip_checks()"},{"line_number":33,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":34,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":35,"context_line":"        if not CONF.service_available.swift:"},{"line_number":36,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":37,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_11160cf1","line":35,"updated":"2017-01-21 10:48:17.000000000","message":"Guys, this was wrong. We have a lot of backends for cinder backup: https://github.com/openstack/cinder/tree/master/cinder/backup/drivers\n\nNow this test is going to be skipped for several vendors which reduce their coverage. \n\nAlso, this was not related to Python3, so this shouldn\"t have been packed in this change.\n\n\nLuckily those 2 lines should be easy to remove.","commit_id":"816607c6a70a66e1333cf2a9c702d435781571ac"}],"tempest/api/volume/admin/v2/test_backends_capabilities.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Returns a tuple of VOLUME_STATS values"},{"line_number":75,"context_line":"        expected_list \u003d list(map(operator.itemgetter(*VOLUME_STATS),"},{"line_number":76,"context_line":"                             cinder_pools))"},{"line_number":77,"context_line":"        observed_list \u003d list(map(operator.itemgetter(*VOLUME_STATS),"},{"line_number":78,"context_line":"                             capabilities))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_44eda28a","line":75,"updated":"2017-01-19 10:37:32.000000000","message":"ok.","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bc6722f4c73d66c3765fe348b2da86f69e3688bb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(VolumesBackupsV2Test, cls).skip_checks()"},{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":31,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":32,"context_line":"        if not CONF.service_available.swift:"},{"line_number":33,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":34,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_c4f9924f","line":32,"updated":"2017-01-19 10:37:32.000000000","message":"That\u0027s not correct.","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"295d9c2e6c4f8490e03527468e9db190b5ed48e8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(VolumesBackupsV2Test, cls).skip_checks()"},{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":31,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":32,"context_line":"        if not CONF.service_available.swift:"},{"line_number":33,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":34,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_8b02d76d","line":32,"in_reply_to":"5a3905b3_c4f9924f","updated":"2017-01-20 20:00:31.000000000","message":"ditto","commit_id":"3a51cdb438c0f2fdc1dfe4325a81e5b54fa713ac"}]}
