)]}'
{"tempest/api/object_storage/base.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"41c4feddff01545d9942039b404e579f04b4c24a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        swift_role \u003d cls.config.object_storage.operator_role"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        for user in [primary_user, alt_user]:"},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                resp, roles \u003d cls.os_admin.identity_client.list_roles()"},{"line_number":84,"context_line":"                role \u003d next(r for r in roles if r[\u0027name\u0027] \u003d\u003d swift_role)"},{"line_number":85,"context_line":"            except StopIteration:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F7KE%3D","line":82,"updated":"2013-08-20 06:33:36.000000000","message":"This should be outside of the loop, and would be even better if it would run maximum once per process.\n\nIt can be done by singleton decorator, or by using module variable with None initial value and filled with the id on the first use.\n\nDeterminate  it on module load time is not really recommended, because it causes a request.","commit_id":"3eb3cd5970226c966d720be73b4c43e345ad6a34"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"67e7cba8e4c2b981d1aa4ed481d516b2c654dfb6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        swift_role \u003d cls.config.object_storage.operator_role"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        for user in [primary_user, alt_user]:"},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                resp, roles \u003d cls.os_admin.identity_client.list_roles()"},{"line_number":84,"context_line":"                role \u003d next(r for r in roles if r[\u0027name\u0027] \u003d\u003d swift_role)"},{"line_number":85,"context_line":"            except StopIteration:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F4SE%3D","line":82,"in_reply_to":"AAAARn%2F%2F5Sg%3D","updated":"2013-08-20 19:13:33.000000000","message":"I see a minor issue with the repetition, but it does not really worth to spend more effort on it now.","commit_id":"3eb3cd5970226c966d720be73b4c43e345ad6a34"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df462ca7ddf6c74eb0819b034825c9256c91f59a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        swift_role \u003d cls.config.object_storage.operator_role"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        for user in [primary_user, alt_user]:"},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                resp, roles \u003d cls.os_admin.identity_client.list_roles()"},{"line_number":84,"context_line":"                role \u003d next(r for r in roles if r[\u0027name\u0027] \u003d\u003d swift_role)"},{"line_number":85,"context_line":"            except StopIteration:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F5Sg%3D","line":82,"in_reply_to":"AAAARn%2F%2F7KE%3D","updated":"2013-08-20 14:50:16.000000000","message":"I\u0027ll move it outside the loop, I agree there is no reason to run it twice for each test class.\n\nBut, I\u0027m fine with the list being called once per swift test class. While the roleid should not change from the first list. I don\u0027t see a problem with making the list call a few times it\u0027s an inexpensive operation.","commit_id":"3eb3cd5970226c966d720be73b4c43e345ad6a34"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"756735df5ca87263bde2f52e8e7e9e9564756a74","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.os \u003d clients.Manager(username\u003dusername,"},{"line_number":40,"context_line":"                                     password\u003dpassword,"},{"line_number":41,"context_line":"                                     tenant_name\u003dtenant_name)"},{"line_number":42,"context_line":"            # Get isolated creds for admin user"},{"line_number":43,"context_line":"            admin_creds \u003d cls.isolated_creds.get_admin_creds()"},{"line_number":44,"context_line":"            admin_username, admin_tenant_name, admin_password \u003d admin_creds"},{"line_number":45,"context_line":"            cls.os_admin \u003d clients.Manager(username\u003dadmin_username,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAARn%2F%2F4Rk%3D","line":42,"updated":"2013-08-20 19:13:24.000000000","message":"Do we really need a new admin user ?","commit_id":"3fdb80c3e8bfdf3bdc18bccef2117b87d19fe65e"}],"tempest/config.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"45fa4a52aa02111057d3c620ea0965491304dd66","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                help\u003d\"Set to True if the Account Quota middleware is enabled\"),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027operator_role\u0027,"},{"line_number":373,"context_line":"               default\u003d\u0027Member\u0027,"},{"line_number":374,"context_line":"               help\u003d\"Role to add to users for created for swift tests to \""},{"line_number":375,"context_line":"                    \"enable creating containers\"),"},{"line_number":376,"context_line":"]"},{"line_number":377,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARn%2F%2F%2BUQ%3D","line":374,"updated":"2013-08-19 13:32:34.000000000","message":"Is that a surplus \"for\" in that sentence?","commit_id":"c1b07250ce67b8c1a7a98b9e07869b45427f1a41"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"f1dbded7e4b4e21c465d07c228e89e1c4294cd51","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                help\u003d\"Set to True if the Account Quota middleware is enabled\"),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027operator_role\u0027,"},{"line_number":373,"context_line":"               default\u003d\u0027Member\u0027,"},{"line_number":374,"context_line":"               help\u003d\"Role to add to users for created for swift tests to \""},{"line_number":375,"context_line":"                    \"enable creating containers\"),"},{"line_number":376,"context_line":"]"},{"line_number":377,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARn%2F%2F%2BLs%3D","line":374,"in_reply_to":"AAAARn%2F%2F%2BUQ%3D","updated":"2013-08-19 14:13:09.000000000","message":"Done","commit_id":"c1b07250ce67b8c1a7a98b9e07869b45427f1a41"}]}