)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d0bb243b01c134e7a3ef1d5cac5c96ac627c9d9e","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            self._log_net_info(e)"},{"line_number":953,"context_line":"            raise"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":956,"context_line":"                                   nic\u003dNone):"},{"line_number":957,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_da0316b7","line":955,"range":{"start_line":955,"start_character":8,"end_line":955,"end_character":34},"updated":"2017-01-26 06:45:23.000000000","message":"if no elsewhere use of _check_remote_connectivity, will it be better to merge into check_remote_connectivity?","commit_id":"278b029df3c877a4a972f9ceb83ea17e259745a0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"05803f1c613cebf873f533ab80443645772a191c","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            self._log_net_info(e)"},{"line_number":953,"context_line":"            raise"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":956,"context_line":"                                   nic\u003dNone):"},{"line_number":957,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_0b27e712","line":955,"range":{"start_line":955,"start_character":8,"end_line":955,"end_character":34},"in_reply_to":"3a461143_da0316b7","updated":"2017-01-26 23:43:54.000000000","message":"done\n\n(i looked at other projects but could not find direct users of this method.)","commit_id":"278b029df3c877a4a972f9ceb83ea17e259745a0"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"f374684490aff4acbd597832ba1abb4586ddd9bd","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                                          1)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":980,"context_line":"                                  nic\u003dNone):"},{"line_number":981,"context_line":"        source_host \u003d source.ssh_client.host"},{"line_number":982,"context_line":"        if should_succeed:"},{"line_number":983,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_39224102","line":980,"updated":"2017-01-26 21:09:37.000000000","message":"It seems identical to _check_remote_connectivity. Why not adding adding the message to _check_remote_connectivity if that all you want to add in this function?","commit_id":"278b029df3c877a4a972f9ceb83ea17e259745a0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6b639d6b64213ff57ba43931323b757130c25746","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                                          1)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":980,"context_line":"                                  nic\u003dNone):"},{"line_number":981,"context_line":"        source_host \u003d source.ssh_client.host"},{"line_number":982,"context_line":"        if should_succeed:"},{"line_number":983,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_43eef6b4","line":980,"in_reply_to":"3a461143_04b6d53c","updated":"2017-01-29 22:37:45.000000000","message":"because i haven\u0027t checked existing users.\ni merged them in the latest patchset.","commit_id":"278b029df3c877a4a972f9ceb83ea17e259745a0"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"99ccb073ea9101d75429ac006e6bed882eb906d2","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                                          1)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":980,"context_line":"                                  nic\u003dNone):"},{"line_number":981,"context_line":"        source_host \u003d source.ssh_client.host"},{"line_number":982,"context_line":"        if should_succeed:"},{"line_number":983,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_04b6d53c","line":980,"in_reply_to":"3a461143_1c69f3be","updated":"2017-01-27 17:47:53.000000000","message":"Then why not put assert in _check_remote_connectivity?","commit_id":"278b029df3c877a4a972f9ceb83ea17e259745a0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9e87cf7f24f708ac437b3fefe1e3ceef12cd2608","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                                          1)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":980,"context_line":"                                  nic\u003dNone):"},{"line_number":981,"context_line":"        source_host \u003d source.ssh_client.host"},{"line_number":982,"context_line":"        if should_succeed:"},{"line_number":983,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_1c69f3be","line":980,"in_reply_to":"3a461143_39224102","updated":"2017-01-26 21:19:45.000000000","message":"assertTrue call is the main part of change.  the message is just a bonus.","commit_id":"278b029df3c877a4a972f9ceb83ea17e259745a0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0bf17a91554d3a371018140982819aab055c866b","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                return not should_succeed"},{"line_number":972,"context_line":"            return should_succeed"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        result \u003d test_utils.call_until_true(ping_remote,"},{"line_number":975,"context_line":"                                            CONF.validation.ping_timeout,"},{"line_number":976,"context_line":"                                            1)"},{"line_number":977,"context_line":"        return result"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":980,"context_line":"                                  nic\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_52da21e9","line":977,"range":{"start_line":974,"start_character":0,"end_line":977,"end_character":21},"updated":"2017-02-23 18:25:33.000000000","message":"nit: it is not necessary to change here at all..","commit_id":"522d6490028e632ad0c86d65cbfa668a8ea69424"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a98c8222234abc071e169212b1b319a211e73791","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                return not should_succeed"},{"line_number":972,"context_line":"            return should_succeed"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        result \u003d test_utils.call_until_true(ping_remote,"},{"line_number":975,"context_line":"                                            CONF.validation.ping_timeout,"},{"line_number":976,"context_line":"                                            1)"},{"line_number":977,"context_line":"        return result"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":980,"context_line":"                                  nic\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_efed8326","line":977,"range":{"start_line":974,"start_character":0,"end_line":977,"end_character":21},"in_reply_to":"da36d5c6_52da21e9","updated":"2017-02-28 22:25:15.000000000","message":"Done","commit_id":"522d6490028e632ad0c86d65cbfa668a8ea69424"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a2129473feb2d0070e0e1116d08f026fb0092d99","unresolved":false,"context_lines":[{"line_number":932,"context_line":"        :param dest: and IP to ping against"},{"line_number":933,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":934,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":935,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":936,"context_line":"        :returns: ping is false if ping failed"},{"line_number":937,"context_line":"        \"\"\""},{"line_number":938,"context_line":"        def ping_remote():"},{"line_number":939,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_57ed418a","side":"PARENT","line":936,"range":{"start_line":935,"start_character":0,"end_line":936,"end_character":46},"updated":"2017-03-01 00:52:52.000000000","message":"nit: it is not necessary to remove these lines..","commit_id":"efdb3f67d1f2e5fdad41a905ab594ef7243bf7aa"}],"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e8f51e7acd07e08c500c3eac7de41311d2c27037","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    def _test_in_tenant_block(self, tenant):"},{"line_number":366,"context_line":"        access_point_ssh \u003d self._connect_to_access_point(tenant)"},{"line_number":367,"context_line":"        for server in tenant.servers:"},{"line_number":368,"context_line":"            self.check_remote_connectivity(source\u003daccess_point_ssh,"},{"line_number":369,"context_line":"                                           dest\u003dself._get_server_ip(server),"},{"line_number":370,"context_line":"                                           should_succeed\u003dFalse)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def _test_in_tenant_allow(self, tenant):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_c47b4228","line":369,"range":{"start_line":368,"start_character":0,"end_line":369,"end_character":76},"updated":"2017-02-02 09:03:51.000000000","message":"it seems the parameters\u0027 names are clear enough, so maybe we can just write:\n            self.check_remote_connectivity(access_point_ssh,\n                               self._get_server_ip(server), \njust as line 416","commit_id":"ddd399dbed8b27a3819c8e12bd58dd45c6b85b2c"}]}