)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"c7183cee44e39095644d2e9ae0ca3316a6c5202e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create servers without network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a configuration option to create test servers without"},{"line_number":10,"context_line":"a tenant network. If create_server_with_network is set to false,"},{"line_number":11,"context_line":"the test servers will be created without a network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ida745817f8361498ae1d85dee56f83e23be72c27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_6c6c509d","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":51},"updated":"2017-01-25 16:35:11.000000000","message":"So it might be useful to explain why this is needed for other reviewers.\n\n\"Booting without a network is a supported configuration by OpenStack.  There aren\u0027t currently tests that validate this.\n\nIt is also needed by the PowerVM team as we\u0027re merging our driver into Nova.  The Nova core team has requested a running CI for the PowerVM in tree driver, even for first patch set.  The first patch set is minimal, so that reviewers don\u0027t have 10k+ LoC to review.  This test is needed to demonstrate spawn works on that first patch set.\n\nSubsequent patches will add support for the networking.\"\n\nMaybe those second two paragraphs are just put in a comment though.","commit_id":"cf5adf1adc672b73e273a5d6a3758391e86a4587"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"c7183cee44e39095644d2e9ae0ca3316a6c5202e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":224,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name(cls.__name__ + \"-server\")"},{"line_number":225,"context_line":"        if CONF.compute.create_server_with_network:"},{"line_number":226,"context_line":"            tenant_network \u003d cls.get_tenant_network()"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            tenant_network \u003d None"},{"line_number":229,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":230,"context_line":"            cls.os,"},{"line_number":231,"context_line":"            validatable,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4ce4f40c","line":228,"range":{"start_line":225,"start_character":0,"end_line":228,"end_character":33},"updated":"2017-01-25 16:35:11.000000000","message":"I don\u0027t know that we want ALL VMs to deploy without networks.\n\nI\u0027d propose the following.  Take in a new attribute that is optional \u0027use_networking\u003dTrue\u0027.\n\nThen make a new, very simple test, that just makes sure you can boot a VM with that use_networking\u003dFalse.","commit_id":"cf5adf1adc672b73e273a5d6a3758391e86a4587"}],"tempest/config.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e49aa3153683d293160cd2c0fad9f337f85886f3","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    cfg.BoolOpt(\u0027create_server_with_network\u0027,"},{"line_number":326,"context_line":"                default\u003dTrue,"},{"line_number":327,"context_line":"                help\u003d\"Whether or not the servers should be created with \""},{"line_number":328,"context_line":"                     \"a network associated to them. If set to False, the \""},{"line_number":329,"context_line":"                     \"servers will not be created with a network.\"),"},{"line_number":330,"context_line":"]"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_a98e2a25","line":328,"range":{"start_line":328,"start_character":43,"end_line":328,"end_character":45},"updated":"2017-01-25 16:23:13.000000000","message":"with","commit_id":"cf5adf1adc672b73e273a5d6a3758391e86a4587"}]}