)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"9acca2d2df81bf1cf107d7e0c5174d88de94e2ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eran Kuris \u003cekuris@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-25 16:40:57 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Its basic case of testing port_security_enabled\u003dfalse."},{"line_number":8,"context_line":"Creating from scratch network with port_security_enabled false"},{"line_number":9,"context_line":"and checking connecntivity."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_9f223c00","line":7,"updated":"2017-01-26 19:37:15.000000000","message":"There should be a line separate the tile and body of the commit message. \n\nCould you please reformat based on\n\n https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"96d6356066c2a0475ec4f8f83cdf98c1b2e8fdc5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"3b617f63bc40c904ca7e29a87a8036f50626c1c8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Its basic case of testing port_security_enabled\u003dfalse."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating from scratch network with port_security_enabled false"},{"line_number":10,"context_line":"and checking connecntivity."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2d232995094eb3e74d2b7952f5ef5d32045c81f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_440279b5","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":27},"updated":"2017-01-30 07:05:48.000000000","message":"Small typo in commit message. It should be \"connectivity\"","commit_id":"4e915bc41e15da630c8b5dd2ea27acc7465f8dca"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"49092f2b2a643515b09f37d176f468e4bd335b26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eran Kuris \u003cekuris@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-30 07:55:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Its basic case of testing port_security_enabled\u003dfalse."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating from scratch network with port_security_enabled false"},{"line_number":10,"context_line":"and checking connectivity."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_14123157","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2017-01-31 10:10:33.000000000","message":"What about: Testing base case when port_security_enabled\u003dFalse?","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eran Kuris \u003cekuris@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-30 07:55:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Its basic case of testing port_security_enabled\u003dfalse."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating from scratch network with port_security_enabled false"},{"line_number":10,"context_line":"and checking connectivity."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_20944741","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"in_reply_to":"3a461143_14123157","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if not tenant_id:"},{"line_number":719,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":720,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":721,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id,"},{"line_number":722,"context_line":"                              port_security_enabled\u003dport_security_enabled)"},{"line_number":723,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":724,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":725,"context_line":"        if CONF.network_feature_enabled.port_security:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_f13db7c4","line":722,"range":{"start_line":721,"start_character":0,"end_line":722,"end_character":74},"updated":"2017-01-31 09:44:05.000000000","message":"We should not add port_security_enabled directly without checking whether extension is enabled or not.\n\nI think L726 does the same.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if not tenant_id:"},{"line_number":719,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":720,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":721,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id,"},{"line_number":722,"context_line":"                              port_security_enabled\u003dport_security_enabled)"},{"line_number":723,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":724,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":725,"context_line":"        if CONF.network_feature_enabled.port_security:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_51492bb6","line":722,"range":{"start_line":721,"start_character":0,"end_line":722,"end_character":74},"in_reply_to":"3a461143_f13db7c4","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"49092f2b2a643515b09f37d176f468e4bd335b26","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":721,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id,"},{"line_number":722,"context_line":"                              port_security_enabled\u003dport_security_enabled)"},{"line_number":723,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":724,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":725,"context_line":"        if CONF.network_feature_enabled.port_security:"},{"line_number":726,"context_line":"            network_kwargs[\u0027port_security_enabled\u0027] \u003d port_security_enabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_1195e385","line":723,"range":{"start_line":723,"start_character":10,"end_line":723,"end_character":51},"updated":"2017-01-31 10:10:33.000000000","message":"Since this is no longer true [0] and you\u0027re overriding this check in L722 you want to either remove L723-L726 or check whether the feature is disabled in L725 instead.\n\n[0] https://wiki.openstack.org/wiki/Neutron/ML2PortSecurityExtensionDriver","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":721,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id,"},{"line_number":722,"context_line":"                              port_security_enabled\u003dport_security_enabled)"},{"line_number":723,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":724,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":725,"context_line":"        if CONF.network_feature_enabled.port_security:"},{"line_number":726,"context_line":"            network_kwargs[\u0027port_security_enabled\u0027] \u003d port_security_enabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_400313b8","line":723,"range":{"start_line":723,"start_character":10,"end_line":723,"end_character":51},"in_reply_to":"3a461143_1195e385","updated":"2019-01-13 08:09:25.000000000","message":"Its correct for OSP10+ but the test is relevant to latest versions too.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"aeb291c0ecafe4f67f8ad9d70bf60f614eb8652d","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":722,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":723,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":724,"context_line":"        network_kwargs[\u0027port_security_enabled\u0027] \u003d ("},{"line_number":725,"context_line":"            port_security_enabled or CONF.network_feature_enabled.port_security"},{"line_number":726,"context_line":"        )"},{"line_number":727,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":728,"context_line":"        result \u003d networks_client.create_network(**network_kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_96c3c0ec","line":725,"range":{"start_line":724,"start_character":0,"end_line":725,"end_character":79},"updated":"2017-02-07 13:57:13.000000000","message":"Hi Eran,\n\nWhen we spoke about this \u0027or\u0027 statement, I was under the impression that the function signature is going to change in a way that port_security_enabled\u003dNone (instead of True).\n\n\nI see it was not change and thus the statement will not work as expected. In case port_security_enabled\u003dFalse it will just read the default value in CONF.network_feature_enabled.port_security\n\n\nThe intention here was to address port_security_enabled first, in case it is True/False , otherwise (if it None) fetch the value in CONF.network_feature_enabled.port_security\n\n\nTo achieve that logic:\n\n\nnetwork_kwargs[\u0027port_security_enabled\u0027] \u003d (\n    port_security_enabled if port_security_enabled is not None\n    else CONF.network_feature_enabled.port_security\n)","commit_id":"04df4accacec07f18f45ed8d71b05924c59b4149"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"53d6a6ff37aef44fc04c4826ab1a928ded53c11d","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":722,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":723,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":724,"context_line":"        network_kwargs[\u0027port_security_enabled\u0027] \u003d ("},{"line_number":725,"context_line":"            port_security_enabled or CONF.network_feature_enabled.port_security"},{"line_number":726,"context_line":"        )"},{"line_number":727,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":728,"context_line":"        result \u003d networks_client.create_network(**network_kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_7d10714f","line":725,"range":{"start_line":724,"start_character":0,"end_line":725,"end_character":79},"in_reply_to":"1a430d35_96c3c0ec","updated":"2017-02-19 13:20:24.000000000","message":"Done","commit_id":"04df4accacec07f18f45ed8d71b05924c59b4149"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"9acca2d2df81bf1cf107d7e0c5174d88de94e2ad","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":157,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":158,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":159,"context_line":"        server \u003d self.network, self.port_id"},{"line_number":160,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":161,"context_line":"        if port_id is not None:"},{"line_number":162,"context_line":"            network[\u0027port\u0027] \u003d port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_df54c422","line":159,"updated":"2017-01-26 19:37:15.000000000","message":"Why do you assign a (network, port_id) tuple to a server?","commit_id":"96d6356066c2a0475ec4f8f83cdf98c1b2e8fdc5"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"ffae038bcb7fdb73b0d2de426adbe99b43364592","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":157,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":158,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":159,"context_line":"        server \u003d self.network, self.port_id"},{"line_number":160,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":161,"context_line":"        if port_id is not None:"},{"line_number":162,"context_line":"            network[\u0027port\u0027] \u003d port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_91ce6c2c","line":159,"in_reply_to":"3a461143_df54c422","updated":"2017-01-29 07:56:40.000000000","message":"agree","commit_id":"96d6356066c2a0475ec4f8f83cdf98c1b2e8fdc5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def _setup_network_and_servers(self, **kwargs):"},{"line_number":106,"context_line":"        boot_with_port \u003d kwargs.pop(\u0027boot_with_port\u0027, False)"},{"line_number":107,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":108,"context_line":"        kwargs.setdefault(\u0027port_security_enabled\u0027, True)"},{"line_number":109,"context_line":"        self.create_sec_group \u003d kwargs[\u0027port_security_enabled\u0027]"},{"line_number":110,"context_line":"        self.network, self.subnet, self.router \u003d self.create_networks(**kwargs)"},{"line_number":111,"context_line":"        self.check_networks()"},{"line_number":112,"context_line":"        self.security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_31349fdc","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":63},"updated":"2017-01-31 09:44:05.000000000","message":"we can do something-\n\nrequest_sec_group \u003d kwargs.get(\u0027port_security_enabled\u0027, True)","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def _setup_network_and_servers(self, **kwargs):"},{"line_number":106,"context_line":"        boot_with_port \u003d kwargs.pop(\u0027boot_with_port\u0027, False)"},{"line_number":107,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":108,"context_line":"        kwargs.setdefault(\u0027port_security_enabled\u0027, True)"},{"line_number":109,"context_line":"        self.create_sec_group \u003d kwargs[\u0027port_security_enabled\u0027]"},{"line_number":110,"context_line":"        self.network, self.subnet, self.router \u003d self.create_networks(**kwargs)"},{"line_number":111,"context_line":"        self.check_networks()"},{"line_number":112,"context_line":"        self.security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_942c619a","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":63},"in_reply_to":"3a461143_31349fdc","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":108,"context_line":"        kwargs.setdefault(\u0027port_security_enabled\u0027, True)"},{"line_number":109,"context_line":"        self.create_sec_group \u003d kwargs[\u0027port_security_enabled\u0027]"},{"line_number":110,"context_line":"        self.network, self.subnet, self.router \u003d self.create_networks(**kwargs)"},{"line_number":111,"context_line":"        self.check_networks()"},{"line_number":112,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":113,"context_line":"        self.ports \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b156cf03","line":110,"range":{"start_line":110,"start_character":72,"end_line":110,"end_character":78},"updated":"2017-01-31 09:44:05.000000000","message":"kwargs will have the \u0027port_security_enabled\u0027 with whatever is being passed and so network get created accordingly.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":108,"context_line":"        kwargs.setdefault(\u0027port_security_enabled\u0027, True)"},{"line_number":109,"context_line":"        self.create_sec_group \u003d kwargs[\u0027port_security_enabled\u0027]"},{"line_number":110,"context_line":"        self.network, self.subnet, self.router \u003d self.create_networks(**kwargs)"},{"line_number":111,"context_line":"        self.check_networks()"},{"line_number":112,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":113,"context_line":"        self.ports \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_e5117105","line":110,"range":{"start_line":110,"start_character":72,"end_line":110,"end_character":78},"in_reply_to":"3a461143_b156cf03","updated":"2019-01-13 08:09:25.000000000","message":"what do you want me to do  ?","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.create_sec_group \u003d kwargs[\u0027port_security_enabled\u0027]"},{"line_number":110,"context_line":"        self.network, self.subnet, self.router \u003d self.create_networks(**kwargs)"},{"line_number":111,"context_line":"        self.check_networks()"},{"line_number":112,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":113,"context_line":"        self.ports \u003d []"},{"line_number":114,"context_line":"        self.port_id \u003d None"},{"line_number":115,"context_line":"        if boot_with_port:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_11408333","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":59},"updated":"2017-01-31 09:44:05.000000000","message":"why we need this, seems like done @L107","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.create_sec_group \u003d kwargs[\u0027port_security_enabled\u0027]"},{"line_number":110,"context_line":"        self.network, self.subnet, self.router \u003d self.create_networks(**kwargs)"},{"line_number":111,"context_line":"        self.check_networks()"},{"line_number":112,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":113,"context_line":"        self.ports \u003d []"},{"line_number":114,"context_line":"        self.port_id \u003d None"},{"line_number":115,"context_line":"        if boot_with_port:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_f4d12524","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":59},"in_reply_to":"3a461143_11408333","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.ports.append({\u0027port\u0027: self.port_id})"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        server \u003d self._create_server(self.network, self.port_id,"},{"line_number":121,"context_line":"                                     self.create_sec_group)"},{"line_number":122,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b16defcd","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":58},"updated":"2017-01-31 09:44:05.000000000","message":"this can be just local variable no need to set as instance var.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.ports.append({\u0027port\u0027: self.port_id})"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        server \u003d self._create_server(self.network, self.port_id,"},{"line_number":121,"context_line":"                                     self.create_sec_group)"},{"line_number":122,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_34ad6d88","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":58},"in_reply_to":"3a461143_b16defcd","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.assertIn(self.router[\u0027id\u0027],"},{"line_number":153,"context_line":"                          seen_router_ids)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _create_server(self, network, port_id\u003dNone, create_sec_group\u003dTrue):"},{"line_number":156,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":157,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":158,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_1167a3e9","line":155,"range":{"start_line":155,"start_character":52,"end_line":155,"end_character":68},"updated":"2017-01-31 09:44:05.000000000","message":"request_sec_group","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.assertIn(self.router[\u0027id\u0027],"},{"line_number":153,"context_line":"                          seen_router_ids)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _create_server(self, network, port_id\u003dNone, create_sec_group\u003dTrue):"},{"line_number":156,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":157,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":158,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d4b269e4","line":155,"range":{"start_line":155,"start_character":52,"end_line":155,"end_character":68},"in_reply_to":"3a461143_1167a3e9","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def _create_server(self, network, port_id\u003dNone, create_sec_group\u003dTrue):"},{"line_number":156,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":157,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":158,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":159,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":160,"context_line":"        if port_id is not None:"},{"line_number":161,"context_line":"            network[\u0027port\u0027] \u003d port_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_515dab13","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":65},"updated":"2017-01-31 09:44:05.000000000","message":"security_groups \u003d []\nif request_sec_group:\n    security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]\n\ntempest will request nova to create sever with network(with port_security_enabled\u003dFalse) and security_groups\u003d[].\n\nRequesting server without security_groups or with security_groups\u003d[] is same thing on nova side which means ask neutron about \u0027default\u0027 security_groups.\n\nNow neutron should allow all port access with that as requested network is created with port_security_enabled\u003dFalse.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def _create_server(self, network, port_id\u003dNone, create_sec_group\u003dTrue):"},{"line_number":156,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":157,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":158,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":159,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":160,"context_line":"        if port_id is not None:"},{"line_number":161,"context_line":"            network[\u0027port\u0027] \u003d port_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_5444b9b5","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":65},"in_reply_to":"3a461143_515dab13","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":160,"context_line":"        if port_id is not None:"},{"line_number":161,"context_line":"            network[\u0027port\u0027] \u003d port_id"},{"line_number":162,"context_line":"        if not create_sec_group:"},{"line_number":163,"context_line":"            server \u003d self.create_server("},{"line_number":164,"context_line":"                networks\u003d[network],"},{"line_number":165,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":166,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            server \u003d self.create_server("},{"line_number":169,"context_line":"                networks\u003d[network],"},{"line_number":170,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":171,"context_line":"                security_groups\u003dsecurity_groups,"},{"line_number":172,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":173,"context_line":"        self.servers.append(server)"},{"line_number":174,"context_line":"        return server"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b1a40f08","line":172,"range":{"start_line":162,"start_character":0,"end_line":172,"end_character":36},"updated":"2017-01-31 09:44:05.000000000","message":"this can be kept same as original code after above comment @L158.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":160,"context_line":"        if port_id is not None:"},{"line_number":161,"context_line":"            network[\u0027port\u0027] \u003d port_id"},{"line_number":162,"context_line":"        if not create_sec_group:"},{"line_number":163,"context_line":"            server \u003d self.create_server("},{"line_number":164,"context_line":"                networks\u003d[network],"},{"line_number":165,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":166,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            server \u003d self.create_server("},{"line_number":169,"context_line":"                networks\u003d[network],"},{"line_number":170,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":171,"context_line":"                security_groups\u003dsecurity_groups,"},{"line_number":172,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":173,"context_line":"        self.servers.append(server)"},{"line_number":174,"context_line":"        return server"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b4595d90","line":172,"range":{"start_line":162,"start_character":0,"end_line":172,"end_character":36},"in_reply_to":"3a461143_b1a40f08","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    @test.idempotent_id(\u0027bc330276-d4bf-4775-9c97-812fb327659b\u0027)"},{"line_number":846,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":847,"context_line":"    def test_port_security_false(self):"},{"line_number":848,"context_line":"        \"\"\"Tests port_security_enabled-false"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        Neutron security groups always enforcne traffic."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_31b9ff2e","line":847,"range":{"start_line":847,"start_character":8,"end_line":847,"end_character":32},"updated":"2017-01-31 09:44:05.000000000","message":"how about something like-  test_connectivity_with_port_security_enabled_false","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    @test.idempotent_id(\u0027bc330276-d4bf-4775-9c97-812fb327659b\u0027)"},{"line_number":846,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":847,"context_line":"    def test_port_security_false(self):"},{"line_number":848,"context_line":"        \"\"\"Tests port_security_enabled-false"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        Neutron security groups always enforcne traffic."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_94f4615b","line":847,"range":{"start_line":847,"start_character":8,"end_line":847,"end_character":32},"in_reply_to":"3a461143_31b9ff2e","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d91cdfff39c378745edc9fd6f74f73347cc1668f","unresolved":false,"context_lines":[{"line_number":847,"context_line":"    def test_port_security_false(self):"},{"line_number":848,"context_line":"        \"\"\"Tests port_security_enabled-false"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        Neutron security groups always enforcne traffic."},{"line_number":851,"context_line":"        when port_security_enabled \u003d false , security"},{"line_number":852,"context_line":"        groups stop enforce traffic."},{"line_number":853,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d170bba6","line":850,"range":{"start_line":850,"start_character":39,"end_line":850,"end_character":47},"updated":"2017-01-31 09:44:20.000000000","message":"enforce","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":847,"context_line":"    def test_port_security_false(self):"},{"line_number":848,"context_line":"        \"\"\"Tests port_security_enabled-false"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        Neutron security groups always enforcne traffic."},{"line_number":851,"context_line":"        when port_security_enabled \u003d false , security"},{"line_number":852,"context_line":"        groups stop enforce traffic."},{"line_number":853,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d4ea6973","line":850,"range":{"start_line":850,"start_character":39,"end_line":850,"end_character":47},"in_reply_to":"3a461143_d170bba6","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d91cdfff39c378745edc9fd6f74f73347cc1668f","unresolved":false,"context_lines":[{"line_number":854,"context_line":"        The test steps are :"},{"line_number":855,"context_line":"        1. Create a new network with port_security \u003d false."},{"line_number":856,"context_line":"        2. Connect (hotplug) the VM to a new network."},{"line_number":857,"context_line":"        3. Check the VM can ping a server on the new network (\"peer\")."},{"line_number":858,"context_line":"        4. Spoof the mac address of the new VM interface."},{"line_number":859,"context_line":"        5. Check the Security Group enforces mac spoofing and allow pings via"},{"line_number":860,"context_line":"           spoofed interface."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d17efb68","line":857,"range":{"start_line":857,"start_character":11,"end_line":857,"end_character":20},"updated":"2017-01-31 09:44:20.000000000","message":"Check (that) the, aren\u0027t you missing something there? ;)","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":854,"context_line":"        The test steps are :"},{"line_number":855,"context_line":"        1. Create a new network with port_security \u003d false."},{"line_number":856,"context_line":"        2. Connect (hotplug) the VM to a new network."},{"line_number":857,"context_line":"        3. Check the VM can ping a server on the new network (\"peer\")."},{"line_number":858,"context_line":"        4. Spoof the mac address of the new VM interface."},{"line_number":859,"context_line":"        5. Check the Security Group enforces mac spoofing and allow pings via"},{"line_number":860,"context_line":"           spoofed interface."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_148871c4","line":857,"range":{"start_line":857,"start_character":11,"end_line":857,"end_character":20},"in_reply_to":"3a461143_d17efb68","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d91cdfff39c378745edc9fd6f74f73347cc1668f","unresolved":false,"context_lines":[{"line_number":856,"context_line":"        2. Connect (hotplug) the VM to a new network."},{"line_number":857,"context_line":"        3. Check the VM can ping a server on the new network (\"peer\")."},{"line_number":858,"context_line":"        4. Spoof the mac address of the new VM interface."},{"line_number":859,"context_line":"        5. Check the Security Group enforces mac spoofing and allow pings via"},{"line_number":860,"context_line":"           spoofed interface."},{"line_number":861,"context_line":"        6. Enable port-security of the spoofed port- set the flag to true."},{"line_number":862,"context_line":"        7. Retest 3rd step and check that the Security Group blocks pings via"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_31901f95","line":859,"range":{"start_line":859,"start_character":11,"end_line":859,"end_character":20},"updated":"2017-01-31 09:44:20.000000000","message":"ditto","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":856,"context_line":"        2. Connect (hotplug) the VM to a new network."},{"line_number":857,"context_line":"        3. Check the VM can ping a server on the new network (\"peer\")."},{"line_number":858,"context_line":"        4. Spoof the mac address of the new VM interface."},{"line_number":859,"context_line":"        5. Check the Security Group enforces mac spoofing and allow pings via"},{"line_number":860,"context_line":"           spoofed interface."},{"line_number":861,"context_line":"        6. Enable port-security of the spoofed port- set the flag to true."},{"line_number":862,"context_line":"        7. Retest 3rd step and check that the Security Group blocks pings via"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b4b5dd7e","line":859,"range":{"start_line":859,"start_character":11,"end_line":859,"end_character":20},"in_reply_to":"3a461143_31901f95","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d91cdfff39c378745edc9fd6f74f73347cc1668f","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        4. Spoof the mac address of the new VM interface."},{"line_number":859,"context_line":"        5. Check the Security Group enforces mac spoofing and allow pings via"},{"line_number":860,"context_line":"           spoofed interface."},{"line_number":861,"context_line":"        6. Enable port-security of the spoofed port- set the flag to true."},{"line_number":862,"context_line":"        7. Retest 3rd step and check that the Security Group blocks pings via"},{"line_number":863,"context_line":"           the spoofed interface."},{"line_number":864,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_91ef131d","line":861,"range":{"start_line":861,"start_character":51,"end_line":861,"end_character":52},"updated":"2017-01-31 09:44:20.000000000","message":".","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        4. Spoof the mac address of the new VM interface."},{"line_number":859,"context_line":"        5. Check the Security Group enforces mac spoofing and allow pings via"},{"line_number":860,"context_line":"           spoofed interface."},{"line_number":861,"context_line":"        6. Enable port-security of the spoofed port- set the flag to true."},{"line_number":862,"context_line":"        7. Retest 3rd step and check that the Security Group blocks pings via"},{"line_number":863,"context_line":"           the spoofed interface."},{"line_number":864,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_f4b3e595","line":861,"range":{"start_line":861,"start_character":51,"end_line":861,"end_character":52},"in_reply_to":"3a461143_91ef131d","updated":"2019-01-13 08:09:25.000000000","message":"Done","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"24e06239289939ba927f59c1e36376d8ea51dc6e","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        fip, server \u003d self.floating_ip_tuple"},{"line_number":873,"context_line":"        new_ports \u003d self._list_ports(device_id\u003dserver[\"id\"],"},{"line_number":874,"context_line":"                                     network_id\u003dself.new_net[\"id\"])"},{"line_number":875,"context_line":"        spoof_port \u003d new_ports[0]"},{"line_number":876,"context_line":"        private_key \u003d self._get_server_key(server)"},{"line_number":877,"context_line":"        ssh_client \u003d self.get_remote_client(fip[\u0027floating_ip_address\u0027],"},{"line_number":878,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_71854758","line":875,"range":{"start_line":875,"start_character":8,"end_line":875,"end_character":18},"updated":"2017-01-31 09:44:05.000000000","message":"can we add check here that port[\u0027security_groups\u0027] is all empty here as it requested network with port_security_enabled\u003dFalse.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b8420e2a6a859f236bc399649f34e817af66967d","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        fip, server \u003d self.floating_ip_tuple"},{"line_number":873,"context_line":"        new_ports \u003d self._list_ports(device_id\u003dserver[\"id\"],"},{"line_number":874,"context_line":"                                     network_id\u003dself.new_net[\"id\"])"},{"line_number":875,"context_line":"        spoof_port \u003d new_ports[0]"},{"line_number":876,"context_line":"        private_key \u003d self._get_server_key(server)"},{"line_number":877,"context_line":"        ssh_client \u003d self.get_remote_client(fip[\u0027floating_ip_address\u0027],"},{"line_number":878,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_052afdda","line":875,"range":{"start_line":875,"start_character":8,"end_line":875,"end_character":18},"in_reply_to":"3a461143_71854758","updated":"2019-01-13 08:09:25.000000000","message":"According to changes in line 158  I dont think we need it.","commit_id":"b0f8c45e38b22f61e46069961cd3c0e4cfd61924"}]}