)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"41484a1ce7572df569152d1db83872be886b3b4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Cleanup: Add common \"create keypair\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are many \"create keypair\" methods in scenario tests, their"},{"line_number":10,"context_line":"behaviors are almost same. They create keypairs with random name."},{"line_number":11,"context_line":"This patch adds common \"create keypair\" method and uses it instead"},{"line_number":12,"context_line":"of each implementation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAARn%2F%2F%2B94%3D","line":10,"updated":"2013-08-19 10:16:35.000000000","message":"s/almost same/almost the same ?\ns/with random name/with a random name ?","commit_id":"fcd1ae5855fe5dea8ea9bf3e356afc28d26d5017"}],"tempest/scenario/test_server_basic_ops.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6202f9cc277e50d74a5bb05522e64ec00e5781a9","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def boot_instance(self):"},{"line_number":58,"context_line":"        create_kwargs \u003d {"},{"line_number":59,"context_line":"            \u0027key_name\u0027: self.keypair.id"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        instance \u003d self.create_server(self.compute_client,"},{"line_number":62,"context_line":"                                      create_kwargs\u003dcreate_kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F%2FHs%3D","line":59,"updated":"2013-08-19 09:20:20.000000000","message":"Is there any reason why you don\u0027t use get/set_resource() method?\nShouldn\u0027t we use get/set_resource() methods?","commit_id":"cd53b2b1fbb259c82481563c23e85e66ef454d79"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fbaefe608a11e8b428bdd5a71e19fcc02bf57fe2","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def boot_instance(self):"},{"line_number":58,"context_line":"        create_kwargs \u003d {"},{"line_number":59,"context_line":"            \u0027key_name\u0027: self.keypair.id"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        instance \u003d self.create_server(self.compute_client,"},{"line_number":62,"context_line":"                                      create_kwargs\u003dcreate_kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F%2B%2Fc%3D","line":59,"in_reply_to":"AAAARn%2F%2F%2FHs%3D","updated":"2013-08-19 10:01:37.000000000","message":"In this test case only, the fixed key \u0027keypair\u0027 is used as the argument of get_resource().\nBy moving common create_keypair(), the key name become random with prefix \u0027scenario-keypair-\u0027.\n\nIf we should use get_resource() here, we should specify the fixed name \u0027keypair\u0027 as the argument of create_keypair().\nshould we do that?","commit_id":"cd53b2b1fbb259c82481563c23e85e66ef454d79"}]}
