)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f6c96733a97ae1acd0147626a2d30e3315af284","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        LOG.debug(\"Created server: %s\", server)"},{"line_number":285,"context_line":"        return server"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def login_to_server(self, server_or_ip, username\u003dNone, private_key\u003dNone):"},{"line_number":288,"context_line":"        if isinstance(server_or_ip, basestring):"},{"line_number":289,"context_line":"            ip \u003d server_or_ip"},{"line_number":290,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F5cM%3D","line":287,"updated":"2013-08-20 14:23:11.000000000","message":"I\u0027d rename this in: get_remote_client","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f90524b4af2a473816ae8497ef1c6c82a1bf5ffb","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        LOG.debug(\"Created server: %s\", server)"},{"line_number":285,"context_line":"        return server"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def login_to_server(self, server_or_ip, username\u003dNone, private_key\u003dNone):"},{"line_number":288,"context_line":"        if isinstance(server_or_ip, basestring):"},{"line_number":289,"context_line":"            ip \u003d server_or_ip"},{"line_number":290,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F3hU%3D","line":287,"in_reply_to":"AAAARn%2F%2F5cM%3D","updated":"2013-08-20 23:06:45.000000000","message":"I like get_remote_client(), will change.","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"58a19800f3bd3e1833f31b898e98e2099f80fa86","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if username is None:"},{"line_number":354,"context_line":"            username \u003d self.config.scenario.ssh_user"},{"line_number":355,"context_line":"        if private_key is None:"},{"line_number":356,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":357,"context_line":"        return RemoteClient(ip, username, pkey\u003dprivate_key)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASX%2F%2F9gI%3D","line":356,"updated":"2013-08-23 06:26:30.000000000","message":"I think you should confirm the existence of the keypair.","commit_id":"b3aa9126c6d2ffa8d45564329637c71ce6a8856d"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"2ca3efbc06257e15a2a5446da2e1177a616305c7","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if username is None:"},{"line_number":354,"context_line":"            username \u003d self.config.scenario.ssh_user"},{"line_number":355,"context_line":"        if private_key is None:"},{"line_number":356,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":357,"context_line":"        return RemoteClient(ip, username, pkey\u003dprivate_key)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASX%2F%2F9Xk%3D","line":356,"in_reply_to":"AAAASX%2F%2F9X0%3D","updated":"2013-08-23 06:57:03.000000000","message":"You are right.\nSorry. I am bad.","commit_id":"b3aa9126c6d2ffa8d45564329637c71ce6a8856d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c433c48f80c06063e4e6f12e8545a3f931031d2a","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if username is None:"},{"line_number":354,"context_line":"            username \u003d self.config.scenario.ssh_user"},{"line_number":355,"context_line":"        if private_key is None:"},{"line_number":356,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":357,"context_line":"        return RemoteClient(ip, username, pkey\u003dprivate_key)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASX%2F%2F9X0%3D","line":356,"in_reply_to":"AAAASX%2F%2F9dQ%3D","updated":"2013-08-23 06:55:06.000000000","message":"After reconsidering, I notice we should specify keypair as the argument of RemoteClinet() because of not having password for ssh-login.\n\nso I feel current code is not wrong.","commit_id":"b3aa9126c6d2ffa8d45564329637c71ce6a8856d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aa10a214fbcfb1ef7d904f291ce82e5538e8108b","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if username is None:"},{"line_number":354,"context_line":"            username \u003d self.config.scenario.ssh_user"},{"line_number":355,"context_line":"        if private_key is None:"},{"line_number":356,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":357,"context_line":"        return RemoteClient(ip, username, pkey\u003dprivate_key)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASX%2F%2F9dQ%3D","line":356,"in_reply_to":"AAAASX%2F%2F9gI%3D","updated":"2013-08-23 06:30:45.000000000","message":"You are right, thanks.\nI will fix here.","commit_id":"b3aa9126c6d2ffa8d45564329637c71ce6a8856d"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f6c96733a97ae1acd0147626a2d30e3315af284","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                        sg_rule.id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def ssh_to_server(self):"},{"line_number":165,"context_line":"        self.linux_client \u003d self.login_to_server(self.floating_ip.ip)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def check_partitions(self):"},{"line_number":168,"context_line":"        partitions \u003d self.linux_client.get_partitions()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F5b4%3D","line":165,"updated":"2013-08-20 14:23:11.000000000","message":"accordingly to previous comments this should be changed in: self.get_remote_client","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f90524b4af2a473816ae8497ef1c6c82a1bf5ffb","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                        sg_rule.id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def ssh_to_server(self):"},{"line_number":165,"context_line":"        self.linux_client \u003d self.login_to_server(self.floating_ip.ip)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def check_partitions(self):"},{"line_number":168,"context_line":"        partitions \u003d self.linux_client.get_partitions()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F3g0%3D","line":165,"in_reply_to":"AAAARn%2F%2F5b4%3D","updated":"2013-08-20 23:06:45.000000000","message":"Done","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"}],"tempest/scenario/test_snapshot_pattern.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f6c96733a97ae1acd0147626a2d30e3315af284","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                        sg_rule.id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _ssh_to_server(self, server_or_ip):"},{"line_number":78,"context_line":"        linux_client \u003d self.login_to_server(server_or_ip)"},{"line_number":79,"context_line":"        return linux_client.ssh_client"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _write_timestamp(self, server_or_ip):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F5bs%3D","line":78,"updated":"2013-08-20 14:23:11.000000000","message":"accordingly to previous comments this should be changed in: self.get_remote_client","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f90524b4af2a473816ae8497ef1c6c82a1bf5ffb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                        sg_rule.id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _ssh_to_server(self, server_or_ip):"},{"line_number":78,"context_line":"        linux_client \u003d self.login_to_server(server_or_ip)"},{"line_number":79,"context_line":"        return linux_client.ssh_client"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _write_timestamp(self, server_or_ip):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F3gw%3D","line":78,"in_reply_to":"AAAARn%2F%2F5bs%3D","updated":"2013-08-20 23:06:45.000000000","message":"Done","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f6c96733a97ae1acd0147626a2d30e3315af284","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        sg_rule.id)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _ssh_to_server(self, server_or_ip):"},{"line_number":106,"context_line":"        linux_client \u003d self.login_to_server(server_or_ip)"},{"line_number":107,"context_line":"        return linux_client.ssh_client"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _create_image(self, server):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F5bk%3D","line":106,"updated":"2013-08-20 14:23:11.000000000","message":"accordingly to previous comments this should be changed in: self.get_remote_client","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f90524b4af2a473816ae8497ef1c6c82a1bf5ffb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        sg_rule.id)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _ssh_to_server(self, server_or_ip):"},{"line_number":106,"context_line":"        linux_client \u003d self.login_to_server(server_or_ip)"},{"line_number":107,"context_line":"        return linux_client.ssh_client"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _create_image(self, server):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAARn%2F%2F3gc%3D","line":106,"in_reply_to":"AAAARn%2F%2F5bk%3D","updated":"2013-08-20 23:06:45.000000000","message":"Done","commit_id":"0db29c7ceeb5afa2710082bed68a29674cd8c088"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"773a11f691e166305b8e76e6407f78add1d165b4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self._wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _wait_for_volume_availible_on_the_system(self, server_or_ip):"},{"line_number":173,"context_line":"        ssh \u003d self.login_to_server(server_or_ip)"},{"line_number":174,"context_line":"        conf \u003d self.config"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        def _func():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAARn%2F%2F0wA%3D","line":173,"updated":"2013-08-21 14:12:16.000000000","message":"This looks wrong - where is login_to_server defined?","commit_id":"9341fdef1702594f77131de731bd791a7a03a0c0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9db2615e953f5cc64f3f5c98b6abdeab6ce2e41e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self._wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _wait_for_volume_availible_on_the_system(self, server_or_ip):"},{"line_number":173,"context_line":"        ssh \u003d self.login_to_server(server_or_ip)"},{"line_number":174,"context_line":"        conf \u003d self.config"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        def _func():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAARn%2F%2F0VE%3D","line":173,"in_reply_to":"AAAARn%2F%2F0wA%3D","updated":"2013-08-21 23:47:50.000000000","message":"Nice catch, thanks!\n\nNow this test case is skipping, and Jenkins/I could not notice this:-(","commit_id":"9341fdef1702594f77131de731bd791a7a03a0c0"}]}