)]}'
{"tempest/api/volume/admin/test_volume_types_negative.py":[{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"301d1efda7c5fbb3b5d5e4e4b9311fb2efd5808d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        params \u003d {self.name_field: data_utils.rand_uuid(),"},{"line_number":29,"context_line":"                  \u0027volume_type\u0027: data_utils.rand_uuid()}"},{"line_number":30,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":31,"context_line":"                          self.volumes_client.create_volume, **params)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.idempotent_id(\u0027878b4e57-faa2-4659-b0d1-ce740a06ae81\u0027)"},{"line_number":34,"context_line":"    def test_create_with_empty_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_11017f6a","side":"PARENT","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":59},"updated":"2017-01-30 15:54:55.000000000","message":"Out of curiosity, why is an admin test calling the non-admin client?  Maybe instead of deleting this test we should instead be using the admin_volume_client?","commit_id":"a7b33cf79e08c58a35c3a608ca4ac79d1b5d45cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cf58a76fa439f3f12c4abc4e137d002955a5c0b8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        params \u003d {self.name_field: data_utils.rand_uuid(),"},{"line_number":29,"context_line":"                  \u0027volume_type\u0027: data_utils.rand_uuid()}"},{"line_number":30,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":31,"context_line":"                          self.volumes_client.create_volume, **params)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.idempotent_id(\u0027878b4e57-faa2-4659-b0d1-ce740a06ae81\u0027)"},{"line_number":34,"context_line":"    def test_create_with_empty_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_839b5017","side":"PARENT","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":59},"in_reply_to":"3a461143_11017f6a","updated":"2017-01-31 06:31:32.000000000","message":"It\u0027s not matter if admin or non-admin creates the volume.\nThe test is creating a volume from non existent volume type, the difference between admin and non-admin is only permissions.","commit_id":"a7b33cf79e08c58a35c3a608ca4ac79d1b5d45cf"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"b46692705938e3740f2512fbab9f34dfe715ea27","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        params \u003d {self.name_field: data_utils.rand_uuid(),"},{"line_number":29,"context_line":"                  \u0027volume_type\u0027: data_utils.rand_uuid()}"},{"line_number":30,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":31,"context_line":"                          self.volumes_client.create_volume, **params)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.idempotent_id(\u0027878b4e57-faa2-4659-b0d1-ce740a06ae81\u0027)"},{"line_number":34,"context_line":"    def test_create_with_empty_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_57c02950","side":"PARENT","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":59},"in_reply_to":"3a461143_34dbad1c","updated":"2017-01-31 17:17:17.000000000","message":"This does not really need to be an admin test, and it\u0027s a volume API test (rather than a volume-type one), so I agree this is the one that should be removed.\n\nOn the minus side, this test uses \u0027name_field\u0027 while the volume test uses \u0027display_field\u0027 for both v1 and v2, which is wrong.","commit_id":"a7b33cf79e08c58a35c3a608ca4ac79d1b5d45cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1ac400a427d8356ceefdf7a4dff31c98067f994a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        params \u003d {self.name_field: data_utils.rand_uuid(),"},{"line_number":29,"context_line":"                  \u0027volume_type\u0027: data_utils.rand_uuid()}"},{"line_number":30,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":31,"context_line":"                          self.volumes_client.create_volume, **params)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.idempotent_id(\u0027878b4e57-faa2-4659-b0d1-ce740a06ae81\u0027)"},{"line_number":34,"context_line":"    def test_create_with_empty_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_d9a0b9f6","side":"PARENT","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":59},"in_reply_to":"3a461143_57c02950","updated":"2017-02-01 06:28:48.000000000","message":"@Andrea\nThanks for you comment,\nI\u0027ll create a separate patch to fix the volume test.","commit_id":"a7b33cf79e08c58a35c3a608ca4ac79d1b5d45cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4693e73b631f8b2a4b7deae2b2d73c1ed6581294","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        params \u003d {self.name_field: data_utils.rand_uuid(),"},{"line_number":29,"context_line":"                  \u0027volume_type\u0027: data_utils.rand_uuid()}"},{"line_number":30,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":31,"context_line":"                          self.volumes_client.create_volume, **params)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.idempotent_id(\u0027878b4e57-faa2-4659-b0d1-ce740a06ae81\u0027)"},{"line_number":34,"context_line":"    def test_create_with_empty_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_34dbad1c","side":"PARENT","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":59},"in_reply_to":"3a461143_839b5017","updated":"2017-01-31 10:19:53.000000000","message":"yea, using non admin client here create confusion :). But this tests just check 404 similar to other test. with admin or without does not really matters here.","commit_id":"a7b33cf79e08c58a35c3a608ca4ac79d1b5d45cf"}]}