)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"45fe41fec60a5f91a3fc3221e5c4b6f63087093a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch addresses a unit test that fails after the addition of"},{"line_number":10,"context_line":"[1] in [2]. The patch fails due to asserting that two dictionaries"},{"line_number":11,"context_line":"are equivalent when create_user now adds federated users to calls."},{"line_number":12,"context_line":"create_user will now ALWAYS return a federated key value back."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]:https://specs.openstack.org/openstack/keystone-specs/specs/keystone/ocata/support-federated-attr.html"},{"line_number":15,"context_line":"[2]:https://review.openstack.org/#/c/426449/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_2c66ef50","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":36},"updated":"2017-01-31 19:34:41.000000000","message":"why is this required, can\u0027t we just remove the key for not federated users?","commit_id":"41e2d8974c308446969903e4b86ed90a82b448a1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5072a44dedcc1265097a5880ab7b7d78586b3f56","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch addresses a unit test that fails after the addition of"},{"line_number":10,"context_line":"[1] in [2]. The patch fails due to asserting that two dictionaries"},{"line_number":11,"context_line":"are equivalent when create_user now adds federated users to calls."},{"line_number":12,"context_line":"create_user will now ALWAYS return a federated key value back."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]:https://specs.openstack.org/openstack/keystone-specs/specs/keystone/ocata/support-federated-attr.html"},{"line_number":15,"context_line":"[2]:https://review.openstack.org/#/c/426449/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_be4cb39e","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":36},"in_reply_to":"3a461143_2c66ef50","updated":"2021-06-15 22:31:57.000000000","message":"+1, non federated users should not have this","commit_id":"41e2d8974c308446969903e4b86ed90a82b448a1"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"969d5a55486f72d80ec715a3edd8e9bd24f12320","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses a unit test that fails after the addition of"},{"line_number":10,"context_line":"[1] in [2]. The patch fails due to asserting that two dictionaries"},{"line_number":11,"context_line":"are equivalent when create_user now adds federated users to calls."},{"line_number":12,"context_line":"create_user will now ALWAYS return a federated key value back."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]:https://specs.openstack.org/openstack/keystone-specs/specs/keystone/ocata/support-federated-attr.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_466e9697","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":56},"updated":"2017-02-01 15:03:32.000000000","message":"nit: now returns a federated object attribute for all users. Whereas, list_users does not return this object.","commit_id":"20c7772f33f0a9a082692af2ffbf1b82f820145f"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"93190537aea9017899f8808ab4fc263842a3afc1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses a unit test that fails after the addition of"},{"line_number":10,"context_line":"[1] in [2]. The patch fails due to asserting that two dictionaries"},{"line_number":11,"context_line":"are equivalent when create_user now adds federated users to calls."},{"line_number":12,"context_line":"create_user will now ALWAYS return a federated key value back."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]:https://specs.openstack.org/openstack/keystone-specs/specs/keystone/ocata/support-federated-attr.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_d3ac1a8e","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":56},"in_reply_to":"3a461143_466e9697","updated":"2017-02-15 18:25:05.000000000","message":"Done","commit_id":"20c7772f33f0a9a082692af2ffbf1b82f820145f"}],"tempest/api/identity/admin/v3/test_groups.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"42de787c6ea8f53805453f2b4aeb0ae07bb62600","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_cf0e56e4","line":88,"updated":"2017-01-31 10:41:41.000000000","message":"This need a code comment.","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"511c22134d435962f606135b15e7a065fb9dc4ed","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_ca08042b","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":37},"updated":"2017-01-31 10:57:34.000000000","message":"I may be missing bits here, but this looks like APi response change?","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"419009dad394398f788260a38b455577408a8cdf","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_846b2884","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":37},"in_reply_to":"3a461143_9e8d37d5","updated":"2017-02-01 07:34:52.000000000","message":"This is not changing the API behavior based on a config","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1413feefd2f8fa2409c93bc0faf5c84403fabfac","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_9e8d37d5","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":37},"in_reply_to":"3a461143_b8e69d41","updated":"2017-02-01 06:09:20.000000000","message":"well if API is changing the behavior(at least response dict attributes ) based on config then its bad.\n\nI understand if user is from federated auth then it makes sense to have that attribute in response but not for normal users also.","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"af8f412ca3f41f4a7910abc882f5cc9c2e1d4515","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_b8e69d41","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":37},"in_reply_to":"3a461143_c01e1c0b","updated":"2017-01-31 17:42:22.000000000","message":"As mentioned in the commit message. https://review.openstack.org/#/c/426449/ is affected by this method. create_user is being extended to add associated federated objects with the user. This will cause this test to fail which matches the entire dictionary with group users dictionary rather than asserting the key key/value paires","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"acd80bb39348fd7eb1ebb863d2740ae2127d89f5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_eae940b8","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":37},"in_reply_to":"3a461143_ca08042b","updated":"2017-01-31 11:07:34.000000000","message":"I don\"t think this is a response change. It\u0027s just that depending on the Keystone configuration, the \"federated\" attribut may, or may be not present.","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"1eec1466002b0dd2289e418776de301849d5d304","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_c01e1c0b","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":37},"in_reply_to":"3a461143_eae940b8","updated":"2017-01-31 14:07:12.000000000","message":"This depends upon the type of authentication made. If the user came from a federated auth, the federated attributes will be displayed.\n\nCurrently, there is no scenario in tempest itself that runs a federated authentication, only in keystone tempest plugin: https://github.com/openstack/keystone/blob/master/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py\n\nSo I don\u0027t believe this change is *currently* necessary, it will if, someday, we add a job that runs tempest in a federated environment.","commit_id":"1e17365243828c9986721f40b68ca7ec4d76ceb7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"45fe41fec60a5f91a3fc3221e5c4b6f63087093a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            password \u003d data_utils.rand_password()"},{"line_number":86,"context_line":"            user \u003d self.users_client.create_user(name\u003dname,"},{"line_number":87,"context_line":"                                                 password\u003dpassword)[\u0027user\u0027]"},{"line_number":88,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":89,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":90,"context_line":"            users.append(user)"},{"line_number":91,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_ec1a27c5","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":35},"updated":"2017-01-31 19:34:41.000000000","message":"add a comment as per requested in the previous patchset.","commit_id":"41e2d8974c308446969903e4b86ed90a82b448a1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"09a5956e362b67dd747944f8007be0b8d9b260a4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            # so we remove this attribute to allow an assertEqual of the"},{"line_number":90,"context_line":"            # entire user dict and group_users dict"},{"line_number":91,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":92,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":93,"context_line":"            users.append(user)"},{"line_number":94,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":95,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_7202700d","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":37},"updated":"2017-02-01 13:48:25.000000000","message":"I wonder if we need to assert this field instead of just deleting it?","commit_id":"20c7772f33f0a9a082692af2ffbf1b82f820145f"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"769154be48dfa5f6fbbfc253dcb6a5e6d345e97c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            # so we remove this attribute to allow an assertEqual of the"},{"line_number":90,"context_line":"            # entire user dict and group_users dict"},{"line_number":91,"context_line":"            if \u0027federated\u0027 in user:"},{"line_number":92,"context_line":"                del user[\u0027federated\u0027]"},{"line_number":93,"context_line":"            users.append(user)"},{"line_number":94,"context_line":"            self.addCleanup(self.users_client.delete_user, user[\u0027id\u0027])"},{"line_number":95,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_668f1276","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":37},"in_reply_to":"3a461143_7202700d","updated":"2017-02-01 14:59:05.000000000","message":"The problem is, is won\u0027t be returned for list_users, only for get_user calls.","commit_id":"20c7772f33f0a9a082692af2ffbf1b82f820145f"}]}