)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"605b467d9880ea6ffb17bb575ea58fc7ef9380a1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Only cinder-service return contains \u003chost name\u003e@\u003cdriver name\u003e"},{"line_number":11,"context_line":"Other services host may be hostname only without a driver name."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To prevent host overlapping between services, changed"},{"line_number":14,"context_line":"the selected binary to be cinder-volume."},{"line_number":15,"context_line":"In that case our host will be a full name, there is no need to"},{"line_number":16,"context_line":"send only the hostname because we may get unrelated hosts."},{"line_number":17,"context_line":"IMO it will be better to query host name - the full name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_b4d5af1c","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":40},"updated":"2017-02-01 09:34:16.000000000","message":"yes thats right if we try to check only cinder-volume service but that tests supposed to tests all services are being returned correctly with host filter or not.","commit_id":"b561f133c6ad2200558e3a243a2b591d8aed6b6c"}],"tempest/api/volume/admin/test_volume_services.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"605b467d9880ea6ffb17bb575ea58fc7ef9380a1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # NOTE: Cinder service-list API returns the list for cinder-volume"},{"line_number":35,"context_line":"        # contains \"\u003chost name\u003e@\u003cdriver name\u003e\"."},{"line_number":36,"context_line":"        # other services host name may be \"host_name\" only"},{"line_number":37,"context_line":"        cinder_service \u003d [x for x in cls.services if"},{"line_number":38,"context_line":"                          x[\u0027binary\u0027] \u003d\u003d \u0027cinder-volume\u0027]"},{"line_number":39,"context_line":"        cls.host_name \u003d cinder_service[0][\u0027host\u0027]"},{"line_number":40,"context_line":"        cls.binary_name \u003d cinder_service[0][\u0027binary\u0027]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_54f64b8f","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":57},"updated":"2017-02-01 09:34:16.000000000","message":"This will work with this but by doing this we are changing the original purpose of the tests from testing all services to only tests cinder-volume service.\n\nWhat if cinder break something for other services(cinder-scheduler) in list filter? this tests would not be able to catch that.","commit_id":"b561f133c6ad2200558e3a243a2b591d8aed6b6c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0ec682557e6d27ecb8f35a103438706b9e657df5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # NOTE: Cinder service-list API returns the list for cinder-volume"},{"line_number":35,"context_line":"        # contains \"\u003chost name\u003e@\u003cdriver name\u003e\"."},{"line_number":36,"context_line":"        # other services host name may be \"host_name\" only"},{"line_number":37,"context_line":"        cinder_service \u003d [x for x in cls.services if"},{"line_number":38,"context_line":"                          x[\u0027binary\u0027] \u003d\u003d \u0027cinder-volume\u0027]"},{"line_number":39,"context_line":"        cls.host_name \u003d cinder_service[0][\u0027host\u0027]"},{"line_number":40,"context_line":"        cls.binary_name \u003d cinder_service[0][\u0027binary\u0027]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_07cc97b9","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":57},"in_reply_to":"3a461143_54f64b8f","updated":"2017-02-01 09:51:40.000000000","message":"What do you expect from this example :\nhost\u003dhostgroup\ncinder service-list --host hostgroup\n\n[stack@cougar08 ~]$ cinder service-list\n+------------------+-------------------------+------+---------+-------+----------------------------+-----------------+\n| Binary           | Host                    | Zone | Status  | State | Updated_at                 | Disabled Reason |\n+------------------+-------------------------+------+---------+-------+----------------------------+-----------------+\n| cinder-scheduler | hostgroup               | nova | enabled | up    | 2017-02-01T09:49:21.000000 | -               |\n| cinder-volume    | hostgroup@kaminario_fc  | nova | enabled | up    | 2017-02-01T09:49:22.000000 | -               |\n| cinder-volume    | hostgroup@tripleo_iscsi | nova | enabled | down  | 2017-01-29T05:07:40.000000 | -               |\n+------------------+-------------------------+------+---------+-------+----------------------------+-----------------+","commit_id":"b561f133c6ad2200558e3a243a2b591d8aed6b6c"}]}