)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"6273dc9f74d046dc0e73376db5b976cf0811abcf","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2a2c80a164b9f75d0e7e0503a24194bedfc0e66b"},{"line_number":13,"context_line":"Depends-On: If74dd9d8e7191047b6f1cd7e35b6fc667f004f91"},{"line_number":14,"context_line":"Closes-bug: #1661016"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a1ff146_8b179550","line":14,"updated":"2017-03-15 07:07:13.000000000","message":"IMHO: Related-Bug: instead of Closes-Bug:\n(just a note)","commit_id":"89a6cfc6edca34dbb076b1fd29d148624d268fee"}],"tempest/api/compute/admin/test_volume_swap.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"3fd7fccf2726179ef56a04ac957d78b8501ec1ff","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                       volume1[\u0027id\u0027], \u0027available\u0027)"},{"line_number":65,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":66,"context_line":"                                       volume2[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":67,"context_line":"        self.addCleanup(self.servers_client.detach_volume,"},{"line_number":68,"context_line":"                        server[\u0027id\u0027], volume2[\u0027id\u0027])"},{"line_number":69,"context_line":"        # Verify \"volume2\" is attached to the server"},{"line_number":70,"context_line":"        vol_attachments \u003d self.servers_client.list_volume_attachments("},{"line_number":71,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_3b1b311d","side":"PARENT","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":52},"updated":"2017-02-04 07:30:02.000000000","message":"I think here still need an addCleanup of detaching volume2\n(but should ignore 404 error on detach in case the volume is already detached),\nbecause we can\u0027t assume all test steps would always succeed.","commit_id":"7c0a204533bac1f32419e171211c9480289fb05b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c596714e459c16d88c8646a3364b3954c8a02c1e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # Swap volume from \"volume2\" to \"volume1\""},{"line_number":77,"context_line":"        self.servers_admin_client.update_attached_volume("},{"line_number":78,"context_line":"            server[\u0027id\u0027], volume2[\u0027id\u0027], volumeId\u003dvolume1[\u0027id\u0027])"},{"line_number":79,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":80,"context_line":"                                       volume2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":81,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":82,"context_line":"                                       volume1[\u0027id\u0027], \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_84f5c184","line":79,"updated":"2017-02-10 12:01:12.000000000","message":"@zhufl: because in BaseV2ComputeTest.resource_cleanup() we clear the servers before the volumes, and because deleting a server will switch all the attached volumes to status \"available\": we don\"t need the addCleanup(volume_detach()) call that you suggested in patchset 4.\n\nHowever, it shouldn\u0027t be that tricky, reasoning between class level fixtures and test level fixtures is source of bugs. We should eventually remove all the class methods and use instance methods and addCleanup everywhere instead.","commit_id":"2ae771d7ddedf31b622e22ced74ddd8413e5d26b"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"74c8d085fa361faaad5c5a37303cce4cee4916c8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # Swap volume from \"volume2\" to \"volume1\""},{"line_number":71,"context_line":"        self.admin_servers_client.update_attached_volume("},{"line_number":72,"context_line":"            server[\u0027id\u0027], volume2[\u0027id\u0027], volumeId\u003dvolume1[\u0027id\u0027])"},{"line_number":73,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":74,"context_line":"                                       volume2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":75,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":76,"context_line":"                                       volume1[\u0027id\u0027], \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba2be162_e6e2742e","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":38},"updated":"2017-03-03 14:10:56.000000000","message":"Here should use waiters.wait_for_volume_resource_status(), and wait_for_volume_status is deprecated now.","commit_id":"efb1cc4b167f4f73622155228ac535b4a77b063f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a9947666129efaf93c5b1d9876f600bc41bafde0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                                volume1[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":60,"context_line":"                                                volume2[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":61,"context_line":"        self.addCleanup(self.servers_client.detach_volume,"},{"line_number":62,"context_line":"                        server[\u0027id\u0027], volume2[\u0027id\u0027])"},{"line_number":63,"context_line":"        # Verify \"volume2\" is attached to the server"},{"line_number":64,"context_line":"        vol_attachments \u003d self.servers_client.list_volume_attachments("},{"line_number":65,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_d7ab96d4","side":"PARENT","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":52},"updated":"2017-03-09 06:45:41.000000000","message":"@Jordan,\nTo remove this seems ok when everything is ok, only if server is not deleted successfully(e.g., in ERROR state), then the volumes will be left over.","commit_id":"e08a800d66472d914b069bf79c4bc9c739935b4b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bf8fce66b71df304e81b683feaa78223c0b8a205","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                                volume1[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":60,"context_line":"                                                volume2[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":61,"context_line":"        self.addCleanup(self.servers_client.detach_volume,"},{"line_number":62,"context_line":"                        server[\u0027id\u0027], volume2[\u0027id\u0027])"},{"line_number":63,"context_line":"        # Verify \"volume2\" is attached to the server"},{"line_number":64,"context_line":"        vol_attachments \u003d self.servers_client.list_volume_attachments("},{"line_number":65,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a1ff146_9263121a","side":"PARENT","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":52},"in_reply_to":"9a30ddce_d7ab96d4","updated":"2017-03-16 07:34:23.000000000","message":"yea, then let is fail and we can know the reason of not deleting server. I am ok not to add addCleanup.\n\nClass level fixture should clear everything fine as per current order of deleting server and volumes.","commit_id":"e08a800d66472d914b069bf79c4bc9c739935b4b"}]}