)]}'
{"tempest/api/compute/admin/test_flavors.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"17785dbd28fe2dec4ceda32e59ce58f2b6b37ff3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def search_flavor_by_name(flavor_name, flavors_list):"},{"line_number":26,"context_line":"    for flavor in flavors_list:"},{"line_number":27,"context_line":"        if flavor[\u0027name\u0027] \u003d\u003d flavor_name:"},{"line_number":28,"context_line":"            return flavor"},{"line_number":29,"context_line":"    return None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FlavorsAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_870b5ed5","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":15},"updated":"2017-02-08 12:14:58.000000000","message":"This moves a bit of code around (this could be a one-lines with a list comprehension, but it doesn\u0027t help making the assertion error message any more meaningful.\n\nIt think it would be a much better change to assert if flavor[\u0027name\u0027] is in flavor_names, where names \u003d [f[\u0027name\u0027] for f in flavor_list], which in case of error would produce a much more meaningful message.","commit_id":"76af79b126e4c942a42947cd2aaa0b090db39f34"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fd3bda47fc03b846ef89047cc3eef57201753c25","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def search_flavor_by_name(flavor_name, flavors_list):"},{"line_number":26,"context_line":"    for flavor in flavors_list:"},{"line_number":27,"context_line":"        if flavor[\u0027name\u0027] \u003d\u003d flavor_name:"},{"line_number":28,"context_line":"            return flavor"},{"line_number":29,"context_line":"    return None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FlavorsAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_fd8001f9","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":15},"in_reply_to":"1a430d35_870b5ed5","updated":"2017-02-09 09:51:26.000000000","message":"Yep, that was my first thought too. But the verify_flavor_response_extension demands a flavor so I needed something that returned a flavor, which a list comp doesn\u0027t. But, ok, I\u0027ll do it your way.","commit_id":"76af79b126e4c942a42947cd2aaa0b090db39f34"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4f7858849b98dc41c9c3a398a4f8272b61d485b3","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Check if flavor is present in list"},{"line_number":133,"context_line":"        flavors_list \u003d self.user_client.list_flavors(detail\u003dTrue)[\u0027flavors\u0027]"},{"line_number":134,"context_line":"        self.assertIn(flavor_name, [f[\u0027name\u0027] for f in flavors_list])"},{"line_number":135,"context_line":"        verify_flavor_response_extension("},{"line_number":136,"context_line":"            [f for f in flavors_list if f[\u0027name\u0027] \u003d\u003d flavor_name][0]"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @decorators.idempotent_id(\u0027be6cc18c-7c5d-48c0-ac16-17eaf03c54eb\u0027)"},{"line_number":140,"context_line":"    def test_list_non_public_flavor(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_2fc03b7c","line":137,"range":{"start_line":134,"start_character":0,"end_line":137,"end_character":9},"updated":"2017-02-13 02:04:56.000000000","message":"The verify_flavor_response_extension is really troublesome because it wants \"flavor\" instead of \"flavor_name\", as you mentioned.\nAnd so the list comprehension appears twice in this testcase. I wonder whether the alternative way will look a bit simpler?\n        flavor \u003d [f for f in flavors_list if f[\u0027name\u0027] \u003d\u003d flavor_name]\n        self.assertNotEmpty(flavor)\n        verify_flavor_response_extension(flavor[0])","commit_id":"0a5b14538db6b58205b30f3d5404540aa6854c66"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b831dbcd19f68a2b3f949a0884c5b82d54575c82","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Check if flavor is present in list"},{"line_number":133,"context_line":"        flavors_list \u003d self.user_client.list_flavors(detail\u003dTrue)[\u0027flavors\u0027]"},{"line_number":134,"context_line":"        self.assertIn(flavor_name, [f[\u0027name\u0027] for f in flavors_list])"},{"line_number":135,"context_line":"        verify_flavor_response_extension("},{"line_number":136,"context_line":"            [f for f in flavors_list if f[\u0027name\u0027] \u003d\u003d flavor_name][0]"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @decorators.idempotent_id(\u0027be6cc18c-7c5d-48c0-ac16-17eaf03c54eb\u0027)"},{"line_number":140,"context_line":"    def test_list_non_public_flavor(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_a4b197e3","line":137,"range":{"start_line":134,"start_character":0,"end_line":137,"end_character":9},"in_reply_to":"fa31d9ce_2fc03b7c","updated":"2017-02-13 13:55:48.000000000","message":"Sure, good idea, will do.","commit_id":"0a5b14538db6b58205b30f3d5404540aa6854c66"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"a595f9992119d6e1bb16b60ca941f6587a1d2610","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        def _test_string_variations(variations, flavor_name):"},{"line_number":207,"context_line":"            for string in variations:"},{"line_number":208,"context_line":"                params \u003d {\u0027is_public\u0027: string}"},{"line_number":209,"context_line":"                flavors \u003d (self.client.list_flavors(detail\u003dTrue, **params)"},{"line_number":210,"context_line":"                           [\u0027flavors\u0027])"},{"line_number":211,"context_line":"                self.assertIn(flavor_name, [f[\u0027name\u0027] for f in flavors])"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_433bb5eb","line":209,"range":{"start_line":209,"start_character":16,"end_line":209,"end_character":24},"updated":"2017-02-10 16:10:15.000000000","message":"nit for consistency sed \u0027s/flavors/flavors_list/g\u0027","commit_id":"0a5b14538db6b58205b30f3d5404540aa6854c66"}]}