)]}'
{"releasenotes/notes/add-quota-sets-detail-kwarg-74b72183295b3ce7.yaml":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4451abbed5d0d922ed9c1206065c6606d2499d76","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Interface show_quota_set of compute quotas_client has been extended to"},{"line_number":5,"context_line":"    accept kwargs."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a30ddce_52d36f38","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":18},"updated":"2017-03-07 22:19:18.000000000","message":"I think it\u0027s more than that. It supports now /detail as well.","commit_id":"4ad37da29ac8d4a4d0251af9ab3ead528bea27bc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5277796fb4caa1b2f2fa3b6524c8a5e2b26361c2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Interface show_quota_set of compute quotas_client has been extended to include the"},{"line_number":5,"context_line":"    argument \"detail\", which allows for detailed quota set information for a project to be"},{"line_number":6,"context_line":"    retrieved, if set to True. It has also been exteneded to accept kwargs."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a30ddce_d173a6e5","line":6,"range":{"start_line":6,"start_character":48,"end_line":6,"end_character":57},"updated":"2017-03-09 06:09:24.000000000","message":"extended","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3b7097bace1232ca4400caac479b561d107410fc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Interface show_quota_set of compute quotas_client has been extended to include the"},{"line_number":5,"context_line":"    argument \"detail\", which allows for detailed quota set information for a project to be"},{"line_number":6,"context_line":"    retrieved, if set to True. It has also been exteneded to accept kwargs."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a30ddce_6e3710ff","line":6,"range":{"start_line":6,"start_character":48,"end_line":6,"end_character":57},"in_reply_to":"9a30ddce_d173a6e5","updated":"2017-03-12 16:11:25.000000000","message":"Done","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"}],"tempest/lib/services/compute/quotas_client.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"150c73e4db7ba23bd9034f77788dc326864070be","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \"\"\"List the quota set for a tenant.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"},{"line_number":29,"context_line":"        if detail:"},{"line_number":30,"context_line":"            url +\u003d \u0027/detail\u0027"},{"line_number":31,"context_line":"        if user_id:"},{"line_number":32,"context_line":"            url +\u003d \u0027?user_id\u003d%s\u0027 % user_id"},{"line_number":33,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_65cdae84","line":30,"range":{"start_line":29,"start_character":8,"end_line":30,"end_character":28},"updated":"2017-02-07 18:18:59.000000000","message":"/details refers to api https://developer.openstack.org/api-ref/compute/?expanded\u003dshow-the-detail-of-quota-detail#show-the-detail-of-quota\n\nHence need a new method on tempest library (See method show_default_quota_set as reference).","commit_id":"8e2a8d5fe8abdb8e7263c347d042181be13abef7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0a1b6063ac8e5dc33e9601492b4b7744587b2f6b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.validate_response(schema.get_quota_set, resp, body)"},{"line_number":43,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def show_quota_set_details(self, tenant_id, user_id\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"List the details of a quota set for a tenant and/or user.\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        url \u003d \u0027os-quota-sets/%s/detail\u0027 % tenant_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_e4dee50f","line":45,"updated":"2017-02-08 10:49:21.000000000","message":"I am really sorry but I disagree with Luz here, your patchset 1 was better (but do add the unit tests). Merge this with show_quota_set(), add a detail arg. (as PS1).\n\nBut there should be one extra param called param. Something this:\n\n    def list_snapshots(self, detail\u003dFalse, params\u003dNone):\n        url \u003d \u0027os-snapshots\u0027\n\n        if detail:\n            url +\u003d \u0027/detail\u0027\n        if params:\n            url +\u003d \u0027?%s\u0027 % urllib.urlencode(params)\n        resp, body \u003d self.get(url)\n        body \u003d json.loads(body)\n        self.validate_response(schema.list_snapshots, resp, body)\n        return rest_client.ResponseBody(resp, body)\n\n\nLuz, your point is valid, but for consistency (grep for \u0027/detail\u0027 in Tempest source code), we don\"t do it your way.","commit_id":"0ac0d3539f0ca27332a893eb2e5cb7ab39bd4e31"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"619504157eadd35b015404f81e8c1b73bfc89f7b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, detail\u003dFalse, **params):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_2dfafabd","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":64},"updated":"2017-02-21 22:05:02.000000000","message":"This is backward incompatible change as user_id cannot be accepted as arg anymore.","commit_id":"b29eafe31dc3fe1de72e8456fd756e77195d5414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11a56f5935f63be8e5f919ae3153ac03cf14a9fb","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, detail\u003dFalse, **params):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_c1104604","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":64},"in_reply_to":"da36d5c6_2dfafabd","updated":"2017-02-22 03:53:23.000000000","message":"So what we should be doing here is keep taking user_id as it is it was before with same default value and add **kwargs support.","commit_id":"b29eafe31dc3fe1de72e8456fd756e77195d5414"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0b26e4550321e0b6790702d4ebecd872eb9d12c1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, detail\u003dFalse, **params):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_4c4c629e","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":64},"in_reply_to":"da36d5c6_c1104604","updated":"2017-02-23 00:31:07.000000000","message":"Done","commit_id":"b29eafe31dc3fe1de72e8456fd756e77195d5414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"619504157eadd35b015404f81e8c1b73bfc89f7b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, detail\u003dFalse, **params):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"},{"line_number":30,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_e373c913","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":46},"updated":"2017-02-21 22:05:02.000000000","message":"please add a api-ref link here to understand the all accepted kwargs\n\n        For a full list of available parameters, please refer to the official\n        API reference:\n        https://developer.openstack.org/api-ref/compute/#show-the-detail-of-quota\n        \"\"\"","commit_id":"b29eafe31dc3fe1de72e8456fd756e77195d5414"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0b26e4550321e0b6790702d4ebecd872eb9d12c1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, detail\u003dFalse, **params):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"},{"line_number":30,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_6c512636","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":46},"in_reply_to":"fa31d9ce_e373c913","updated":"2017-02-23 00:31:07.000000000","message":"Done","commit_id":"b29eafe31dc3fe1de72e8456fd756e77195d5414"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4451abbed5d0d922ed9c1206065c6606d2499d76","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":30,"context_line":"        API reference:"},{"line_number":31,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html/"},{"line_number":32,"context_line":"        #show-the-detail-of-quota-detail"},{"line_number":33,"context_line":"        \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_920fa7e0","line":32,"range":{"start_line":31,"start_character":8,"end_line":32,"end_character":40},"updated":"2017-03-07 22:19:18.000000000","message":"I think the correct URL is https://developer.openstack.org/api-ref/compute/#show-the-detail-of-quota","commit_id":"4ad37da29ac8d4a4d0251af9ab3ead528bea27bc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41d43f1d3f8b63f7a2db107f964aa0afdc2fdc8f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":30,"context_line":"        API reference:"},{"line_number":31,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html/"},{"line_number":32,"context_line":"        #show-the-detail-of-quota"},{"line_number":33,"context_line":"        \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_ce308eeb","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"updated":"2017-03-08 06:13:18.000000000","message":"also make it in single line like others.","commit_id":"0e0fe32fc131c36adb41bf476d7c34851b3afb95"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5277796fb4caa1b2f2fa3b6524c8a5e2b26361c2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, user_id\u003dNone, detail\u003dFalse, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_ecba9122","line":26,"range":{"start_line":26,"start_character":68,"end_line":26,"end_character":76},"updated":"2017-03-09 06:09:24.000000000","message":"I don\u0027t get why kwargs is needed here?\nIt seems no other args is available besides tenant_id and user_id in this interface","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3b7097bace1232ca4400caac479b561d107410fc","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, user_id\u003dNone, detail\u003dFalse, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_ee2300bb","line":26,"range":{"start_line":26,"start_character":68,"end_line":26,"end_character":76},"in_reply_to":"9a30ddce_b7a359ff","updated":"2017-03-12 16:11:25.000000000","message":"On second thought, I decided to keep this here because it\u0027s explicitly been added to the release notes by core reviewers, so I\u0027m assuming there must be a reason it\u0027s there -- perhaps backwards compatibility?","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f77139b42e55c0cb4621aabc1ddbca36b8a5c5cd","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, user_id\u003dNone, detail\u003dFalse, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_b7a359ff","line":26,"range":{"start_line":26,"start_character":68,"end_line":26,"end_character":76},"in_reply_to":"9a30ddce_ecba9122","updated":"2017-03-09 22:51:57.000000000","message":"I think you\u0027re correct. Grepping for similar occurrences in Tempest, I see **kwargs/**params reserved for list, to specify things like fields. However, for show, I can\u0027t find anywhere else where **kwargs is used, when all other kwargs have already been specified.","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5277796fb4caa1b2f2fa3b6524c8a5e2b26361c2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":30,"context_line":"        API reference:"},{"line_number":31,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html/#show-the-detail-of-quota"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_2c758997","line":30,"updated":"2017-03-09 06:09:24.000000000","message":"maybe this can also be put here\nhttps://developer.openstack.org/api-ref/compute//#show-a-quota","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3b7097bace1232ca4400caac479b561d107410fc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":30,"context_line":"        API reference:"},{"line_number":31,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html/#show-the-detail-of-quota"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_8e3a84e5","line":30,"in_reply_to":"9a30ddce_2c758997","updated":"2017-03-12 16:11:25.000000000","message":"Done","commit_id":"31870213c30a0816c14207075018dd1eea0bc8ff"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"759444954043720d3874aa11dcf2f6924225f19e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class QuotasClient(base_compute_client.BaseComputeClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def show_quota_set(self, tenant_id, user_id\u003dNone, detail\u003dFalse, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"List the quota set for a tenant."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a30ddce_dff6e48d","line":26,"range":{"start_line":26,"start_character":68,"end_line":26,"end_character":76},"updated":"2017-03-13 01:43:40.000000000","message":"sorry for doubting about this.\nIn patch 5 you removed \"user_id\u003dNone\" and added \"detail\u003dFalse, **kwargs\"(you may want to put user_id in kwargs), \nand gmann said you shouldn\u0027t remove \"user_id\" for keeping the backword compatility(I agree with this),\nthen, you added \"user_id\u003dNone\" back, but didn\u0027t delete \"**kwargs\".\nSo, I don\u0027t see the \"special reason\" for adding kwargs, it seems just forget to remove it:)","commit_id":"37205454a87168a3857aebd3903507ef844e7ac5"}]}