)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"aff664ed14ee5beb938c0a0ee94ff0616a5f827c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"but need not be saved in the same manner. This patch changes"},{"line_number":11,"context_line":"the tempest tests for the fix in [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]:http://logs.openstack.org/70/427670/8/check/gate-tempest-dsvm-neutron-dvr-ubuntu-xenial/dce07bd/console.html#_2017-02-08_14_13_25_228905"},{"line_number":14,"context_line":"Change-Id: I86ae394a0d5d31f00efa934ffa7c98b65c58e8e2"},{"line_number":15,"context_line":"Related-Bug: #1582500"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a30ddce_d8a29ead","line":13,"updated":"2017-03-10 15:17:48.000000000","message":"This log will eventually go away.  I would recommend putting any important info into the bug, which should always be there.","commit_id":"60e9b9e0cd7af77897b023e4a52530d3d2433c56"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4b3195af19722f5a204cd8eeb4575df8a48bea5a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"but need not be saved in the same manner. This patch changes"},{"line_number":11,"context_line":"the tempest tests for the fix in [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]:http://logs.openstack.org/70/427670/8/check/gate-tempest-dsvm-neutron-dvr-ubuntu-xenial/dce07bd/console.html#_2017-02-08_14_13_25_228905"},{"line_number":14,"context_line":"Change-Id: I86ae394a0d5d31f00efa934ffa7c98b65c58e8e2"},{"line_number":15,"context_line":"Related-Bug: #1582500"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a30ddce_e975baca","line":13,"in_reply_to":"9a30ddce_d8a29ead","updated":"2017-03-12 19:55:44.000000000","message":"I have moved the logs to a paste link and added it here.","commit_id":"60e9b9e0cd7af77897b023e4a52530d3d2433c56"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"22a0c484db53630d9fa1836b50fdc1d2ca7b0303","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change Tempest tests for duplicated IPv6 values"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ICMP in IPv6 can be defined in multiple ways by the user"},{"line_number":10,"context_line":"but need not be saved in the same manner. This patch changes"},{"line_number":11,"context_line":"the tempest tests for the fix in [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]:http://paste.openstack.org/show/602433/"},{"line_number":14,"context_line":"Change-Id: I86ae394a0d5d31f00efa934ffa7c98b65c58e8e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1a1ced50_10593735","line":11,"range":{"start_line":10,"start_character":42,"end_line":11,"end_character":37},"updated":"2017-03-23 13:22:18.000000000","message":"What is the fix in [1]? That paste includes a stacktrace, not a fix?","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0ddaa70fbad43a07a1a264ac53c7dd9e3b590971","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change Tempest tests for duplicated IPv6 values"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ICMP in IPv6 can be defined in multiple ways by the user"},{"line_number":10,"context_line":"but need not be saved in the same manner. This patch changes"},{"line_number":11,"context_line":"the tempest tests for the fix in [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]:http://paste.openstack.org/show/602433/"},{"line_number":14,"context_line":"Change-Id: I86ae394a0d5d31f00efa934ffa7c98b65c58e8e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ffe62b97_c3b3b697","line":11,"range":{"start_line":10,"start_character":42,"end_line":11,"end_character":37},"in_reply_to":"1a1ced50_10593735","updated":"2017-03-28 06:47:53.000000000","message":"+1","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"190b32413e9434161e403cd63c02a8fc15b709be","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ICMP in IPv6 can be defined in multiple ways by the user."},{"line_number":10,"context_line":"This patch increases the coverage of the test cases by testing"},{"line_number":11,"context_line":"across different combinations of ICMP IPv6 test cases."},{"line_number":12,"context_line":"This inturn improves the test which would be required for testing"},{"line_number":13,"context_line":"the neutron fix in [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]: https://review.openstack.org/#/c/427670"},{"line_number":16,"context_line":"Change-Id: I86ae394a0d5d31f00efa934ffa7c98b65c58e8e2"},{"line_number":17,"context_line":"Related-Bug: #1582500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f79a3b5_9c1cbe78","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":44},"updated":"2018-08-15 23:26:14.000000000","message":"Does this mean we should contain\n\n Depends-on: https://review.openstack.org/#/c/427670\n\nin the commit message?","commit_id":"b91bdbf52eeadef9779cd2832d93defa9747f7ea"}],"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3e6ee995d389c2719d39eb3c380361f8d0658d81","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":176,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":177,"context_line":"        protocol \u003d \u0027ipv6-icmp\u0027"},{"line_number":178,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (11, None)]"},{"line_number":179,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":180,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_2a41543a","line":177,"range":{"start_line":177,"start_character":19,"end_line":177,"end_character":30},"updated":"2017-02-10 03:10:14.000000000","message":"it would not work for ipv4 as this tests gets executed for both ipv4 and ipv6","commit_id":"e063deea8c48cd80de7caadb652e4737068be9de"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7d906c19b162b8e3efd2e16cc3b420286bddbfc3","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":176,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":177,"context_line":"        protocol \u003d \u0027ipv6-icmp\u0027"},{"line_number":178,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (11, None)]"},{"line_number":179,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":180,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_a5e2d59d","line":177,"range":{"start_line":177,"start_character":19,"end_line":177,"end_character":30},"in_reply_to":"fa31d9ce_2a41543a","updated":"2017-02-10 03:56:22.000000000","message":"Ok, So I can check the ethertype ( if its ipv4, then use icmp, if its ipv6, use ipv6-icmp)","commit_id":"e063deea8c48cd80de7caadb652e4737068be9de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c793a223b1f947be61223a44a3d4b79c429c3582","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SecGroupTest(base.BaseSecGroupTest):"},{"line_number":26,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_cidr"},{"line_number":27,"context_line":"    _protocol \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a1ced50_ee9fee4d","line":27,"updated":"2017-03-20 17:58:59.000000000","message":"nit: _protocols since there is more than one, sorry I didn\u0027t notice that before","commit_id":"518b640beac44e887c1a75f3a795af1a57c58d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e72e4ee726cf2f40f53f732ba8e2fee33bbede0d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # Create rules for each protocol"},{"line_number":119,"context_line":"        protocols \u003d self._protocols"},{"line_number":120,"context_line":"        client \u003d self.security_group_rules_client"},{"line_number":121,"context_line":"        for protocol in protocols:"},{"line_number":122,"context_line":"            rule_create_body \u003d client.create_security_group_rule("},{"line_number":123,"context_line":"                security_group_id\u003dgroup_create_body[\u0027security_group\u0027][\u0027id\u0027],"},{"line_number":124,"context_line":"                protocol\u003dprotocol,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_84cd2433","line":121,"updated":"2017-03-22 13:18:52.000000000","message":"Of course you could have always just changed this to \u0027for protocol in self._protocols:\u0027\n\nDoesn\u0027t change anything just my continued nitpicking :)","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2d87d7e4f2087cc404c2c2380918871a49cb4c4e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # Create rules for each protocol"},{"line_number":119,"context_line":"        protocols \u003d self._protocols"},{"line_number":120,"context_line":"        client \u003d self.security_group_rules_client"},{"line_number":121,"context_line":"        for protocol in protocols:"},{"line_number":122,"context_line":"            rule_create_body \u003d client.create_security_group_rule("},{"line_number":123,"context_line":"                security_group_id\u003dgroup_create_body[\u0027security_group\u0027][\u0027id\u0027],"},{"line_number":124,"context_line":"                protocol\u003dprotocol,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_1f64ffb6","line":121,"in_reply_to":"1a1ced50_84cd2433","updated":"2017-03-23 14:24:59.000000000","message":"I would like to postpone the nit picking for now :D, if its ok with you :)","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"22a0c484db53630d9fa1836b50fdc1d2ca7b0303","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_90c28751","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":62},"updated":"2017-03-23 13:22:18.000000000","message":"If I get this right, by doing this you are enforcing that you can create three different SG rules with ether type IPv6, and protocol \u0027icmp\u0027, \u0027icmpv6\u0027 and \u0027ipv6-icmp\u0027.\nHowever the bug in the commit message say that this should raise a a duplicate exception - while today it doesn\u0027t.\nSo you are enforcing the behaviour that in bug your saying is wrong?","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"686fec51ea5144338986c2fb780f8b1f68f80207","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"ffe62b97_fdc82075","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":62},"in_reply_to":"1a1ced50_90c28751","updated":"2017-03-24 02:47:13.000000000","message":"actually this is more about testing the current API bits. In Current APIs  \u0027icmp\u0027, \u0027icmpv6\u0027 and \u0027ipv6-icmp\u0027 are accepted as IPV6 ethertype and create SG rules.\n\nneutron bug was those protocol make duplicate rule entry in DB which can be fixed by having the single rule for all those protocol and publish the same to users but do not reject the legacy protocol type from request.\n\nneutron should not change their APIs(rejecting \u0027icmp\u0027 and other) so testing with current behavior makes powerful to block any unintentional API change.  \n\nNeutron should support legacy protocol too - https://github.com/openstack/neutron-lib/blob/7eb5190cecef85a327772f229a3c73ded0c3c9e7/neutron_lib/constants.py#L136-L138\n\nThats why i suggested to tests all currently supported protocols.","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"052ae9ad984c3c93ad9b53fe7d9ceafa5a52d94f","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"ffe62b97_af88fa1e","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":62},"in_reply_to":"ffe62b97_fdc82075","updated":"2017-03-24 17:22:16.000000000","message":"+1 to test all available protocols via test_create_show_delete_security_group_rule smoke test.\n\nNot sure about changing it on test_create_security_group_rule_with_icmp_type_code","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ed61cdfadd39240a7aa0d2806c85457a2607d187","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"ffe62b97_243ae833","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":62},"in_reply_to":"ffe62b97_fdc82075","updated":"2017-09-21 03:33:59.000000000","message":"Thanks for the ML gmann,\nas per the information from ODL team and Haleyb, ODL would be converting to icmpv6 intenally , irrespective of if it is the current or the new implementation in Neutron.\nAnd Neutron would keep the rules in ipv6-icmp format.\n\nWhether the duplicates will be ignored or reported back depends on the Neutron patch. But this patch currently increases the depth of testing.","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0ddaa70fbad43a07a1a264ac53c7dd9e3b590971","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"ffe62b97_6354ea21","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":62},"in_reply_to":"ffe62b97_fdc82075","updated":"2017-03-28 06:47:53.000000000","message":"while i agree neutron should accept other variants for compat,\ni don\u0027t think it should keep accepting duplicates.","commit_id":"43fd84b2a9c39f0b79ebe83b053aae5a095b5747"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fe624f082096fdd5701e99a7859f46fdabd95b49","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_f7d69627","line":243,"range":{"start_line":243,"start_character":40,"end_line":243,"end_character":61},"updated":"2017-04-04 05:35:14.000000000","message":"aren\u0027t these expected to produce SecurityGroupRuleExists?","commit_id":"b943f7f7560c83e65f0f2b8c2ae80800adf6dcfd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7b6cfa5df2dc409650199b2d050b16b5d82177c8","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_cf5c1280","line":243,"range":{"start_line":243,"start_character":40,"end_line":243,"end_character":61},"in_reply_to":"dfeb2761_32464c51","updated":"2017-04-04 09:05:29.000000000","message":"I think we should tests the current behavior. Currently neutron except as \u0027icmp\u0027 as protocol and user gets rules(they do not know whether it is duplicate or not).\n\nI replied the main rational of these tests in Tempest in ML, please check. - http://lists.openstack.org/pipermail/openstack-dev/2017-April/114924.html","commit_id":"b943f7f7560c83e65f0f2b8c2ae80800adf6dcfd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4ba7c25be6b77d341869d2e9de8851909317c95e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_32464c51","line":243,"range":{"start_line":243,"start_character":40,"end_line":243,"end_character":61},"in_reply_to":"dfeb2761_b225bcad","updated":"2017-04-04 06:18:30.000000000","message":"i\u0027m not sure if it\u0027s a good idea to have a tempest test case to ensure it\u0027s broken, unless we\u0027ve decided not to fix the bug.","commit_id":"b943f7f7560c83e65f0f2b8c2ae80800adf6dcfd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d0c377eac8d1cd5724336c845a283d6008d1b98c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_b225bcad","line":243,"range":{"start_line":243,"start_character":40,"end_line":243,"end_character":61},"in_reply_to":"dfeb2761_f7d69627","updated":"2017-04-04 06:14:51.000000000","message":"No , not right now...\nOnce neutron patch goes in, then they might report the same( if we put an error message in case of duplicate rules)","commit_id":"b943f7f7560c83e65f0f2b8c2ae80800adf6dcfd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce3a8c27b8673bcc7b814022d471a6128ff07bfb","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"9ff52f3f_041fd86c","line":243,"updated":"2017-04-13 19:18:52.000000000","message":"I think this should change to a single item for IPv6 - \u0027ipv6-icmp\u0027, although the API will accept either or them.  But the proposed changes we have to \"fix\" the API is triggering a failure with this test with a duplicate error - let\u0027s just use one.","commit_id":"2e39659529f93b94fb8ae9cdf0d9a120a4f8436c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"89ae7ffba14295298917e0546a596a9322427c77","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"7ffa3b31_0809e1db","line":243,"in_reply_to":"7ffa3b31_3a074a85","updated":"2017-04-19 06:01:13.000000000","message":"Reedip,\n\ncan you provide a link to the discussion \"on the IRC and other patches\"?","commit_id":"2e39659529f93b94fb8ae9cdf0d9a120a4f8436c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fe0941709725a53cb0f0c8f3de41814b8077d2db","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"7ffa3b31_3a074a85","line":243,"in_reply_to":"9ff52f3f_041fd86c","updated":"2017-04-19 01:38:05.000000000","message":"Hi Brian , \nWe would not be changing the user behavior, so user can still put in either of the IPv6 formats.\nAs discussed on the IRC and other patches, lets not raise a duplicate error, but respond back with the currently existing rule which matches the new rule provided by the user ( IIRC , this was what we discussed finally)","commit_id":"2e39659529f93b94fb8ae9cdf0d9a120a4f8436c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87d0ea0e1947cd17076bcd57dbd2084e43f0a27f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            rule_list \u003d [rule[\u0027id\u0027]"},{"line_number":143,"context_line":"                         for rule in rule_list_body[\u0027security_group_rules\u0027]]"},{"line_number":144,"context_line":"            self.assertIn(rule_create_body[\u0027security_group_rule\u0027][\u0027id\u0027],"},{"line_number":145,"context_line":"                          rule_list)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @decorators.idempotent_id(\u002787dfbcf9-1849-43ea-b1e4-efa3eeae9f71\u0027)"},{"line_number":148,"context_line":"    def test_create_security_group_rule_with_additional_args(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_4a4857cb","line":145,"updated":"2017-09-22 17:04:31.000000000","message":"I\u0027m just talking about putting a client.delete_security_group_rule() here - even the test name has \u0027delete\u0027 in it but it isn\u0027t done :)","commit_id":"3d5cfaa9e7d3b2c91444982fc4cd79268ae6300a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fdd0516d0b5e829fa904aa811ae9c77f4ae26459","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf57530f_ea7a6786","line":243,"updated":"2017-09-20 17:58:20.000000000","message":"So I think I changed my mind after working on other patches in this area, and plan on having all three \"icmp\" values here map to a single value for IPv6.  If that happens then this test will fail since they will be treated as duplicates.  So we will always support the old values.  But in order to not have a duplicate error the tests above would have to delete the rule after each iteration, which it doesn\u0027t do today.","commit_id":"3d5cfaa9e7d3b2c91444982fc4cd79268ae6300a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87d0ea0e1947cd17076bcd57dbd2084e43f0a27f","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_aa046b7c","line":243,"in_reply_to":"9f5c4f37_7ca09da6","updated":"2017-09-22 17:04:31.000000000","message":"I think all three should map to the same value if ethertype is IPv6, since that would make things backwards-compatible from the API.","commit_id":"3d5cfaa9e7d3b2c91444982fc4cd79268ae6300a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ed61cdfadd39240a7aa0d2806c85457a2607d187","unresolved":false,"context_lines":[{"line_number":240,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":241,"context_line":"    _ip_version \u003d 6"},{"line_number":242,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":243,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f5c4f37_7ca09da6","line":243,"in_reply_to":"bf57530f_ea7a6786","updated":"2017-09-21 03:33:59.000000000","message":"All the 3 ICMP values wont match with IPv6 ICMP because ICMP individually would refer to IPv4 ICMP.\nSo , correct me if my understanding is wrong, but icmpv6 and ipv6-icmp would be mapped to a single value.\nAlso, I think we can add a deletion of the SG, but would like to know if it would be worth the effort?","commit_id":"3d5cfaa9e7d3b2c91444982fc4cd79268ae6300a"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"392a32eb20e85a36cbedf32aa547e12fee88d4d9","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SecGroupTest(base.BaseSecGroupTest):"},{"line_number":26,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_cidr"},{"line_number":27,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_13937f51","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":61},"updated":"2018-08-18 05:07:23.000000000","message":"Agreeing with Ken\u0027ichi, seems no usage\nIs there any reason to add this?","commit_id":"b91bdbf52eeadef9779cd2832d93defa9747f7ea"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"190b32413e9434161e403cd63c02a8fc15b709be","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SecGroupTest(base.BaseSecGroupTest):"},{"line_number":26,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_cidr"},{"line_number":27,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_023e08c0","line":26,"updated":"2018-08-15 23:26:14.000000000","message":"Why we should put this _project_network_cidr here?\nI can not find any places where use this _project_network_cidr.","commit_id":"b91bdbf52eeadef9779cd2832d93defa9747f7ea"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"392a32eb20e85a36cbedf32aa547e12fee88d4d9","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class SecGroupIPv6Test(SecGroupTest):"},{"line_number":243,"context_line":"    _ip_version \u003d 6"},{"line_number":244,"context_line":"    _project_network_cidr \u003d CONF.network.project_network_v6_cidr"},{"line_number":245,"context_line":"    _protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027, \u0027ipv6-icmp\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_737c3320","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":64},"updated":"2018-08-18 05:07:23.000000000","message":"Seems no usage","commit_id":"b91bdbf52eeadef9779cd2832d93defa9747f7ea"}]}