)]}'
{"tempest/lib/services/image/v2/namespace_tags_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d6e4f4717eb93ca4de161e69b70b33a55846bbf0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/tags\u0027 % namespace"},{"line_number":118,"context_line":"        resp, _ \u003d self.delete(url)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # NOTE(rosmaita): Bug 1656183 fixed the success response code for"},{"line_number":121,"context_line":"        # this call.  We check the old (incorrect) code first in case this"},{"line_number":122,"context_line":"        # tempest is being run against an old Glance.  The correct code is"},{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_fa8b1966","line":125,"range":{"start_line":120,"start_character":0,"end_line":125,"end_character":15},"updated":"2017-02-13 19:37:17.000000000","message":"According to the alternative patch,\n\n discussed this with my release czar and we decided not to\n backport, so this fix will be in Pike.\n\nthe above means multiple different-versioned OpenStack clouds return different status codes.\n\nTempest is used for Defcore also now for verifying the interoperability of \"OpenStack Powered\" programs. So I think this change makes the value of Tempest less from this interoperability viewpoint.","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9746099d67c4565ae6dd804dde24271b9634382","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/tags\u0027 % namespace"},{"line_number":118,"context_line":"        resp, _ \u003d self.delete(url)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # NOTE(rosmaita): Bug 1656183 fixed the success response code for"},{"line_number":121,"context_line":"        # this call.  We check the old (incorrect) code first in case this"},{"line_number":122,"context_line":"        # tempest is being run against an old Glance.  The correct code is"},{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_57b60c3e","line":125,"range":{"start_line":120,"start_character":0,"end_line":125,"end_character":15},"in_reply_to":"fa31d9ce_24071919","updated":"2017-02-17 08:00:30.000000000","message":"yea as of now it is not used on defcore. But surly it can be interop issue for people doing \u003d\u003d200 or \u003d\u003d204.\n\nBut seems like glance team decided not to backport this.","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9710863e857dcdf64d3b2acefd1f910c00990e43","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/tags\u0027 % namespace"},{"line_number":118,"context_line":"        resp, _ \u003d self.delete(url)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # NOTE(rosmaita): Bug 1656183 fixed the success response code for"},{"line_number":121,"context_line":"        # this call.  We check the old (incorrect) code first in case this"},{"line_number":122,"context_line":"        # tempest is being run against an old Glance.  The correct code is"},{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_24071919","line":125,"range":{"start_line":120,"start_character":0,"end_line":125,"end_character":15},"in_reply_to":"fa31d9ce_fa8b1966","updated":"2017-02-14 22:07:42.000000000","message":"My understanding of defcore is that specific functionality is picked for inclusion in the interoperability standards by indicating the UUIDs of particular tempest tests.  I don\u0027t see how this change would reduce the value of tempest for defcore purposes.  Additionally, to my knowledge, the Glance metadefs calls have never been included in defcore.","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"301411c90714613778935ae2cf1ba75bae53c54c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"},{"line_number":129,"context_line":"            self.expected_success(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_fabcbcbc","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":51},"updated":"2017-02-14 23:20:17.000000000","message":"I did read TC meeting log and I am respecting their decision.\n\nNow I should not -1 on this direction.\nSo here is a technical advice. We can change here like\n\n self.expected_success([200, 204], resp.status)\n\ninstead of this based on https://github.com/openstack/tempest/blob/master/tempest/lib/common/rest_client.py#L242","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cc4b63a1754af95b1f2ca6d873d4d67124d80c12","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"},{"line_number":129,"context_line":"            self.expected_success(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_15e6c1af","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":51},"updated":"2017-02-15 00:08:48.000000000","message":"Thanks Brian for taking this up.\n\nFrom TC decision, looks like we agree on changing the success code so i am ok for this case.\n\nBut should not we just check the 204 and glance should backport fix to stable branches ?\n\nlet me know if backporting things also being disused somewhere, because different behavior on different release if really dangerous.","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"802bcf0fe87b500b0a58eef4018de602899c1537","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"},{"line_number":129,"context_line":"            self.expected_success(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_8bc28de7","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":51},"in_reply_to":"fa31d9ce_15e6c1af","updated":"2017-02-15 04:00:58.000000000","message":"Andrea mentioned on https://review.openstack.org/#/c/432610/ that he was worried that people sometimes run tempest on older versions of stable branches, so I think it makes sense to accept both codes.\n\nIf you feel strongly that the success code change should be backported to all stable branches, please leave a comment on the bug, https://launchpad.net/bugs/1656183.  Thanks!","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9746099d67c4565ae6dd804dde24271b9634382","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"},{"line_number":129,"context_line":"            self.expected_success(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_d772fcac","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":51},"in_reply_to":"fa31d9ce_8bc28de7","updated":"2017-02-17 08:00:30.000000000","message":"Yea that\u0027s true. I commented on bug about stable branch but saw comment from Ian about not to backport that So i am ok.\n\nAs suggested by Kenichi, can we do like below. \n\nself.expected_success([200, 204], resp.status)","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1cf338fddc25364a48b04f31bb9ba02ee5679f5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"},{"line_number":129,"context_line":"            self.expected_success(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_b8e00998","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":51},"in_reply_to":"fa31d9ce_d772fcac","updated":"2017-02-17 15:26:29.000000000","message":"Works for me!","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"802bcf0fe87b500b0a58eef4018de602899c1537","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # checked in the except clause so that if the second check fails,"},{"line_number":124,"context_line":"        # too, the error message will mention 204 (the correct expected"},{"line_number":125,"context_line":"        # code)."},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":128,"context_line":"        except exceptions.InvalidHttpSuccessCode:"},{"line_number":129,"context_line":"            self.expected_success(204, resp.status)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_16f884c2","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":51},"in_reply_to":"fa31d9ce_fabcbcbc","updated":"2017-02-15 04:00:58.000000000","message":"My only qualm about using the list as you suggest is that if the call returned, say, a 201, the error message will say \"the expected code is [200, 204]\" whereas the expected code is really 204 (we\u0027re just accepting 200 because of the bug).  The crazy try block I\u0027ve got above would give you \"the expected code is 204\" in the failure message.  I just wanted to run that by you one more time before making the change.  I don\u0027t think it makes a big difference, really, so if it would be a more common usage pattern in tempest to use the list, I\u0027ll be happy to change this.","commit_id":"384e5984f0ad7db97f84c4eb85a585e6d0a57229"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"f565520b983076287a9fc5083cd634da270ac168","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        # this call to make it consistent with the other metadefs delete"},{"line_number":121,"context_line":"        # calls.  Accept both codes in case tempest is being run against"},{"line_number":122,"context_line":"        # an old Glance."},{"line_number":123,"context_line":"        self.expected_success([200, 204], resp.status)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_dbaf2e28","line":123,"range":{"start_line":123,"start_character":30,"end_line":123,"end_character":40},"updated":"2017-02-22 22:27:16.000000000","message":"This actually would mean that the service may return either code depending on some system status which is not controlled by the test.\n\nThe policy for Tempest is to back port the change: https://docs.openstack.org/developer/tempest/HACKING.html#bug-fix-on-core-project-needing-tempest-changes\n\nFor features (which are not back ported) we use feature flags, but that does not apply for a change like this.","commit_id":"7eba6ae54dd799d873f7ba93f629b81ed0f1ecc7"}]}