)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"58a37e7248faa7b2b5da89884626b674eb279e42","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        router_ports \u003d [(i[\u0027device_id\u0027], f[\u0027subnet_id\u0027])"},{"line_number":245,"context_line":"                        for i in self._list_ports()"},{"line_number":246,"context_line":"                        for f in i[\u0027fixed_ips\u0027]"},{"line_number":247,"context_line":"                        if net_info.is_router_interface_port(i)]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertIn(myport, router_ports)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_ec8386ca","line":247,"updated":"2017-02-13 09:22:07.000000000","message":"You are calling this function at too high number of times,\ncan you move this condition earlier in the loop , to not ron len(i)*len(i.f) times, just len(i) times.","commit_id":"8bae50bc16421fe7c8009ccf720a364ac23aab12"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f6cc85f7f606a1d0df3807c2ad86cab7afef1464","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        router_ports \u003d [(i[\u0027device_id\u0027], f[\u0027subnet_id\u0027])"},{"line_number":245,"context_line":"                        for i in self._list_ports()"},{"line_number":246,"context_line":"                        for f in i[\u0027fixed_ips\u0027]"},{"line_number":247,"context_line":"                        if net_info.is_router_interface_port(i)]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertIn(myport, router_ports)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_8ca68a51","line":247,"in_reply_to":"fa31d9ce_ec8386ca","updated":"2017-02-13 09:30:50.000000000","message":"Done","commit_id":"8bae50bc16421fe7c8009ccf720a364ac23aab12"}]}
