)]}'
{"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"247dfdf6e3994f3bd05cd3c5da0b76da52c57862","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.exec_command(\u0027sudo umount %s\u0027 % mount_path)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def make_fs(self, dev_name, fs\u003d\u0027ext4\u0027):"},{"line_number":245,"context_line":"        cmd_mkfs \u003d \u0027sudo /usr/sbin/mke2fs -F -t %s /dev/%s\u0027 % (fs, dev_name)"},{"line_number":246,"context_line":"        try:"},{"line_number":247,"context_line":"            self.exec_command(cmd_mkfs)"},{"line_number":248,"context_line":"        except tempest.lib.exceptions.SSHExecCommandFailed:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_224ad055","line":245,"updated":"2017-02-14 08:36:56.000000000","message":"I\u0027m actually worried about forcing here.. IIUC, we use this method for a new device. So, this should pass normally. Do you have any specific timing or path?\nOr if you want to add -F option here, I think it should be an option with adding an extra argument to this method like \u0027force\u003dFalse\u0027.","commit_id":"9ddc5b96b5517a3db9e537e01c6475b97714ef0d"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"42bc43bbfec15bfc308c973af3531e2c8029d525","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.exec_command(\u0027sudo umount %s\u0027 % mount_path)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def make_fs(self, dev_name, fs\u003d\u0027ext4\u0027):"},{"line_number":245,"context_line":"        cmd_mkfs \u003d \u0027sudo /usr/sbin/mke2fs -F -t %s /dev/%s\u0027 % (fs, dev_name)"},{"line_number":246,"context_line":"        try:"},{"line_number":247,"context_line":"            self.exec_command(cmd_mkfs)"},{"line_number":248,"context_line":"        except tempest.lib.exceptions.SSHExecCommandFailed:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_fc3e9589","line":245,"in_reply_to":"fa31d9ce_224ad055","updated":"2017-02-14 13:10:12.000000000","message":"It looks like mke2fs \u003c 1.43 had this check, asking for confirmation when attempting to format a whole disk as a fs.\n\nhttp://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.43\n\u0027Mke2fs no longer complains if the user tries to create a file system using the entire block device (e.g., without using a partition). The minor number convention is not used by all block devices, and it\u0027s quite normal in some circumstances to create a file system on /dev/sdc instead of /dev/sdc1.\u0027\n\nIMO, it should be safe to pass that force argument, otherwise people using older mke2fs versions will have issues with this. Alternatively, we can just go back to mkfs.ext4, which was used before this refactoring got merged: https://review.openstack.org/#/c/226979/","commit_id":"9ddc5b96b5517a3db9e537e01c6475b97714ef0d"}]}