)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5319d212fa99e9a5a67ab168e8e399bf6f0a6c27","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        client.delete_volume(volume_id)"},{"line_number":172,"context_line":"        client.wait_for_resource_deletion(volume_id)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def delete_snapshot(self, snapshot_id, snapshot_client\u003dNone):"},{"line_number":175,"context_line":"        \"\"\"Delete snapshot by the given client\"\"\""},{"line_number":176,"context_line":"        if snapshot_client is None:"},{"line_number":177,"context_line":"            snapshot_client \u003d self.snapshots_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_4cd0c4f6","line":174,"updated":"2017-02-14 16:40:58.000000000","message":"could you make this plural: \"snapshots_client\".","commit_id":"dfab5925fb2a44ee8b452e1ad24cfcb6c518e93d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"11cb672e714e0a58687045c0af8f184e0cd8dda5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        client.delete_volume(volume_id)"},{"line_number":172,"context_line":"        client.wait_for_resource_deletion(volume_id)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def delete_snapshot(self, snapshot_id, snapshot_client\u003dNone):"},{"line_number":175,"context_line":"        \"\"\"Delete snapshot by the given client\"\"\""},{"line_number":176,"context_line":"        if snapshot_client is None:"},{"line_number":177,"context_line":"            snapshot_client \u003d self.snapshots_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_846a90b1","line":174,"in_reply_to":"fa31d9ce_4cd0c4f6","updated":"2017-02-14 17:26:52.000000000","message":"Done","commit_id":"dfab5925fb2a44ee8b452e1ad24cfcb6c518e93d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5319d212fa99e9a5a67ab168e8e399bf6f0a6c27","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def delete_snapshot(self, snapshot_id, snapshot_client\u003dNone):"},{"line_number":175,"context_line":"        \"\"\"Delete snapshot by the given client\"\"\""},{"line_number":176,"context_line":"        if snapshot_client is None:"},{"line_number":177,"context_line":"            snapshot_client \u003d self.snapshots_client"},{"line_number":178,"context_line":"        snapshot_client.delete_snapshot(snapshot_id)"},{"line_number":179,"context_line":"        snapshot_client.wait_for_resource_deletion(snapshot_id)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_0c388c3c","line":177,"updated":"2017-02-14 16:40:58.000000000","message":"See: it\u0027s in plural here: self.snapshots_client.","commit_id":"dfab5925fb2a44ee8b452e1ad24cfcb6c518e93d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"11cb672e714e0a58687045c0af8f184e0cd8dda5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def delete_snapshot(self, snapshot_id, snapshot_client\u003dNone):"},{"line_number":175,"context_line":"        \"\"\"Delete snapshot by the given client\"\"\""},{"line_number":176,"context_line":"        if snapshot_client is None:"},{"line_number":177,"context_line":"            snapshot_client \u003d self.snapshots_client"},{"line_number":178,"context_line":"        snapshot_client.delete_snapshot(snapshot_id)"},{"line_number":179,"context_line":"        snapshot_client.wait_for_resource_deletion(snapshot_id)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_a46794e7","line":177,"in_reply_to":"fa31d9ce_0c388c3c","updated":"2017-02-14 17:26:52.000000000","message":"Done","commit_id":"dfab5925fb2a44ee8b452e1ad24cfcb6c518e93d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"48c224618d63e2c3a2cb783ef2f0e44fcc678385","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \"\"\"Delete snapshot by the given client\"\"\""},{"line_number":176,"context_line":"        if snapshots_client is None:"},{"line_number":177,"context_line":"            snapshots_client \u003d self.snapshots_client"},{"line_number":178,"context_line":"        if snapshot_id in self.snapshots:"},{"line_number":179,"context_line":"            self.snapshots.remove(snapshot_id)"},{"line_number":180,"context_line":"        snapshots_client.delete_snapshot(snapshot_id)"},{"line_number":181,"context_line":"        snapshots_client.wait_for_resource_deletion(snapshot_id)"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_88e3e132","line":179,"range":{"start_line":178,"start_character":0,"end_line":179,"end_character":46},"updated":"2017-02-21 16:54:33.000000000","message":"let\u0027s remove it from self.snapshots after it is actually deleted. I mean after line 181","commit_id":"d1ddf8bc3c2a1555452e4a3a5bcad514c39b585f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c657f1ac514080b14e2d4c89d177e14e183cf3db","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \"\"\"Delete snapshot by the given client\"\"\""},{"line_number":176,"context_line":"        if snapshots_client is None:"},{"line_number":177,"context_line":"            snapshots_client \u003d self.snapshots_client"},{"line_number":178,"context_line":"        if snapshot_id in self.snapshots:"},{"line_number":179,"context_line":"            self.snapshots.remove(snapshot_id)"},{"line_number":180,"context_line":"        snapshots_client.delete_snapshot(snapshot_id)"},{"line_number":181,"context_line":"        snapshots_client.wait_for_resource_deletion(snapshot_id)"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_c2d204d2","line":179,"range":{"start_line":178,"start_character":0,"end_line":179,"end_character":46},"in_reply_to":"da36d5c6_88e3e132","updated":"2017-02-22 07:05:10.000000000","message":"Done","commit_id":"d1ddf8bc3c2a1555452e4a3a5bcad514c39b585f"}],"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50a1ec1388da8d328c324cead5b98ebd9d804a74","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027],"},{"line_number":47,"context_line":"                                        force\u003dTrue)"},{"line_number":48,"context_line":"        # Delete the snapshot"},{"line_number":49,"context_line":"        self.delete_snapshot(snapshot[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u00278567b54c-4455-446d-a1cf-651ddeaa3ff2\u0027)"},{"line_number":52,"context_line":"    @test.services(\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_f4c9be5b","line":49,"range":{"start_line":49,"start_character":41,"end_line":49,"end_character":44},"updated":"2017-02-17 07:45:02.000000000","message":"i did get actual benefit of this change but I can surly ask to remove the created snapshots from self.snapshots to avoid the unnecessary 2 API calls when base class do clear_snapshot in resource_cleaup.\n\nditto on below places. \n\nBut do we get much benefit of changing existing cleanup_snapshot this class has ?","commit_id":"51dfd2ad2e0c91d725f4db8c1d753dac37f7da0b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b49ba42d5e926f3ae159dc54306edff3c479949b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027],"},{"line_number":47,"context_line":"                                        force\u003dTrue)"},{"line_number":48,"context_line":"        # Delete the snapshot"},{"line_number":49,"context_line":"        self.delete_snapshot(snapshot[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u00278567b54c-4455-446d-a1cf-651ddeaa3ff2\u0027)"},{"line_number":52,"context_line":"    @test.services(\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_575e2e46","line":49,"range":{"start_line":49,"start_character":41,"end_line":49,"end_character":44},"in_reply_to":"fa31d9ce_f4c9be5b","updated":"2017-02-19 08:48:56.000000000","message":"Right thanks, I should remove the created snapshots from self.snapshots.\nGenerally, I think it\u0027s better to use a common method as much as possible. Other tests can benefit from that method.","commit_id":"51dfd2ad2e0c91d725f4db8c1d753dac37f7da0b"}]}