)]}'
{"tempest/common/ssh.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"69c00bc474ae292a2a29f724664bfc12f23144f6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        err_data \u003d []"},{"line_number":116,"context_line":"        poll \u003d select.poll()"},{"line_number":117,"context_line":"        poll.register(channel, select.POLLIN)"},{"line_number":118,"context_line":"        start_time \u003d datetime.datetime.now()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        def millis_passed():"},{"line_number":121,"context_line":"            return (datetime.datetime.now() - start_time).microseconds / 1000"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASX%2F%2F9M0%3D","line":118,"updated":"2013-08-23 09:49:24.000000000","message":"It looks good, but you could avoid the additional import and division below by using start_time \u003d time.time()","commit_id":"32fffed4bae4f926a24ee22d06fa6192b2c15bfa"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"565726a166f558bc5a008b4d26a1b8485d3a771a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        start_time \u003d datetime.datetime.now()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        def millis_passed():"},{"line_number":121,"context_line":"            return (datetime.datetime.now() - start_time).microseconds / 1000"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        while True:"},{"line_number":124,"context_line":"            ready \u003d poll.poll(self.channel_timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASX%2F%2F8xo%3D","line":121,"updated":"2013-08-23 10:13:05.000000000","message":"I just didn\u0027t like the idea of:\n\n (time.time() - start_time) * 1000\n\nand now() says it could be more precise than time:\n \n http://docs.python.org/2/library/datetime.html#datetime.datetime.now\n\nLet me know, if you still prefer to change over to time","commit_id":"32fffed4bae4f926a24ee22d06fa6192b2c15bfa"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"fc2efc9cd5b1421a29e8cd2d064820d7be1a84ec","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        start_time \u003d datetime.datetime.now()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        def millis_passed():"},{"line_number":121,"context_line":"            return (datetime.datetime.now() - start_time).microseconds / 1000"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        while True:"},{"line_number":124,"context_line":"            ready \u003d poll.poll(self.channel_timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASX%2F%2F8tw%3D","line":121,"in_reply_to":"AAAASX%2F%2F8xo%3D","updated":"2013-08-23 10:37:00.000000000","message":"Sounds good using datetime then","commit_id":"32fffed4bae4f926a24ee22d06fa6192b2c15bfa"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"fc2efc9cd5b1421a29e8cd2d064820d7be1a84ec","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        while True:"},{"line_number":124,"context_line":"            ready \u003d poll.poll(self.channel_timeout)"},{"line_number":125,"context_line":"            if not any(ready):"},{"line_number":126,"context_line":"                if millis_passed() \u003c self.timeout:"},{"line_number":127,"context_line":"                    continue"},{"line_number":128,"context_line":"                raise exceptions.TimeoutException("},{"line_number":129,"context_line":"                    \"Command: \u0027{0}\u0027 executed on host \u0027{1}\u0027.\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASX%2F%2F8tc%3D","line":126,"updated":"2013-08-23 10:37:00.000000000","message":"The configured timeout is in seconds, and I just noticed that you are comparing it against milliseconds.","commit_id":"32fffed4bae4f926a24ee22d06fa6192b2c15bfa"}]}