)]}'
{"tempest/api/volume/test_volumes_extend.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8c1c4172e49ed07910e70bf01230ef6e289e3252","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Verify volume size was updated"},{"line_number":48,"context_line":"        volume_info \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(extend_size, volume_info[\u0027size\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Create a snapshot"},{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_1346a17a","line":49,"range":{"start_line":49,"start_character":7,"end_line":49,"end_character":58},"updated":"2017-02-16 03:33:18.000000000","message":"The former part of this testcase is same as test_volume_extend, so will you consider just add a check of snapshot in test_volume_extend?","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5e75fdc8ec463a688c1a9f8e5294ea76b954bb54","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Verify volume size was updated"},{"line_number":48,"context_line":"        volume_info \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(extend_size, volume_info[\u0027size\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Create a snapshot"},{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_7f687388","line":49,"range":{"start_line":49,"start_character":7,"end_line":49,"end_character":58},"in_reply_to":"fa31d9ce_1346a17a","updated":"2017-02-16 10:56:06.000000000","message":"Yes, this is already checked in the previous test.","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f0eaf031c5a9811feace81f614bc89f38ccf8a40","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Verify volume size was updated"},{"line_number":48,"context_line":"        volume_info \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(extend_size, volume_info[\u0027size\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Create a snapshot"},{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_05a48106","line":49,"range":{"start_line":49,"start_character":7,"end_line":49,"end_character":58},"in_reply_to":"fa31d9ce_7f687388","updated":"2017-02-16 12:50:27.000000000","message":"Right, but I think we should separate those tests.\nAll the idea of this test is to check snapshot creation from extended volume. Maybe it\u0027s better to create a one method for both tests. But I think Jordan right this test related to snapshot.","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8c1c4172e49ed07910e70bf01230ef6e289e3252","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(extend_size, volume_info[\u0027size\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Create a snapshot"},{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Verify volume and snapshot size are the same"},{"line_number":55,"context_line":"        self.assertEqual(volume_info[\u0027size\u0027], snapshot[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_53ae592e","line":52,"range":{"start_line":52,"start_character":24,"end_line":52,"end_character":39},"updated":"2017-02-16 03:33:18.000000000","message":"should skip if CONF.volume_feature_enabled.snapshot not True?","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f0eaf031c5a9811feace81f614bc89f38ccf8a40","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(extend_size, volume_info[\u0027size\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Create a snapshot"},{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Verify volume and snapshot size are the same"},{"line_number":55,"context_line":"        self.assertEqual(volume_info[\u0027size\u0027], snapshot[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_2a01543a","line":52,"range":{"start_line":52,"start_character":24,"end_line":52,"end_character":39},"in_reply_to":"fa31d9ce_53ae592e","updated":"2017-02-16 12:50:27.000000000","message":"Right, thanks","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5e75fdc8ec463a688c1a9f8e5294ea76b954bb54","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Verify volume and snapshot size are the same"},{"line_number":55,"context_line":"        self.assertEqual(volume_info[\u0027size\u0027], snapshot[\u0027size\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class VolumesV1ExtendTest(VolumesV2ExtendTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_5f02cfb5","line":55,"updated":"2017-02-16 10:56:06.000000000","message":"In the end, this only checks that the snapshot size is the same size as the volume. So it\u0027s not related to the volume extend feature, and it\u0027s already tested somewhere else anyway.","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f0eaf031c5a9811feace81f614bc89f38ccf8a40","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Verify volume and snapshot size are the same"},{"line_number":55,"context_line":"        self.assertEqual(volume_info[\u0027size\u0027], snapshot[\u0027size\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class VolumesV1ExtendTest(VolumesV2ExtendTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_65f53dca","line":55,"in_reply_to":"fa31d9ce_5f02cfb5","updated":"2017-02-16 12:50:27.000000000","message":"There is not a any test that check snapshot creation from extended volume. I think we should test it. \nThe test you are going to resurect is other case. \nBut I think you right that it\u0027s more related to snapshot.","commit_id":"c920740564b567bc85a9e00af1c6bba625a5f16f"}]}