)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"6a376132b4bd0ab7f2f0dc6f25e3c969c656939d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gal Amado \u003cgamado@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-02 08:49:46 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a check for image protected field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5022fd3cfb729ff0e8de82b5ccb22886da34c94d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_24bff9aa","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2017-03-12 23:11:15.000000000","message":"Can you provide a commit message body and some background for this change?\n\nThe extra check in the test updates the protected field, but it\u0027s not checking the protected behaviour, so I don\u0027t see any extra value compared to the existing check of updating the name... unless there is a specific point related to proceed which is worth testing this way.","commit_id":"fb102c9116b15b04d14e094fb83a22e06f59c2dc"}],"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8c04189a6344a8693212cb2a7311c6382cc7dd1c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        Update protected field back to be False"},{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":"        # Create image"},{"line_number":140,"context_line":"        container_format \u003d CONF.image.container_formats[0]"},{"line_number":141,"context_line":"        disk_format \u003d CONF.image.disk_formats[0]"},{"line_number":142,"context_line":"        image \u003d self.create_image(name\u003ddata_utils.rand_name(\u0027image\u0027),"},{"line_number":143,"context_line":"                                  container_format\u003dcontainer_format,"},{"line_number":144,"context_line":"                                  disk_format\u003ddisk_format,"},{"line_number":145,"context_line":"                                  visibility\u003d\u0027private\u0027)"},{"line_number":146,"context_line":"        self.assertEqual(False, image[\u0027protected\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # Update Image protected field to be True"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_90440375","line":145,"range":{"start_line":140,"start_character":8,"end_line":145,"end_character":55},"updated":"2017-02-21 06:34:04.000000000","message":"You don\u0027t need all those parameters, you only test the protected field. \nimage \u003d self.create_image()","commit_id":"6d48fb77fb12f08986058bee973eba1fc83a53db"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"c5138aa910dddcbcedfcc15fcbeed6a88e8343a0","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        Update protected field back to be False"},{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":"        # Create image"},{"line_number":140,"context_line":"        container_format \u003d CONF.image.container_formats[0]"},{"line_number":141,"context_line":"        disk_format \u003d CONF.image.disk_formats[0]"},{"line_number":142,"context_line":"        image \u003d self.create_image(name\u003ddata_utils.rand_name(\u0027image\u0027),"},{"line_number":143,"context_line":"                                  container_format\u003dcontainer_format,"},{"line_number":144,"context_line":"                                  disk_format\u003ddisk_format,"},{"line_number":145,"context_line":"                                  visibility\u003d\u0027private\u0027)"},{"line_number":146,"context_line":"        self.assertEqual(False, image[\u0027protected\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # Update Image protected field to be True"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_946dd29a","line":145,"range":{"start_line":140,"start_character":8,"end_line":145,"end_character":55},"in_reply_to":"da36d5c6_90440375","updated":"2017-02-21 09:00:47.000000000","message":"Done","commit_id":"6d48fb77fb12f08986058bee973eba1fc83a53db"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8c04189a6344a8693212cb2a7311c6382cc7dd1c","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Verify updating"},{"line_number":153,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":155,"context_line":"        self.assertEqual(True, body[\u0027protected\u0027])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Update Image protected field back to False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_7036af04","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":49},"updated":"2017-02-21 06:34:04.000000000","message":"I think it\u0027s redundant, you only need to check the protected field.","commit_id":"6d48fb77fb12f08986058bee973eba1fc83a53db"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"c5138aa910dddcbcedfcc15fcbeed6a88e8343a0","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Verify updating"},{"line_number":153,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":155,"context_line":"        self.assertEqual(True, body[\u0027protected\u0027])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Update Image protected field back to False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_b4681689","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":49},"in_reply_to":"da36d5c6_7036af04","updated":"2017-02-21 09:00:47.000000000","message":"Done","commit_id":"6d48fb77fb12f08986058bee973eba1fc83a53db"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8c04189a6344a8693212cb2a7311c6382cc7dd1c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":155,"context_line":"        self.assertEqual(True, body[\u0027protected\u0027])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Update Image protected field back to False"},{"line_number":158,"context_line":"        body \u003d self.client.update_image(image[\u0027id\u0027], ["},{"line_number":159,"context_line":"            dict(replace\u003d\u0027/protected\u0027, value\u003dFalse)])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class ListUserImagesTest(base.BaseV2ImageTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_ab5c3626","line":159,"range":{"start_line":157,"start_character":8,"end_line":159,"end_character":53},"updated":"2017-02-21 06:34:04.000000000","message":"I think it\u0027s better to move it right after L150 \nwith addCleanup().","commit_id":"6d48fb77fb12f08986058bee973eba1fc83a53db"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"c5138aa910dddcbcedfcc15fcbeed6a88e8343a0","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":155,"context_line":"        self.assertEqual(True, body[\u0027protected\u0027])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Update Image protected field back to False"},{"line_number":158,"context_line":"        body \u003d self.client.update_image(image[\u0027id\u0027], ["},{"line_number":159,"context_line":"            dict(replace\u003d\u0027/protected\u0027, value\u003dFalse)])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class ListUserImagesTest(base.BaseV2ImageTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_d4058ac2","line":159,"range":{"start_line":157,"start_character":8,"end_line":159,"end_character":53},"in_reply_to":"da36d5c6_ab5c3626","updated":"2017-02-21 09:00:47.000000000","message":"Done","commit_id":"6d48fb77fb12f08986058bee973eba1fc83a53db"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"af7453b5e5f6e817100ef1293db50dc23bbd31e1","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":137,"context_line":"    @decorators.idempotent_id(\u0027f16bc277-3b68-479b-82ed-60af2de973f2\u0027)"},{"line_number":138,"context_line":"    def test_update_image_protected(self):"},{"line_number":139,"context_line":"        \"\"\"Updates an image protected field"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        Create an image"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_34ec268f","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":35},"updated":"2017-02-21 09:11:43.000000000","message":"This should be deleted?","commit_id":"c2a5fca0b0750d1b3dcd19c05b239c1205ae989c"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"fd1d08adc25e26e468bf75895c9f7db33ec23d53","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":137,"context_line":"    @decorators.idempotent_id(\u0027f16bc277-3b68-479b-82ed-60af2de973f2\u0027)"},{"line_number":138,"context_line":"    def test_update_image_protected(self):"},{"line_number":139,"context_line":"        \"\"\"Updates an image protected field"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        Create an image"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_dda9267d","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":35},"in_reply_to":"da36d5c6_34ec268f","updated":"2017-02-21 13:20:42.000000000","message":"Done","commit_id":"c2a5fca0b0750d1b3dcd19c05b239c1205ae989c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"af3c320ce5187dcdb326674a51a2eced89d61c9a","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # Update Image name"},{"line_number":119,"context_line":"        new_image_name \u003d data_utils.rand_name(\u0027new-image\u0027)"},{"line_number":120,"context_line":"        body \u003d self.client.update_image(image[\u0027id\u0027], ["},{"line_number":121,"context_line":"            dict(replace\u003d\u0027/name\u0027, value\u003dnew_image_name)])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Update Image protected field to be True"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_13cb9873","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":15},"updated":"2017-02-22 01:57:00.000000000","message":"this can be removed","commit_id":"4c7e12022a03756a542782c6d81ba5f96cab1c20"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"477a1fcccb85e3d752ee8429ff9c882a725b2c50","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # Update Image name"},{"line_number":119,"context_line":"        new_image_name \u003d data_utils.rand_name(\u0027new-image\u0027)"},{"line_number":120,"context_line":"        body \u003d self.client.update_image(image[\u0027id\u0027], ["},{"line_number":121,"context_line":"            dict(replace\u003d\u0027/name\u0027, value\u003dnew_image_name)])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Update Image protected field to be True"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_1c43206d","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":15},"in_reply_to":"da36d5c6_13cb9873","updated":"2017-02-26 11:30:58.000000000","message":"Done","commit_id":"4c7e12022a03756a542782c6d81ba5f96cab1c20"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"af3c320ce5187dcdb326674a51a2eced89d61c9a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            dict(replace\u003d\u0027/name\u0027, value\u003dnew_image_name)])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Update Image protected field to be True"},{"line_number":124,"context_line":"        body \u003d self.client.update_image(image[\u0027id\u0027], ["},{"line_number":125,"context_line":"            dict(replace\u003d\u0027/protected\u0027, value\u003dTrue)])"},{"line_number":126,"context_line":"        self.addCleanup(self.client.update_image, image[\u0027id\u0027],"},{"line_number":127,"context_line":"                        [dict(replace\u003d\"/protected\", value\u003dFalse)])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_f3cfe47c","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":15},"updated":"2017-02-22 01:57:00.000000000","message":"this can be removed","commit_id":"4c7e12022a03756a542782c6d81ba5f96cab1c20"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"477a1fcccb85e3d752ee8429ff9c882a725b2c50","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            dict(replace\u003d\u0027/name\u0027, value\u003dnew_image_name)])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Update Image protected field to be True"},{"line_number":124,"context_line":"        body \u003d self.client.update_image(image[\u0027id\u0027], ["},{"line_number":125,"context_line":"            dict(replace\u003d\u0027/protected\u0027, value\u003dTrue)])"},{"line_number":126,"context_line":"        self.addCleanup(self.client.update_image, image[\u0027id\u0027],"},{"line_number":127,"context_line":"                        [dict(replace\u003d\"/protected\", value\u003dFalse)])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_3c46247b","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":15},"in_reply_to":"da36d5c6_f3cfe47c","updated":"2017-02-26 11:30:58.000000000","message":"Done","commit_id":"4c7e12022a03756a542782c6d81ba5f96cab1c20"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"af3c320ce5187dcdb326674a51a2eced89d61c9a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                        [dict(replace\u003d\"/protected\", value\u003dFalse)])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verifying updating"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":132,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":133,"context_line":"        self.assertEqual(new_image_name, body[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_93a5c8b6","line":130,"updated":"2017-02-22 01:57:00.000000000","message":"the blank line can be removed","commit_id":"4c7e12022a03756a542782c6d81ba5f96cab1c20"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"477a1fcccb85e3d752ee8429ff9c882a725b2c50","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                        [dict(replace\u003d\"/protected\", value\u003dFalse)])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verifying updating"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":132,"context_line":"        self.assertEqual(image[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":133,"context_line":"        self.assertEqual(new_image_name, body[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_5c611804","line":130,"in_reply_to":"da36d5c6_93a5c8b6","updated":"2017-02-26 11:30:58.000000000","message":"Done","commit_id":"4c7e12022a03756a542782c6d81ba5f96cab1c20"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7f2025ef275a3538a13aa002085336f0f1ffd325","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.client.update_image(image[\u0027id\u0027], ["},{"line_number":125,"context_line":"            dict(replace\u003d\u0027/protected\u0027, value\u003dTrue)])"},{"line_number":126,"context_line":"        self.addCleanup(self.client.update_image, image[\u0027id\u0027],"},{"line_number":127,"context_line":"                        [dict(replace\u003d\"/protected\", value\u003dFalse)])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verifying updating"},{"line_number":130,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_64034a43","line":127,"range":{"start_line":127,"start_character":24,"end_line":127,"end_character":65},"updated":"2017-03-01 18:44:00.000000000","message":"nit: Here could just be like\n\n [{\"replace\": \"/protected\", \"value\": False}]","commit_id":"af6d3a11a6a3080932819764d8b6ec07dc407f00"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"a0b37a62ad833249bbe8b0f0ca74b8447e248ad3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.client.update_image(image[\u0027id\u0027], ["},{"line_number":125,"context_line":"            dict(replace\u003d\u0027/protected\u0027, value\u003dTrue)])"},{"line_number":126,"context_line":"        self.addCleanup(self.client.update_image, image[\u0027id\u0027],"},{"line_number":127,"context_line":"                        [dict(replace\u003d\"/protected\", value\u003dFalse)])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verifying updating"},{"line_number":130,"context_line":"        body \u003d self.client.show_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_78bf54fb","line":127,"range":{"start_line":127,"start_character":24,"end_line":127,"end_character":65},"in_reply_to":"ba2be162_64034a43","updated":"2017-03-02 06:49:25.000000000","message":"Done","commit_id":"af6d3a11a6a3080932819764d8b6ec07dc407f00"}]}