)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0ec42b4da1590d86d72893e698150f8174407e45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add content-type without spaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In public cloud implementation, the tomcat module"},{"line_number":10,"context_line":"(specifically tomcat-coyote) used by the api-gateway"},{"line_number":11,"context_line":"will eliminate the space within the content-type,"},{"line_number":12,"context_line":"e.g ret \u003d ret + \";charset\u003d\" + this.characterEncoding;"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In the current rfc7231 standard, all the following"},{"line_number":15,"context_line":"content-type are permissible and equivalent:"},{"line_number":16,"context_line":"test/html;charset\u003dutf-8"},{"line_number":17,"context_line":"test/html;charset\u003dUTF-8"},{"line_number":18,"context_line":"test/HTML;Charset\u003d\"utf-8\""},{"line_number":19,"context_line":"test/html; charset\u003d\"utf-8\""},{"line_number":20,"context_line":"(https://tools.ietf.org/html/rfc7231#section-3.1.1.1)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"However in the current tempest rest_client setting,"},{"line_number":23,"context_line":"there is no content-type without space defined in"},{"line_number":24,"context_line":"JSON_ENC and TXT_ENC. This results in defcore test"},{"line_number":25,"context_line":"failure for public cloud since after tomcat module"},{"line_number":26,"context_line":"eliminates the space, the content-type will not be"},{"line_number":27,"context_line":"recognized as a legitimate one."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch intends to solve this problem by providing"},{"line_number":30,"context_line":"additional content-type without spaces as allowed in"},{"line_number":31,"context_line":"rfc7231 to JSON_ENC and TXT_ENC so that defcore test"},{"line_number":32,"context_line":"won\u0027t be blocked for public cloud implementation."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: I718ef0e3ddae513cb911aca38985162027274001"},{"line_number":35,"context_line":"Signed-off-by: zhipengh \u003chuangzhipeng@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_e74a9125","line":32,"range":{"start_line":9,"start_character":0,"end_line":32,"end_character":49},"updated":"2017-02-23 00:54:57.000000000","message":"Very great explanation, thanks so much.\nThis patch changes tempest.lib which is stable interface, and such changes require the corresponding reno file.\nIt is enough to write the summary of this message into the reno.","commit_id":"a9b0574a09764b49542028bac73d41102fb52b40"},{"author":{"_account_id":13629,"name":"Zhipeng","email":"huangzhipeng@huawei.com","username":"zhipengh"},"change_message_id":"18057426d530e11ff3f9a510ae276468d0920562","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add content-type without spaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In public cloud implementation, the tomcat module"},{"line_number":10,"context_line":"(specifically tomcat-coyote) used by the api-gateway"},{"line_number":11,"context_line":"will eliminate the space within the content-type,"},{"line_number":12,"context_line":"e.g ret \u003d ret + \";charset\u003d\" + this.characterEncoding;"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In the current rfc7231 standard, all the following"},{"line_number":15,"context_line":"content-type are permissible and equivalent:"},{"line_number":16,"context_line":"test/html;charset\u003dutf-8"},{"line_number":17,"context_line":"test/html;charset\u003dUTF-8"},{"line_number":18,"context_line":"test/HTML;Charset\u003d\"utf-8\""},{"line_number":19,"context_line":"test/html; charset\u003d\"utf-8\""},{"line_number":20,"context_line":"(https://tools.ietf.org/html/rfc7231#section-3.1.1.1)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"However in the current tempest rest_client setting,"},{"line_number":23,"context_line":"there is no content-type without space defined in"},{"line_number":24,"context_line":"JSON_ENC and TXT_ENC. This results in defcore test"},{"line_number":25,"context_line":"failure for public cloud since after tomcat module"},{"line_number":26,"context_line":"eliminates the space, the content-type will not be"},{"line_number":27,"context_line":"recognized as a legitimate one."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch intends to solve this problem by providing"},{"line_number":30,"context_line":"additional content-type without spaces as allowed in"},{"line_number":31,"context_line":"rfc7231 to JSON_ENC and TXT_ENC so that defcore test"},{"line_number":32,"context_line":"won\u0027t be blocked for public cloud implementation."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: I718ef0e3ddae513cb911aca38985162027274001"},{"line_number":35,"context_line":"Signed-off-by: zhipengh \u003chuangzhipeng@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_9101e5b1","line":32,"range":{"start_line":9,"start_character":0,"end_line":32,"end_character":49},"in_reply_to":"da36d5c6_e74a9125","updated":"2017-02-24 04:12:11.000000000","message":"Hi Ken\u0027ichi, thanks for your support and I\u0027ve updated the reno in the latest patch, please help review it :)","commit_id":"a9b0574a09764b49542028bac73d41102fb52b40"}],"tempest/lib/common/rest_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bf7e96c582d045370ccc6055d35b4758a7976b45","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        if resp.status \u003c 400:"},{"line_number":732,"context_line":"            return"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        JSON_ENC \u003d [\u0027application/json\u0027, \u0027application/json; charset\u003dutf-8\u0027,"},{"line_number":735,"context_line":"                    \u0027application/json;charset\u003dutf-8\u0027]"},{"line_number":736,"context_line":"        # NOTE(mtreinish): This is for compatibility with Glance and swift"},{"line_number":737,"context_line":"        # APIs. These are the return content types that Glance api v1"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_2e3be69d","line":734,"updated":"2017-02-21 14:30:21.000000000","message":"Add a code comment saying at least that the duplication is on purpose.","commit_id":"c94ca732ee5b519017dfc351638b0e204f06c499"},{"author":{"_account_id":13629,"name":"Zhipeng","email":"huangzhipeng@huawei.com","username":"zhipengh"},"change_message_id":"5fdf3b4e3c0f6f63692a41350fcd3c132d0300e0","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        if resp.status \u003c 400:"},{"line_number":732,"context_line":"            return"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        JSON_ENC \u003d [\u0027application/json\u0027, \u0027application/json; charset\u003dutf-8\u0027,"},{"line_number":735,"context_line":"                    \u0027application/json;charset\u003dutf-8\u0027]"},{"line_number":736,"context_line":"        # NOTE(mtreinish): This is for compatibility with Glance and swift"},{"line_number":737,"context_line":"        # APIs. These are the return content types that Glance api v1"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_82a9027e","line":734,"in_reply_to":"da36d5c6_2e3be69d","updated":"2017-02-21 16:13:52.000000000","message":"Done","commit_id":"c94ca732ee5b519017dfc351638b0e204f06c499"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bf7e96c582d045370ccc6055d35b4758a7976b45","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        # (and occasionally swift) are using."},{"line_number":739,"context_line":"        TXT_ENC \u003d [\u0027text/plain\u0027, \u0027text/html\u0027, \u0027text/html; charset\u003dutf-8\u0027,"},{"line_number":740,"context_line":"                   \u0027text/plain; charset\u003dutf-8\u0027, \u0027text/html;charset\u003dutf-8\u0027,"},{"line_number":741,"context_line":"                   \u0027test/plain;charset\u003dutf-8\u0027]"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if ctype.lower() in JSON_ENC:"},{"line_number":744,"context_line":"            parse_resp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_aeab56d5","line":741,"updated":"2017-02-21 14:30:21.000000000","message":"There\u0027s a typo here.","commit_id":"c94ca732ee5b519017dfc351638b0e204f06c499"},{"author":{"_account_id":13629,"name":"Zhipeng","email":"huangzhipeng@huawei.com","username":"zhipengh"},"change_message_id":"5fdf3b4e3c0f6f63692a41350fcd3c132d0300e0","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        # (and occasionally swift) are using."},{"line_number":739,"context_line":"        TXT_ENC \u003d [\u0027text/plain\u0027, \u0027text/html\u0027, \u0027text/html; charset\u003dutf-8\u0027,"},{"line_number":740,"context_line":"                   \u0027text/plain; charset\u003dutf-8\u0027, \u0027text/html;charset\u003dutf-8\u0027,"},{"line_number":741,"context_line":"                   \u0027test/plain;charset\u003dutf-8\u0027]"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if ctype.lower() in JSON_ENC:"},{"line_number":744,"context_line":"            parse_resp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_e2b0fedf","line":741,"in_reply_to":"da36d5c6_aeab56d5","updated":"2017-02-21 16:13:52.000000000","message":"Done","commit_id":"c94ca732ee5b519017dfc351638b0e204f06c499"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"75ff5bbca852af976b19835ef708ed85041ec7c6","unresolved":false,"context_lines":[{"line_number":747,"context_line":"                   \u0027text/plain; charset\u003dutf-8\u0027, \u0027text/html;charset\u003dutf-8\u0027,"},{"line_number":748,"context_line":"                   \u0027text/plain;charset\u003dutf-8\u0027]"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        if ctype.lower() in JSON_ENC:"},{"line_number":751,"context_line":"            parse_resp \u003d True"},{"line_number":752,"context_line":"        elif ctype.lower() in TXT_ENC:"},{"line_number":753,"context_line":"            parse_resp \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_bd805b8c","line":750,"updated":"2017-02-25 06:03:40.000000000","message":"NIT: according to https://www.w3.org/Protocols/rfc1341/4_Content-Type.html the each content type cannot contain spaces, so perhaps we could use here\n\nctype.lower().replace(\" \", \"\")","commit_id":"d1db0c73632dad2e15e73e83aa27141dcc9753d4"}]}