)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"72150f4407c4bd5b0a043a1f65985930045a497f","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                         % port_map)"},{"line_number":822,"context_line":"        return port_map[0]"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def _get_network_by_name(self, network_name):"},{"line_number":825,"context_line":"        net \u003d self.admin_manager.networks_client.list_networks("},{"line_number":826,"context_line":"            name\u003dnetwork_name)[\u0027networks\u0027]"},{"line_number":827,"context_line":"        self.assertNotEqual(len(net), 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7364d421","line":824,"range":{"start_line":824,"start_character":8,"end_line":824,"end_character":28},"updated":"2017-02-22 02:40:11.000000000","message":"This can be removed?","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85ef5465fae69c280501bc1847cb0b86f7d9b284","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                         % port_map)"},{"line_number":822,"context_line":"        return port_map[0]"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def _get_network_by_name(self, network_name):"},{"line_number":825,"context_line":"        net \u003d self.admin_manager.networks_client.list_networks("},{"line_number":826,"context_line":"            name\u003dnetwork_name)[\u0027networks\u0027]"},{"line_number":827,"context_line":"        self.assertNotEqual(len(net), 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7ec29935","line":824,"range":{"start_line":824,"start_character":8,"end_line":824,"end_character":28},"in_reply_to":"da36d5c6_7364d421","updated":"2017-02-23 15:12:02.000000000","message":"Yeah, my bad.","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"72150f4407c4bd5b0a043a1f65985930045a497f","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        except Exception as e:"},{"line_number":916,"context_line":"            LOG.exception(\u0027Tenant network connectivity check failed\u0027)"},{"line_number":917,"context_line":"            self._log_console_output(servers_for_debug)"},{"line_number":918,"context_line":"            if not isinstance(e, lib_exc.SSHTimeout):"},{"line_number":919,"context_line":"                LOG.debug(\u0027Network information on a devstack host\u0027)"},{"line_number":920,"context_line":"            raise"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def _check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_73193488","line":919,"range":{"start_line":918,"start_character":0,"end_line":919,"end_character":67},"updated":"2017-02-22 02:40:11.000000000","message":"Further more, I don\u0027t see the benefit of these lines(the message seems of no help), maybe they can be removed directly? :)","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85ef5465fae69c280501bc1847cb0b86f7d9b284","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        except Exception as e:"},{"line_number":916,"context_line":"            LOG.exception(\u0027Tenant network connectivity check failed\u0027)"},{"line_number":917,"context_line":"            self._log_console_output(servers_for_debug)"},{"line_number":918,"context_line":"            if not isinstance(e, lib_exc.SSHTimeout):"},{"line_number":919,"context_line":"                LOG.debug(\u0027Network information on a devstack host\u0027)"},{"line_number":920,"context_line":"            raise"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def _check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7ed9b921","line":919,"range":{"start_line":918,"start_character":0,"end_line":919,"end_character":67},"in_reply_to":"da36d5c6_73193488","updated":"2017-02-23 15:12:02.000000000","message":"Yeah, me neither but I\u0027ll leave it as is for now.","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"72150f4407c4bd5b0a043a1f65985930045a497f","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"                m \u003d \u0027fixed_network_name must be specified in config\u0027"},{"line_number":1181,"context_line":"                raise lib_exc.InvalidConfiguration(m)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"            net \u003d self.admin_manager.networks_client.list_networks("},{"line_number":1184,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027]"},{"line_number":1185,"context_line":"            self.assertNotEmpty("},{"line_number":1186,"context_line":"                net, \"Unable to get network by name: %s\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_76004202","line":1183,"range":{"start_line":1183,"start_character":12,"end_line":1183,"end_character":15},"updated":"2017-02-22 02:40:11.000000000","message":"better to name it as \"networks\"?","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"fd32b0d7fd4bcb195f665468c18038d85385c1cd","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"                m \u003d \u0027fixed_network_name must be specified in config\u0027"},{"line_number":1181,"context_line":"                raise lib_exc.InvalidConfiguration(m)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"            net \u003d self.admin_manager.networks_client.list_networks("},{"line_number":1184,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027]"},{"line_number":1185,"context_line":"            self.assertNotEmpty("},{"line_number":1186,"context_line":"                net, \"Unable to get network by name: %s\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_9bf75f58","line":1183,"range":{"start_line":1183,"start_character":12,"end_line":1183,"end_character":15},"in_reply_to":"da36d5c6_76004202","updated":"2017-02-23 14:57:53.000000000","message":"You replaced this but forgot to remove the corresponding helper?","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85ef5465fae69c280501bc1847cb0b86f7d9b284","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"                m \u003d \u0027fixed_network_name must be specified in config\u0027"},{"line_number":1181,"context_line":"                raise lib_exc.InvalidConfiguration(m)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"            net \u003d self.admin_manager.networks_client.list_networks("},{"line_number":1184,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027]"},{"line_number":1185,"context_line":"            self.assertNotEmpty("},{"line_number":1186,"context_line":"                net, \"Unable to get network by name: %s\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_de0aa589","line":1183,"range":{"start_line":1183,"start_character":12,"end_line":1183,"end_character":15},"in_reply_to":"da36d5c6_9bf75f58","updated":"2017-02-23 15:12:02.000000000","message":"Will do.","commit_id":"e4285aca6efe61c57adb31dd3f4c3c2084ff651a"}]}