)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8da0859735d9f53d6438876bff531dd2859535e8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":153,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":154,"context_line":"        security_groups \u003d ["},{"line_number":155,"context_line":"            {\u0027name\u0027: self._create_security_group()[\u0027name\u0027]}"},{"line_number":156,"context_line":"        ]"},{"line_number":157,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":158,"context_line":"        if port_id is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_d3e10000","line":155,"range":{"start_line":155,"start_character":26,"end_line":155,"end_character":48},"updated":"2017-02-22 01:53:04.000000000","message":"Jordan, everytime _create_server is called, a new security group is created, while in the old code, security group is created only once.\nare you sure to do this?","commit_id":"887ce2025fc715e1a1c69a6618125d9cf3f0cb9e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"56239f6286b4c5f317adf093ae45643abfabb65b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":153,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":154,"context_line":"        security_groups \u003d ["},{"line_number":155,"context_line":"            {\u0027name\u0027: self._create_security_group()[\u0027name\u0027]}"},{"line_number":156,"context_line":"        ]"},{"line_number":157,"context_line":"        network \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":158,"context_line":"        if port_id is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_feda094a","line":155,"range":{"start_line":155,"start_character":26,"end_line":155,"end_character":48},"in_reply_to":"da36d5c6_d3e10000","updated":"2017-02-23 15:08:00.000000000","message":"Yeah, I think it\u0027s better this way. Sharing security groups between servers could have some side effects like, for instance if the default secgroup rules allow ports with the same secgroup to communicate. Starting with fresh, new security groups for each server gives us better control. This way we don\u0027t have to think about \"hey, this sec group is shared between these 3 servers, so if I add a rule, it has an impact on 3 servers\".\n\nBut that\u0027s a good point, I didn\u0027t think of it, but now that I thought about it, I prefer we do it this way.","commit_id":"887ce2025fc715e1a1c69a6618125d9cf3f0cb9e"}],"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"241035780dc05979bdd110dedeebda20d62b1f86","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def prepare_server(self, networks\u003dNone):"},{"line_number":122,"context_line":"        username \u003d CONF.validation.image_ssh_user"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        networks \u003d networks"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        srv \u003d self.create_server("},{"line_number":127,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_fe37644a","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":27},"updated":"2017-02-23 16:36:22.000000000","message":"This does nothing as it\u0027s a tautology.","commit_id":"887ce2025fc715e1a1c69a6618125d9cf3f0cb9e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9d5ae01c7a98e994ca8f5622b1f5b0e85a86546a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def prepare_server(self, networks\u003dNone):"},{"line_number":122,"context_line":"        username \u003d CONF.validation.image_ssh_user"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        networks \u003d networks"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        srv \u003d self.create_server("},{"line_number":127,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_260a988a","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":27},"in_reply_to":"da36d5c6_fe37644a","updated":"2017-02-25 13:13:49.000000000","message":"lol yeah, good catch.","commit_id":"887ce2025fc715e1a1c69a6618125d9cf3f0cb9e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a4b01ea1f5f951d042573761b4f66901eb37603e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    ips[\u00274\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":119,"context_line":"        return ips"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def prepare_server(self, networks\u003dNone):"},{"line_number":122,"context_line":"        username \u003d CONF.validation.image_ssh_user"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        srv \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_7e301c02","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":42},"updated":"2017-03-16 10:41:38.000000000","message":"we should remove default value also.","commit_id":"37b94a05a1fa2e15242f8c494720e8f4dac009c4"}]}