)]}'
{"tempest/api/volume/admin/v2/test_snapshot_manage.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f6725ef7cc721e4a39e18155eb86cb312177c00c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return new_snapshot"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u00270132f42d-0147-4b45-8501-cc504bbf7810\u0027)"},{"line_number":47,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.manage_snapshot,"},{"line_number":48,"context_line":"                          \"Manage snapshot tests are disabled\")"},{"line_number":49,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":50,"context_line":"        # Create a volume"},{"line_number":51,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_33af85e3","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":63},"updated":"2017-02-23 08:51:58.000000000","message":"seems all testcases in this file will skip if manage_snapshot is not supported, so better to use skip_checks","commit_id":"ce5d44a72431936815528fd73645f5ebce215719"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b667cd3f1a700785a7ca3bd5d68007cd153b5dc3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return new_snapshot"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u00270132f42d-0147-4b45-8501-cc504bbf7810\u0027)"},{"line_number":47,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.manage_snapshot,"},{"line_number":48,"context_line":"                          \"Manage snapshot tests are disabled\")"},{"line_number":49,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":50,"context_line":"        # Create a volume"},{"line_number":51,"context_line":"        volume \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_d70fe336","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":63},"in_reply_to":"da36d5c6_33af85e3","updated":"2017-02-23 17:59:47.000000000","message":"Right thanks","commit_id":"ce5d44a72431936815528fd73645f5ebce215719"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f6725ef7cc721e4a39e18155eb86cb312177c00c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Detach the volume"},{"line_number":106,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":108,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_73badd0b","line":106,"updated":"2017-02-23 08:51:58.000000000","message":"does it need to check whether volume status is still in-use? i.e., not affected by the unmanage of snapshot","commit_id":"ce5d44a72431936815528fd73645f5ebce215719"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f6524a616737ac1f08b9ff08da6fedced78933ae","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.addCleanup(self.manage_snapshot, volume[\u0027id\u0027], snapshot[\u0027id\u0027])"},{"line_number":103,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Detach the volume"},{"line_number":106,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":108,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_2abe7cb3","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":74},"updated":"2017-03-29 08:21:15.000000000","message":"if we use base.attach_volume, can we omit these steps?","commit_id":"ec0fb4bbda7b4a8f60f3cb510777e8b4e95239f0"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a61ebbc6d5e62ed79d6f4ce5851a6df595f80a5f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.addCleanup(self.manage_snapshot, volume[\u0027id\u0027], snapshot[\u0027id\u0027])"},{"line_number":103,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Detach the volume"},{"line_number":106,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":108,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_98b95f7a","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":74},"in_reply_to":"ffe62b97_2abe7cb3","updated":"2017-03-29 10:11:15.000000000","message":"If I\u0027ll use base.attach_volume, the order of addCleanup won\u0027t be correct and the test will fail.\nIn order to manage the snapshot(L102) the volume should be detached first.","commit_id":"ec0fb4bbda7b4a8f60f3cb510777e8b4e95239f0"}]}