)]}'
{"tempest/scenario/test_server_advanced_ops.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"98e116d22a97050b7f3af210b19ac556ba79593d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @testtools.skipUnless(CONF.compute.flavor_ref !\u003d"},{"line_number":48,"context_line":"                          CONF.compute.flavor_ref_alt"},{"line_number":49,"context_line":"                          and CONF.compute.flavor_ref_alt !\u003d \"\","},{"line_number":50,"context_line":"                          \u0027The flavor_ref_alt option must be properly set.\u0027)"},{"line_number":51,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":52,"context_line":"    def test_resize_volume_backed_server_confirm(self):"},{"line_number":53,"context_line":"        # We create an instance for use in this test"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_542ff6f5","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":74},"updated":"2017-02-28 09:16:38.000000000","message":"current error msg hard to debug. can you keep it same: \"flavor_ref and flavor_ref_alt are identical\"","commit_id":"054672c9bc5ed296525bb1f7d6a7271b36645c1a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"42f4eee3a1d437b2f38217a4cf7836415f76eecf","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @testtools.skipUnless(CONF.compute.flavor_ref !\u003d"},{"line_number":48,"context_line":"                          CONF.compute.flavor_ref_alt"},{"line_number":49,"context_line":"                          and CONF.compute.flavor_ref_alt !\u003d \"\","},{"line_number":50,"context_line":"                          \u0027The flavor_ref_alt option must be properly set.\u0027)"},{"line_number":51,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":52,"context_line":"    def test_resize_volume_backed_server_confirm(self):"},{"line_number":53,"context_line":"        # We create an instance for use in this test"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_9fcee7b2","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":74},"in_reply_to":"da36d5c6_542ff6f5","updated":"2017-02-28 09:28:16.000000000","message":"Thanks Ghanshyam, yes, the error msg is of not so much help.\nSince flavor_ref_alt should not be identical with flavor_ref and meanwhile should not be empty, \nso I just put these two situations in the error message","commit_id":"054672c9bc5ed296525bb1f7d6a7271b36645c1a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9200742133d800c6596a17473953fbef6173beea","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":71,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":72,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":73,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":74,"context_line":"        # We create an instance for use in this test"},{"line_number":75,"context_line":"        instance \u003d self.create_server()"},{"line_number":76,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_f9daa316","line":73,"updated":"2017-02-28 08:52:28.000000000","message":"So you are right that we shouldn\u0027t skip this test. But now that I think about it, this test is not a scenario and half of the test is already tested in test_suspend_resume_server() (in temepst/api/compute/). So what I suggest is to delete that scenario and edit test_suspend_resume_server so that it looks like this scenario.","commit_id":"054672c9bc5ed296525bb1f7d6a7271b36645c1a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"98e116d22a97050b7f3af210b19ac556ba79593d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":71,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":72,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":73,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":74,"context_line":"        # We create an instance for use in this test"},{"line_number":75,"context_line":"        instance \u003d self.create_server()"},{"line_number":76,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_b453d26b","line":73,"in_reply_to":"da36d5c6_94ceceb2","updated":"2017-02-28 09:16:38.000000000","message":"I am ok to have this in scenario as it try to do the sequence operation.","commit_id":"054672c9bc5ed296525bb1f7d6a7271b36645c1a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"72e44d92482ae63280c70b9194ddb6d25726dc48","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":71,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":72,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":73,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":74,"context_line":"        # We create an instance for use in this test"},{"line_number":75,"context_line":"        instance \u003d self.create_server()"},{"line_number":76,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_94ceceb2","line":73,"in_reply_to":"da36d5c6_f9daa316","updated":"2017-02-28 09:06:19.000000000","message":"Thanks Jordan,\n1) In API test, we usually only want to cover the interface(i.e., call it once), and in this scenario test, we call\nthe interfaces for two times. so, is it suitable to do this kind of repeated things in api test?\n\n2) as to this testcase, would you please look at my another patch? \nhttps://review.openstack.org/#/c/436842/","commit_id":"054672c9bc5ed296525bb1f7d6a7271b36645c1a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"88ac69332f94847eed070cf2a256b0f09ac50f7d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":72,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":73,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":74,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":75,"context_line":"        # We create an instance for use in this test"},{"line_number":76,"context_line":"        instance \u003d self.create_server()"},{"line_number":77,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_ae929a9d","line":74,"updated":"2017-02-28 10:13:12.000000000","message":"This is not a scenario, and I am not ok to enable it. This scenario was skipped in the Gate, the Gate is in a very bad state, our overall run time is way too long (more than 1 hour) so I don\"t want this to be enabled as is.","commit_id":"7531e9848d66918c4ea8507db0a79be6af2db248"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"507f9e07bba57ee2041de31fdd649897dbf8af01","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":72,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":73,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":74,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":75,"context_line":"        # We create an instance for use in this test"},{"line_number":76,"context_line":"        instance \u003d self.create_server()"},{"line_number":77,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_cbbf975e","line":74,"in_reply_to":"ba2be162_471d8c72","updated":"2017-03-02 01:38:39.000000000","message":"I agree with Jordan here. Let\u0027s not enable this as of now due to bad gate situation.\nWe will come up with generic solution to scenario testing soon.","commit_id":"7531e9848d66918c4ea8507db0a79be6af2db248"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53c9624f36e1a7d13edc38abfe3fa290a77d2026","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":72,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":73,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":74,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":75,"context_line":"        # We create an instance for use in this test"},{"line_number":76,"context_line":"        instance \u003d self.create_server()"},{"line_number":77,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_fd7c1674","line":74,"in_reply_to":"ba2be162_cbbf975e","updated":"2017-03-02 06:04:30.000000000","message":"sorry for confusion. this tests was not disabled on gate. it run on gate before this patch also. - http://logs.openstack.org/66/439866/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/33b187d/logs/testr_results.html.gz\n\nAnd about removal of this from scenario is different things(I ll check what all scenario tests which are not actually scenario can be removed). so i am ok with this patch which does not expand tests on gate.","commit_id":"7531e9848d66918c4ea8507db0a79be6af2db248"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"99ede7cfa91514b5697cf62fe84a877db1995fd6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.suspend,"},{"line_number":72,"context_line":"                          \u0027Suspend is not available.\u0027)"},{"line_number":73,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":74,"context_line":"    def test_server_sequence_suspend_resume(self):"},{"line_number":75,"context_line":"        # We create an instance for use in this test"},{"line_number":76,"context_line":"        instance \u003d self.create_server()"},{"line_number":77,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_471d8c72","line":74,"in_reply_to":"da36d5c6_ae929a9d","updated":"2017-03-01 05:26:15.000000000","message":"I understand your feeling:)\nI am also in favor of removing something than to adding something, and I only just don\u0027t want this testcase is skipped by a wrong usuage of skip_checks.\nI think we can remove this testcase in a more grace way","commit_id":"7531e9848d66918c4ea8507db0a79be6af2db248"}]}