)]}'
{"tempest/common/custom_matchers.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"848158c210ce16d1537659d026bac6c8bbcbbffd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def is_NonExistentHeader(self, headers, actual):"},{"line_number":49,"context_line":"        for i in headers:"},{"line_number":50,"context_line":"            if i not in actual:"},{"line_number":51,"context_line":"                return i"},{"line_number":52,"context_line":"        return False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def match(self, actual):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_d4b878ca","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":24},"updated":"2017-02-27 04:10:26.000000000","message":"how about \"return NonExistentHeader(i)\" ?","commit_id":"2e725196c09a02482d0450a1a378da83c8b0a702"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"848158c210ce16d1537659d026bac6c8bbcbbffd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            return NonExistentHeader(\u0027content-length\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        headers \u003d [\u0027content-type\u0027, \u0027x-trans-id\u0027, \u0027date\u0027]"},{"line_number":75,"context_line":"        if self.is_NonExistentHeader(headers, actual):"},{"line_number":76,"context_line":"            return NonExistentHeader("},{"line_number":77,"context_line":"                self.is_NonExistentHeader(headers, actual))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Check headers for a specific method or target"},{"line_number":80,"context_line":"        if self.method \u003d\u003d \u0027GET\u0027 or self.method \u003d\u003d \u0027HEAD\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_74c8ac55","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":59},"updated":"2017-02-27 04:10:26.000000000","message":"how about:\n    nonexistant_header \u003d self.is_NonExistentHeader(headers, actual)\n        if nonexistant_header:\n            return nonexistant_header","commit_id":"2e725196c09a02482d0450a1a378da83c8b0a702"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"926ceb60d5f053e55c1ff1ad140153ca167d347e","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_NonExistentHeader(self, headers, actual):"},{"line_number":49,"context_line":"        for h in headers:"},{"line_number":50,"context_line":"            if h not in actual:"},{"line_number":51,"context_line":"                return NonExistentHeader(h)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_9349828e","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":28},"updated":"2017-03-01 08:06:47.000000000","message":"pls refer to https://www.python.org/dev/peps/pep-0008/#function-names for the function naming","commit_id":"09a14c30c6edde477874ad42bfa619b566c76b41"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1b16400aa2e230ec23aac9e3582c20828af10f3a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                    return nonexistant_header"},{"line_number":160,"context_line":"        elif self.method \u003d\u003d \u0027PUT\u0027:"},{"line_number":161,"context_line":"            if self.target \u003d\u003d \u0027Object\u0027:"},{"line_number":162,"context_line":"                headers \u003d [\u0027etag\u0027, \u0027last-modified\u0027]"},{"line_number":163,"context_line":"                nonexistant_header \u003d self.is_nonexistent_header("},{"line_number":164,"context_line":"                    headers, actual)"},{"line_number":165,"context_line":"                if nonexistant_header:"},{"line_number":166,"context_line":"                    return nonexistant_header"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        elif self.method \u003d\u003d \u0027COPY\u0027:"},{"line_number":169,"context_line":"            if self.target \u003d\u003d \u0027Object\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_cf4cda72","line":166,"range":{"start_line":162,"start_character":0,"end_line":166,"end_character":45},"updated":"2017-03-21 06:20:28.000000000","message":"how about not using a helper, i.e.,\n    for header in [\u0027etag\u0027, \u0027last-modified\u0027]:\n        if header not in actual:\n            return NonExistentHeader(header)","commit_id":"94780db4da3fe69bea1200eb46a4bdedfcd51761"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6e80e45c457a5c2054597cb6abff73061308f6c9","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _check_account_target(self, actual):"},{"line_number":49,"context_line":"        for header in [\u0027x-account-bytes-used\u0027,"},{"line_number":50,"context_line":"                       \u0027x-account-container-count\u0027,"},{"line_number":51,"context_line":"                       \u0027x-account-object-count\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_6387c8d9","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":29},"updated":"2017-03-31 06:36:06.000000000","message":"to add these helpers will reduce the readabilty, so I will suggest just simply putting keys in a list, something like:\n    for header in [\u0027etag\u0027, \u0027last-modified\u0027]:\n        if header not in actual:\n            return NonExistentHeader(header)","commit_id":"953eb16ff4ab4f7a58ac967406aa0af6f5f8dc5e"}]}