)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cb1de6d0180d6d94ecff2b32da7abe8d860f83d6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Each resource service clients should be in separate file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit separate the transfer service client from volumes client"},{"line_number":16,"context_line":"and deprecate the same from volumes service client."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia85bcfbadbff4f7c594dc5631ecdd595c5d275f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bff0334d_e27d066f","line":15,"updated":"2017-04-06 06:05:21.000000000","message":"nit: separates","commit_id":"59614b445c526ed805067ad786753f907e3691cf"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cb1de6d0180d6d94ecff2b32da7abe8d860f83d6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Each resource service clients should be in separate file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit separate the transfer service client from volumes client"},{"line_number":16,"context_line":"and deprecate the same from volumes service client."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia85bcfbadbff4f7c594dc5631ecdd595c5d275f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bff0334d_c2820250","line":16,"updated":"2017-04-06 06:05:21.000000000","message":"nit: deprecates","commit_id":"59614b445c526ed805067ad786753f907e3691cf"}],"releasenotes/notes/volume-transfers-client-e5ed3f5464c0cdc0.yaml":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"591ea6d3a632460bf37f0adc485ecc0104cff948","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    * transfers_client(v2)"},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Deprecate volume v2 transfers resource methods from volumes_client(v2) libraries. Same methods are available in new transfers service client: transfers_client(v2)"},{"line_number":12,"context_line":"    The following methods of volume v2 volumes_clients have been deprecated:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    * create_volume_transfer (v2.volumes_client)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da36d5c6_9448c0cd","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":74},"updated":"2017-02-27 06:15:25.000000000","message":"This line seems too long","commit_id":"417d950c3c14e66dda474e8929e891d8702d5e11"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1f003bf4a125fb6ccd23024586835a9c6111acb8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Define volume transfers service clients as libraries."},{"line_number":5,"context_line":"    The following volume transfers service clients are defined as library interface."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * transfers_client(v2)"},{"line_number":8,"context_line":"    * transfers_client(v2)"},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_cffe0305","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":6},"updated":"2017-03-17 05:43:00.000000000","message":"We should use - instead of * here, otherwise we will need some patches like https://review.openstack.org/#/c/445605/","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7d8e7c067c848305a1d97d638ff994e456f95d69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Define volume transfers service clients as libraries."},{"line_number":5,"context_line":"    The following volume transfers service clients are defined as library interface."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * transfers_client(v2)"},{"line_number":8,"context_line":"    * transfers_client(v2)"},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_debb120d","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":6},"in_reply_to":"1a1ced50_9e3efab6","updated":"2017-03-17 07:32:15.000000000","message":"i think this is fine as in release notes. in that patch you had * in wrong indentation","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f5fb24b297a3e9e8c5b962f383b372663b42e3ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Define volume transfers service clients as libraries."},{"line_number":5,"context_line":"    The following volume transfers service clients are defined as library interface."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * transfers_client(v2)"},{"line_number":8,"context_line":"    * transfers_client(v2)"},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_9e3efab6","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":6},"in_reply_to":"1a1ced50_cffe0305","updated":"2017-03-17 07:28:10.000000000","message":"opps, thanks. you avoided rework.","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7d8e7c067c848305a1d97d638ff994e456f95d69","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The following volume transfers service clients are defined as library interface."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * transfers_client(v2)"},{"line_number":8,"context_line":"    * transfers_client(v2)"},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Deprecate volume v2 transfers resource methods from volumes_client(v2) libraries."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_1e3cca92","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":26},"updated":"2017-03-17 07:32:15.000000000","message":"oh, duplicate.","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"}],"tempest/api/volume/test_volume_transfers.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"54463ea8aea75ae0c0177c02f519c5d089c427ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def _setup_transfers_clients(cls):"},{"line_number":29,"context_line":"        cls.client \u003d cls.os.volume_transfers_v2_client"},{"line_number":30,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_v2_client"},{"line_number":31,"context_line":"        cls.adm_client \u003d cls.os_adm.volume_transfers_v2_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_15eceef1","line":28,"updated":"2017-02-24 17:21:54.000000000","message":"Why don\u0027t you just override setup_clients() in VolumesV1TransfersTest. I mean, why this new method ?","commit_id":"417d950c3c14e66dda474e8929e891d8702d5e11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95cf7b7a9854bccf7c47b84a7f149627df8a3ad7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def _setup_transfers_clients(cls):"},{"line_number":29,"context_line":"        cls.client \u003d cls.os.volume_transfers_v2_client"},{"line_number":30,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_v2_client"},{"line_number":31,"context_line":"        cls.adm_client \u003d cls.os_adm.volume_transfers_v2_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_abec83bb","line":28,"in_reply_to":"da36d5c6_15eceef1","updated":"2017-03-16 03:00:41.000000000","message":"yea that\u0027s the first attempt but that would not work as VolumesV1TransfersTest is derived from this clas and super call base class method also which end up with requirement of volume_transfers_v2_client for v1 also.","commit_id":"417d950c3c14e66dda474e8929e891d8702d5e11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7aa4f6ebfb5163a89ce9c47e5bf4e3b56a99c1cb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(VolumesV2TransfersTest, cls).setup_clients()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        cls.client \u003d cls.volumes_client"},{"line_number":32,"context_line":"        cls.alt_client \u003d cls.os_alt.volumes_client"},{"line_number":33,"context_line":"        cls.adm_client \u003d cls.os_adm.volumes_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00274d75b645-a478-48b1-97c8-503f64242f1a\u0027)"},{"line_number":36,"context_line":"    def test_create_get_list_accept_volume_transfer(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_72e3f633","side":"PARENT","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":50},"updated":"2017-03-16 07:05:20.000000000","message":"these are wrong, v2 tests also making call on v1 APIs","commit_id":"82a278e88c9e9f9ba49f81c1f8dba0bca7943daf"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b56334889bf87e42b20dc1b135a8ed9365bfc456","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        cls.client \u003d cls.os.volume_transfers_v2_client"},{"line_number":32,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_v2_client"},{"line_number":33,"context_line":"        cls.adm_client \u003d cls.os_adm.volume_transfers_v2_client"},{"line_number":34,"context_line":"        cls.alt_volumes_client \u003d cls.os_alt.volumes_v2_client"},{"line_number":35,"context_line":"        cls.adm_volumes_client \u003d cls.os_adm.volumes_v2_client"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_76525a3d","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":22},"updated":"2017-04-05 07:53:09.000000000","message":"this is not used","commit_id":"b4de1b9559d3a66882551a93191491520f93e6c2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e6bf7d5116b8cf2ff6893032416e877d2f207094","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setup_clients(cls):"},{"line_number":29,"context_line":"        super(VolumesTransfersTest, cls).setup_clients()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        cls.client \u003d cls.os.volume_transfers_v2_client"},{"line_number":32,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_v2_client"},{"line_number":33,"context_line":"        cls.alt_volumes_client \u003d cls.os_alt.volumes_v2_client"},{"line_number":34,"context_line":"        cls.adm_volumes_client \u003d cls.os_adm.volumes_v2_client"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8871c2e3","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":18},"updated":"2017-04-06 01:48:04.000000000","message":"will transfers_client more readable?","commit_id":"59614b445c526ed805067ad786753f907e3691cf"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e6bf7d5116b8cf2ff6893032416e877d2f207094","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(VolumesTransfersTest, cls).setup_clients()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        cls.client \u003d cls.os.volume_transfers_v2_client"},{"line_number":32,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_v2_client"},{"line_number":33,"context_line":"        cls.alt_volumes_client \u003d cls.os_alt.volumes_v2_client"},{"line_number":34,"context_line":"        cls.adm_volumes_client \u003d cls.os_adm.volumes_v2_client"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_68767edb","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":22},"updated":"2017-04-06 01:48:04.000000000","message":"will alt_transfers_client more readable?","commit_id":"59614b445c526ed805067ad786753f907e3691cf"}],"tempest/lib/services/volume/v2/transfers_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1f003bf4a125fb6ccd23024586835a9c6111acb8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib.common import rest_client"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TransfersClient(rest_client.RestClient):"},{"line_number":23,"context_line":"    \"\"\"Client class to send CRUD Volume Transfer V2 API requests\"\"\""},{"line_number":24,"context_line":"    api_version \u003d \"v2\""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_af1aa76c","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":21},"updated":"2017-03-17 05:43:00.000000000","message":"Resource name is os-volume-transfer, so VolumeTransferClient would be better. The module name also.","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f5fb24b297a3e9e8c5b962f383b372663b42e3ed","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib.common import rest_client"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TransfersClient(rest_client.RestClient):"},{"line_number":23,"context_line":"    \"\"\"Client class to send CRUD Volume Transfer V2 API requests\"\"\""},{"line_number":24,"context_line":"    api_version \u003d \"v2\""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_fe252eae","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":21},"in_reply_to":"1a1ced50_af1aa76c","updated":"2017-03-17 07:28:10.000000000","message":"actually it is under volume folder and same we have all other clients.\n\nhonestly i like to have Volume in name but we need to have consistent name like other volume service clients and we cannot change other client name","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1f003bf4a125fb6ccd23024586835a9c6111acb8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TransfersClient(rest_client.RestClient):"},{"line_number":23,"context_line":"    \"\"\"Client class to send CRUD Volume Transfer V2 API requests\"\"\""},{"line_number":24,"context_line":"    api_version \u003d \"v2\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def create_volume_transfer(self, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"Create a volume transfer."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_ef2adf7d","line":24,"range":{"start_line":24,"start_character":3,"end_line":24,"end_character":22},"updated":"2017-03-17 05:43:00.000000000","message":"Cinder V2 API is deprecated, it is better to implement this as v3  client.","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f5fb24b297a3e9e8c5b962f383b372663b42e3ed","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TransfersClient(rest_client.RestClient):"},{"line_number":23,"context_line":"    \"\"\"Client class to send CRUD Volume Transfer V2 API requests\"\"\""},{"line_number":24,"context_line":"    api_version \u003d \"v2\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def create_volume_transfer(self, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"Create a volume transfer."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_7e413e39","line":24,"range":{"start_line":24,"start_character":3,"end_line":24,"end_character":22},"in_reply_to":"1a1ced50_ef2adf7d","updated":"2017-03-17 07:28:10.000000000","message":"i think we define new client for v3 and will move all v2 clients later to v3.\n\nThis is moved client from v2 actually so i hesitate to make it v3 as it used to tests v2 tests.\n\nOnce we conclude the API version testing then we can change everywhere.\nis it fine ?","commit_id":"a189aec5d29e51994e1a73733e4abf27e96791e1"}],"tempest/lib/services/volume/v2/volumes_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"54463ea8aea75ae0c0177c02f519c5d089c427ce","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @removals.remove(message\u003d\"use create_volume_transfer from tempest.lib.\""},{"line_number":187,"context_line":"                             \"services.volume.v2.transfers_client\")"},{"line_number":188,"context_line":"    def create_volume_transfer(self, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_9528de34","line":188,"updated":"2017-02-24 17:21:54.000000000","message":"I think you should use something like this:\nhttps://github.com/openstack/tempest/blob/master/tempest/test.py#L653 i.e: @debtcollector.moves.moved_method","commit_id":"417d950c3c14e66dda474e8929e891d8702d5e11"}]}