)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5eeebad6f43cf90c5bda41f4b71c092f6fb60294","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    body \u003d clients.servers_client.create_server(name\u003dname, imageRef\u003dimage_id,"},{"line_number":144,"context_line":"                                                flavorRef\u003dflavor,"},{"line_number":145,"context_line":"                                                **kwargs)"},{"line_number":146,"context_line":"    if validatable:"},{"line_number":147,"context_line":"        body \u003d clients.servers_client.show_server(body[\u0027server\u0027][\u0027id\u0027])"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    # handle the case of multiple servers"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_9987e7d6","line":146,"updated":"2017-02-28 08:58:38.000000000","message":"A code comment would help here. \n\nAlso this won\u0027t work for sure because at that time, you have no guarantee that the server is ACTIVE (the wait is done line 167) so you have no guarantee that your server has an IP address.\n\nI think you should move these 2 lines at the end of this method but inside the \"wait_until\" block.","commit_id":"bd626f10d017e15449c7e47b711e3c632fad2876"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05235cf28689308313ed5435d72b8b3d68737bd6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":173,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"                if validatable:"},{"line_number":176,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":177,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":178,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":179,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_53638ab1","line":179,"range":{"start_line":175,"start_character":0,"end_line":179,"end_character":51},"updated":"2017-03-01 07:47:42.000000000","message":"Do we really need ?\n\nthere are few issues here. \n1. in case of multiple server request, it call show for every server redundantly. \n2. if wait_until is not ACTIVE then what is point of doing show.\n\nI will suggest to keep this as it is and do not make this helper with too much responsibility. This should just create server and populate validated param and let\u0027s tests do what they want refresh the info etc.","commit_id":"ac6a97fb532027ca142a68cc59d9fd0b0741db85"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4665ed023bbfdfbbb4d8eaf12a92de9fe097ca06","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":173,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"                if validatable:"},{"line_number":176,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":177,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":178,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":179,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_3c825b95","line":179,"range":{"start_line":175,"start_character":0,"end_line":179,"end_character":51},"in_reply_to":"ba2be162_33ee168c","updated":"2017-03-01 12:53:08.000000000","message":"2. validate\u003dTrue is used 12 times, and each and every time (except in test_device_tagging, and that looks like a bug) with/alongside wait_until\u003dACTIVE\n\nAlso, have a look at line 114.","commit_id":"ac6a97fb532027ca142a68cc59d9fd0b0741db85"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45afbc4f3f5d5447e2ee4ced32acdb013760f33a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":173,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"                if validatable:"},{"line_number":176,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":177,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":178,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":179,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_a98c2880","line":179,"range":{"start_line":175,"start_character":0,"end_line":179,"end_character":51},"in_reply_to":"ba2be162_3c825b95","updated":"2017-03-02 04:23:22.000000000","message":"I agree with current use case it might not be but as helper method we cannot make assumption. or do we say in doc string that validate true will be only when wait_until\u003dACTIVE or single server create request?","commit_id":"ac6a97fb532027ca142a68cc59d9fd0b0741db85"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9fb259770448a1462be4d2f8df6ff2a7ab7ff244","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":173,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"                if validatable:"},{"line_number":176,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":177,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":178,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":179,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_33ee168c","line":179,"range":{"start_line":175,"start_character":0,"end_line":179,"end_character":51},"in_reply_to":"ba2be162_53638ab1","updated":"2017-03-01 08:02:57.000000000","message":"Thanks Ghanshyam,\n1. multiple server request now don\u0027t support validate\u003dTrue\n2. usually validate\u003dTrue is accompanied by wait_until\u003dACTIVE\n\nso, usually we don\u0027t need extra show_server after create_test_server, except when \u0027addresses\u0027 is needed.\nto add this is just to avoid the extra show_server everytime we need \u0027addresses\u0027.","commit_id":"ac6a97fb532027ca142a68cc59d9fd0b0741db85"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4bec9e31399a2fa27d5e169931467715a1ea31c8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":173,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"                if validatable:"},{"line_number":176,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":177,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":178,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":179,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_2ee64046","line":179,"range":{"start_line":175,"start_character":0,"end_line":179,"end_character":51},"in_reply_to":"ba2be162_62cde55c","updated":"2017-03-31 09:39:12.000000000","message":"well i am still not convinced on this whether we really need to do this in common helper.\n\nvalidation on multi severs is just not done at first step and this code make that difficult to do so. \n\nrefreshing the server on tests side based on their need is right thing for me.","commit_id":"ac6a97fb532027ca142a68cc59d9fd0b0741db85"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d44103b195b514ffb072c6b025c1bf3da261c23b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":173,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"                if validatable:"},{"line_number":176,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":177,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":178,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":179,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            except Exception:"},{"line_number":182,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_62cde55c","line":179,"range":{"start_line":175,"start_character":0,"end_line":179,"end_character":51},"in_reply_to":"ba2be162_a98c2880","updated":"2017-03-02 05:42:55.000000000","message":"1) #L89 is the code comment for not supporting multi create\n2) if someone would call it with validate\u003dTrue and without wait_until\u003dACTIVE, then he must not want to access \u0027addresses\u0027,\n   so, though the situation is somehow strange, it will be of no problem.","commit_id":"ac6a97fb532027ca142a68cc59d9fd0b0741db85"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0dece8348db68b6c365f49cf8107a1025a87652f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                              \u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":196,"context_line":"                              server_id\u003dservers[0][\u0027id\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"                if validatable:"},{"line_number":199,"context_line":"                    # if validatable is True, call show_server to make"},{"line_number":200,"context_line":"                    # \u0027addresses\u0027 present in server info"},{"line_number":201,"context_line":"                    body \u003d clients.servers_client.show_server("},{"line_number":202,"context_line":"                        servers[0][\u0027id\u0027])[\u0027server\u0027]"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            except Exception:"},{"line_number":205,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_becb9ca3","line":202,"range":{"start_line":198,"start_character":0,"end_line":202,"end_character":51},"updated":"2017-05-30 08:42:37.000000000","message":"same point as previous PS.\n\nAdditional points\n- This common methods end up returning 2 different set of return values with validatable true/false as response from nova POST and GET is different. \n\n- nova has configurable VM states for which server address will be hidden which can be more than just \u0027BUILDING\u0027. (Though I need to push nova spec to deprecate those but that\u0027s next release things)","commit_id":"b78216d12fa36e6a60391f825445260e0f2855c0"}]}