)]}'
{"tempest/lib/common/network_checker.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fbbe1c162b4bd568280e98117833d7a4e4ebfa97","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 NEC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_5588d9e7","line":1,"updated":"2017-03-01 02:11:38.000000000","message":"i suspect moving code should not change copyright owner.","commit_id":"b32c50eb78ab95406691382b881197388b3b989b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ecdbee88265551dd834f8b4ab40d94f5b70c5d18","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                              timeout\u003d120):"},{"line_number":27,"context_line":"    \"\"\"Check ping server via source ssh connection"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    :param source: RemoteClient: an ssh connection from which to ping"},{"line_number":30,"context_line":"    :param dest: IP to ping against"},{"line_number":31,"context_line":"    :param should_succeed: boolean should ping succeed or not"},{"line_number":32,"context_line":"    :param nic: Specific network interface to ping from (eth0, etc.)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_90f6dfd5","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":31},"updated":"2017-03-01 02:28:28.000000000","message":"RemoteClient is not a stable interface, is it?","commit_id":"41a0004ecde56a2f2641fc9ddbd0693ad425e55e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ae067a83c173faa56a92a02d23231f2d8c51ad32","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    assert result is True, msg"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_1556d35b","line":68,"updated":"2017-03-10 07:43:10.000000000","message":"I think this is not equal to assertTrue(). And I\u0027m actually not sure that we really need this \u0027assert_remote_connectivity\u0027 function. This is almost same as check_remote_connectivity().","commit_id":"4bbf7e507fd5c393512bd50c904e558581d5c66b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca85801300676d0505a5f9badb9ee658a6676215","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    assert result is True, msg"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_143eba27","line":68,"in_reply_to":"9a30ddce_1556d35b","updated":"2017-03-10 18:20:08.000000000","message":"Yeah I can see your point, but yamamoto much prefer to implement this method for reducing the duplicated code in the other projects like neutron-xxxx","commit_id":"4bbf7e507fd5c393512bd50c904e558581d5c66b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"733475acdae7325d81a51c5670783559c04a0555","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return not should_succeed"},{"line_number":44,"context_line":"        return should_succeed"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    return test_utils.call_until_true(ping_remote, timeout, 1)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def assert_remote_connectivity(source, dest, should_succeed\u003dTrue, nic\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a22e58a_3437fee4","line":46,"updated":"2017-03-14 08:11:38.000000000","message":"How about like this?\n\n    result \u003d test_utils.call_until_true(ping_remote, timeout, 1)\n    source_host \u003d source.ssh_client.host\n    if should_succeed:\n        msg \u003d \"Timed out waiting....\"\n    else:\n        msg \u003d \"%s is reachable ...\"\n\n    if not result:\n        raise SomeException(msg)\n\n    return result\n\nCan we remove assert_remote_connectivity() with this?","commit_id":"740470ad5df54a34dd3668612085b52f9f1089c7"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"733475acdae7325d81a51c5670783559c04a0555","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    assert result is True, msg"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a22e58a_54347add","line":68,"updated":"2017-03-14 08:11:38.000000000","message":"I still think using \u0027assert\u0027 is not good in tempest.lib because assert statements are removed when we run \u0027python -O\u0027. Yeah, I think too much, probably, though. How about rasing an exception instead at least if you really want this function?","commit_id":"740470ad5df54a34dd3668612085b52f9f1089c7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"711ba763680e0e13dea007d1eac77a227400a6ef","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    assert result is True, msg"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_cc725c49","line":68,"in_reply_to":"5a22e58a_54347add","updated":"2017-03-15 23:24:34.000000000","message":"OK, TBH I am not so big fun of this method.\nMaybe we can add this method later when we really want it.","commit_id":"740470ad5df54a34dd3668612085b52f9f1089c7"}]}