)]}'
{"id":"openstack%2Ftempest~439291","triplet_id":"openstack%2Ftempest~master~I941ec1e5e0f3c1ad8fb609de7ad7081ae9653967","project":"openstack/tempest","branch":"master","topic":"scneario","hashtags":[],"change_id":"I941ec1e5e0f3c1ad8fb609de7ad7081ae9653967","subject":"Keep scenario manager temporary copy for plugins","status":"ABANDONED","created":"2017-03-01 02:52:47.000000000","updated":"2017-04-04 06:36:20.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dcaee7d09a9dd42ae72f18f00d652ca4daf32789","_number":439291,"virtual_id_number":439291,"owner":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},{"date":"2017-03-01 05:16:11.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2017-03-01 04:19:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"date":"2017-03-08 05:18:50.000000000","_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"all":[{"value":-1,"date":"2017-03-01 12:52:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-03-01 12:29:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"date":"2017-03-02 06:45:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-1":"Release Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-01 04:19:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-03-01 05:16:11.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-03-01 12:29:39.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2017-03-01 12:52:55.000000000","updated_by":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"reviewer":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"state":"REVIEWER"},{"updated":"2017-03-02 06:45:08.000000000","updated_by":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"reviewer":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"state":"REVIEWER"}],"messages":[{"id":"ed56ba83dc4a27284e090d8151ff84769d750f01","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2017-03-01 02:52:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1170d6aa07d400b0d3aab1f29ed89fe766db2226","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2017-03-01 03:04:21.000000000","message":"Patch Set 1: Code-Review+1\n\nseems good solution","accounts_in_message":[],"_revision_number":1},{"id":"05271b2f0c3b083417b6ee5e542fd9b820469679","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-01 04:19:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/d53f3f6/ : SUCCESS in 1h 25m 41s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/1600940/ : SUCCESS in 54m 53s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/05f4e57/ : SUCCESS in 1h 18m 06s\n- gate-tempest-docs-ubuntu-xenial http://docs-draft.openstack.org/91/439291/1/check/gate-tempest-docs-ubuntu-xenial/7b0ef4e//doc/build/html/ : SUCCESS in 2m 07s\n- gate-tempest-pep8-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-pep8-ubuntu-xenial/464bfc7/ : SUCCESS in 2m 53s\n- gate-tempest-python27-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-python27-ubuntu-xenial/9bc0bf1/ : SUCCESS in 1m 07s\n- gate-tempest-python35 http://logs.openstack.org/91/439291/1/check/gate-tempest-python35/afe6f6d/ : SUCCESS in 1m 06s\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/f7cba0b/ : SUCCESS in 40m 36s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/9a0268c/ : SUCCESS in 39m 37s (non-voting)\n- gate-tempest-dsvm-neutron-full-ssh http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-full-ssh/57459a7/ : SUCCESS in 1h 08m 38s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/fca7ada/ : SUCCESS in 1h 10m 56s (non-voting)\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/212d08e/ : SUCCESS in 59m 13s (non-voting)\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7-nv http://logs.openstack.org/91/439291/1/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7-nv/411158a/ : FAILURE in 13s (non-voting)\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7-nv http://logs.openstack.org/91/439291/1/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7-nv/b530d68/ : SUCCESS in 34m 43s (non-voting)\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7-nv http://logs.openstack.org/91/439291/1/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7-nv/944fc3b/ : SUCCESS in 31m 08s (non-voting)\n- gate-puppet-openstack-integration-4-scenario004-tempest-centos-7-nv http://logs.openstack.org/91/439291/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7-nv/ae91ba3/ : SUCCESS in 25m 05s (non-voting)\n- gate-tempest-dsvm-layer4-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-layer4-ubuntu-xenial/fcaeb4d/ : SUCCESS in 25m 07s\n- gate-tempest-dsvm-neutron-dvr-ubuntu-xenial http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-dvr-ubuntu-xenial/42771d9/ : SUCCESS in 58m 39s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial-ocata http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-ocata/1bac2cf/ : SUCCESS in 1h 04m 09s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton/829ae4a/ : SUCCESS in 51m 01s\n- gate-tempest-dsvm-nnet-ubuntu-trusty-mitaka http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-nnet-ubuntu-trusty-mitaka/60aa429/ : SUCCESS in 34m 05s\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka http://logs.openstack.org/91/439291/1/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka/ef197d2/ : SUCCESS in 43m 09s","accounts_in_message":[],"_revision_number":1},{"id":"1837e93eb12df5eef55c936739b909be893f2a04","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2017-03-01 05:16:11.000000000","message":"Patch Set 1:\n\nBuild failed.  To recheck use \u0027xenserver: recheck\u0027.  For 3rd party ci contact info: https://wiki.openstack.org/wiki/ThirdPartySystems\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/91/439291/1/check/dsvm-tempest-neutron-network/688c5f9 : FAILURE in 2h 22m 58s","accounts_in_message":[],"_revision_number":1},{"id":"d6f10d7e6b8edacfb3f2fd209daeabb653d963cf","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2017-03-01 12:29:39.000000000","message":"Patch Set 1: Code-Review-1\n\nMore code, more maintenance, more problem.","accounts_in_message":[],"_revision_number":1},{"id":"4a4f2789b5e55d2a719dffe31f4385d7dcb07dde","author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"date":"2017-03-01 12:52:55.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t think this will work well, because we would be creating bit-rotting code in our tree (non tested) and let plugins depend on it, which I think it\u0027s worse than where they are now.\n\nBesides I think the most valuable bits for scenario tests are in test.py so while we may make some helpers a stable interface into lib eventually, I think that\u0027s a 2nd order priority.","accounts_in_message":[],"_revision_number":1},{"id":"cc7eb4d3571ff990e8ed4fbf22726680687fa000","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2017-03-02 06:45:08.000000000","message":"Patch Set 1: -Code-Review\n\nIf we want to make a stable scenario base for plugins to inherit from, I think this is an acceptable way.\n(The scenario base may include create_server, create_volume, create_server_snapshot and so on.)\nBut if we don\u0027t want to provide a common scenario base, i.e., the helpers may distribute in several files,\nthen this may be of no help.","accounts_in_message":[],"_revision_number":1},{"id":"b2ded00eedd8be7a6341e923e09f870ca02c92f3","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2017-03-08 05:18:50.000000000","message":"Patch Set 1:\n\nI agree it is not good way but i think it is still good option out of  others.\n\nHaving copy of scenario manager on all plugins end up difficult situation like -https://review.openstack.org/#/c/439950/6\n\nAny refactoring on interfaces used by scenario managers become difficult as plugin also has duplicate copy. \n\nEither we fix all duplicate copy first or we kind of avoid/postponed other interface refactoring. \nBy keeping copy on tempest side at least make it little bit easy.","accounts_in_message":[],"_revision_number":1},{"id":"d3f7ceb6f6f4c9c2646617536ae856189364b63f","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2017-04-04 06:36:20.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"966e9d1a876aa97d9cab14c54ca70c0f82c03873","revisions":{"966e9d1a876aa97d9cab14c54ca70c0f82c03873":{"kind":"REWORK","_number":1,"created":"2017-03-01 02:52:47.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/91/439291/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/91/439291/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/91/439291/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/91/439291/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/91/439291/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/91/439291/1"}}},"commit":{"parents":[{"commit":"d184d619d7adc6ab60055884515055a7f3cf7770","subject":"Merge \"Remove unnecessary show_server in TestServerAdvancedOps\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/d184d619d7adc6ab60055884515055a7f3cf7770"}]}],"author":{"name":"ghanshyam","email":"ghanshyammann@gmail.com","date":"2017-03-01 02:33:14.000000000","tz":0},"committer":{"name":"ghanshyam","email":"ghanshyammann@gmail.com","date":"2017-03-01 02:33:14.000000000","tz":0},"subject":"Keep scenario manager temporary copy for plugins","message":"Keep scenario manager temporary copy for plugins\n\nAs scenario manager class is mess and already under\nrefactoring, almost all the plugins use that class\nfor their scenario testing.\n\nRefactoring will defiantly impact their tests and waiting\nfor each plugins to fix their usage on every tempest refactor\npatch will leads to delay in works.\n\nThis commits propose to keep the current scenario manager\ntemporary copy in Tempest and work on new scenario base class\n(which is copy of scenario manager in tempest) to make\nit scenario tests in good shape.\n\nOnce Tempest will be done with refactoring and ready with stable\ninterface or helpers required for scenario testing, temporary\nscenario manager class will be removed with deprecation period.\n\nThis way gives benefits like:\n1. We can merge the Tempest refactoring work fast without\n   breaking any plugins.\n2. Plugins will switch to new helpers or stable interfaces in one shot\n   instead of keep changing their usage on every tempest refactor change.\n\nOther way is to ask each plugins to keep scenario managers local copy\nbut that needs changes in each plugins.\n\nref- http://lists.openstack.org/pipermail/openstack-dev/2017-February/112902.html\n\nChange-Id: I941ec1e5e0f3c1ad8fb609de7ad7081ae9653967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/966e9d1a876aa97d9cab14c54ca70c0f82c03873"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/966e9d1a876aa97d9cab14c54ca70c0f82c03873"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d184d619d7adc6ab60055884515055a7f3cf7770","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}