)]}'
{"tempest/api/compute/servers/test_list_server_filters.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cdf645be4356364a3d1ebf7b83b5a92620559a2c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        self.assertIn(ip_list[longest_ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":297,"context_line":"        del ip_list[longest_ip]"},{"line_number":298,"context_line":"        for ip in ip_list:"},{"line_number":299,"context_line":"            self.assertNotIn(ip_list[ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @decorators.skip_because(bug\u003d\"1540645\")"},{"line_number":302,"context_line":"    @decorators.idempotent_id(\u0027a905e287-c35e-42f2-b132-d02b09f3654a\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_56ea5510","line":299,"updated":"2017-03-02 11:02:07.000000000","message":"I would have rewritten the test to be sure that all the returned servers have an IP that starts (i.e prefix) with the given IP.\n\nNow we don\u0027t really test that there\u0027s a regex search going on in Nova-api.","commit_id":"7d8f7c5669f42178ae47aa1a6446eda42910a390"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5eac7fe2607d55ece025a49f12e3a2b36320e447","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        self.assertIn(ip_list[longest_ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":297,"context_line":"        del ip_list[longest_ip]"},{"line_number":298,"context_line":"        for ip in ip_list:"},{"line_number":299,"context_line":"            self.assertNotIn(ip_list[ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @decorators.skip_because(bug\u003d\"1540645\")"},{"line_number":302,"context_line":"    @decorators.idempotent_id(\u0027a905e287-c35e-42f2-b132-d02b09f3654a\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_f1e1162b","line":299,"in_reply_to":"ba2be162_3c46344f","updated":"2017-03-06 05:56:54.000000000","message":"I don\u0027t know why there were two testcases designed for this function.","commit_id":"7d8f7c5669f42178ae47aa1a6446eda42910a390"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f1a71ba86703c8787a11fb139f46af1855cf4be9","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        self.assertIn(ip_list[longest_ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":297,"context_line":"        del ip_list[longest_ip]"},{"line_number":298,"context_line":"        for ip in ip_list:"},{"line_number":299,"context_line":"            self.assertNotIn(ip_list[ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @decorators.skip_because(bug\u003d\"1540645\")"},{"line_number":302,"context_line":"    @decorators.idempotent_id(\u0027a905e287-c35e-42f2-b132-d02b09f3654a\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_c4e024fd","line":299,"in_reply_to":"ba2be162_56ea5510","updated":"2017-03-03 00:57:19.000000000","message":"Thanks Jordan, test_list_servers_filtered_by_ip_regex does that:)","commit_id":"7d8f7c5669f42178ae47aa1a6446eda42910a390"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e385cd2d9a5e5747b0fa04538812febcbf8fa1be","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        self.assertIn(ip_list[longest_ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":297,"context_line":"        del ip_list[longest_ip]"},{"line_number":298,"context_line":"        for ip in ip_list:"},{"line_number":299,"context_line":"            self.assertNotIn(ip_list[ip], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @decorators.skip_because(bug\u003d\"1540645\")"},{"line_number":302,"context_line":"    @decorators.idempotent_id(\u0027a905e287-c35e-42f2-b132-d02b09f3654a\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_3c46344f","line":299,"in_reply_to":"ba2be162_c4e024fd","updated":"2017-03-04 22:29:23.000000000","message":"Then what\u0027s the difference between those 2 tests ? If Nova always do a regex search, then maybe there should be only one test.","commit_id":"7d8f7c5669f42178ae47aa1a6446eda42910a390"}]}