)]}'
{"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"a706388a054d38f3c079724671c867e3404fb5c4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":"        # TODO(yfried): add support for dhcpcd"},{"line_number":239,"context_line":"        supported_clients \u003d [\u0027udhcpc\u0027, \u0027dhclient\u0027]"},{"line_number":240,"context_line":"        dhcp_client \u003d self.dhcp_client"},{"line_number":241,"context_line":"        if dhcp_client not in supported_clients:"},{"line_number":242,"context_line":"            raise tempest.lib.exceptions.InvalidConfiguration("},{"line_number":243,"context_line":"                \u0027%s DHCP client unsupported\u0027 % dhcp_client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_96ff8200","side":"PARENT","line":240,"updated":"2017-03-02 01:50:21.000000000","message":"If we want to remove self.dhcp_client. We can add the following line without changing any other file.\n\n dhcp_client \u003d CONF.scenario.dhcp_client","commit_id":"c48cf69987426d40b34b2576a57c2da93e09f3cc"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"a706388a054d38f3c079724671c867e3404fb5c4","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        cmd \u003d \"sudo /sbin/dhclient -r \u0026\u0026 sudo /sbin/dhclient\""},{"line_number":228,"context_line":"        self.exec_command(cmd)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def renew_lease(self, fixed_ip\u003dNone, dhcp_client\u003d\u0027udhcpc\u0027):"},{"line_number":231,"context_line":"        \"\"\"Wrapper method for renewing DHCP lease via given client"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        Supporting:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_9674e29c","line":230,"updated":"2017-03-02 01:50:21.000000000","message":"What\u0027s the point of adding default value here as it is always overridden by CONF.scenario.dhcp_client?","commit_id":"6133ece906bbb56a38837e1a7c5b7640772605f7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"2b90bc8843cb5f7fd66d868870df980c7d7cdb77","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        cmd \u003d \"sudo /sbin/dhclient -r \u0026\u0026 sudo /sbin/dhclient\""},{"line_number":214,"context_line":"        self.exec_command(cmd)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def renew_lease(self, fixed_ip\u003dNone, dhcp_client\u003d\u0027udhcpc\u0027):"},{"line_number":217,"context_line":"        \"\"\"Wrapper method for renewing DHCP lease via given client"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        Supporting:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_b7e2dd01","line":216,"range":{"start_line":216,"start_character":40,"end_line":216,"end_character":61},"updated":"2017-03-07 21:52:35.000000000","message":"while this may promote plugins not honouring the config option, it\u0027s good for non-plugin consumers to have a default value.","commit_id":"4e337851b27e37091e0b69f9c1b1d7e6f35bdd20"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"a706388a054d38f3c079724671c867e3404fb5c4","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            # because Neutron updates dnsmasq asynchronously after the"},{"line_number":606,"context_line":"            # subnet-update API call returns."},{"line_number":607,"context_line":"            ssh_client.renew_lease(fixed_ip\u003dfloating_ip[\u0027fixed_ip_address\u0027],"},{"line_number":608,"context_line":"                                   dhcp_client\u003dCONF.scenario.dhcp_client)"},{"line_number":609,"context_line":"            if ssh_client.get_dns_servers() !\u003d [alt_dns_server]:"},{"line_number":610,"context_line":"                LOG.debug(\"Failed to update DNS nameservers\")"},{"line_number":611,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_d6a57a04","line":608,"updated":"2017-03-02 01:50:21.000000000","message":"What if dhcp_client is not set in CONF.scenario?","commit_id":"6133ece906bbb56a38837e1a7c5b7640772605f7"}]}