)]}'
{"tempest/lib/services/compute/versions_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"502fdfc10026dbaa35743ce83c1e28e1d30709c5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        start \u003d time.time()"},{"line_number":45,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":46,"context_line":"        end \u003d time.time()"},{"line_number":47,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":48,"context_line":"                          resp_body\u003dbody)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_ebc7a095","line":47,"updated":"2017-03-10 08:34:26.000000000","message":"How about adding _log_request() into the raw_request() if it is important?","commit_id":"474bfd1a1d242b15769dfe1eed4e67a5233300c4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e1eb500ea3a3ec99a3ccf27d87face75bd3053b3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        start \u003d time.time()"},{"line_number":45,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":46,"context_line":"        end \u003d time.time()"},{"line_number":47,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":48,"context_line":"                          resp_body\u003dbody)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_514a3156","line":47,"range":{"start_line":47,"start_character":52,"end_line":47,"end_character":70},"updated":"2017-03-03 01:48:22.000000000","message":"maybe the secs can be omitted? the cost time is not important here and so the code can be simpler.","commit_id":"474bfd1a1d242b15769dfe1eed4e67a5233300c4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9858a8cb7ccfaf6cd2e6fb4e68bb82bd1e58453e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        start \u003d time.time()"},{"line_number":45,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":46,"context_line":"        end \u003d time.time()"},{"line_number":47,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":48,"context_line":"                          resp_body\u003dbody)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_cb69fcfa","line":47,"in_reply_to":"9a30ddce_ebc7a095","updated":"2017-03-10 08:50:56.000000000","message":"That\u0027s almost ok, only token_client.py may not like it(the log printed maybe too much)","commit_id":"474bfd1a1d242b15769dfe1eed4e67a5233300c4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3bcf2cdc0b36d9b5cd9a46862e9417d32fd76c24","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        start \u003d time.time()"},{"line_number":45,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":46,"context_line":"        end \u003d time.time()"},{"line_number":47,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":48,"context_line":"                          resp_body\u003dbody)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_81f8b7c4","line":47,"range":{"start_line":47,"start_character":52,"end_line":47,"end_character":70},"in_reply_to":"ba2be162_514a3156","updated":"2017-03-03 17:57:57.000000000","message":"We could, but this secs could be useful for avoiding confusions by adding this secs for the consistent log when we need to investigate some problems in the future.","commit_id":"474bfd1a1d242b15769dfe1eed4e67a5233300c4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"cf39c1c636eb23a45a7e170047713e71c0ef9553","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        start \u003d time.time()"},{"line_number":45,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":46,"context_line":"        end \u003d time.time()"},{"line_number":47,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":48,"context_line":"                          resp_body\u003dbody)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self._error_checker(resp, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_b68794b3","line":47,"range":{"start_line":47,"start_character":52,"end_line":47,"end_character":70},"in_reply_to":"ba2be162_81f8b7c4","updated":"2017-03-06 05:36:42.000000000","message":"I am not strongly object to adding cost time in the log, but if it is only to keep \"consistent\", maybe it not worth it,\nfor we have other api logs that don\u0027t include cost time, e.g., https://github.com/openstack/tempest/blob/29fbb70ce04bf67e2471d4ddc873c603698e9d4c/tempest/lib/services/identity/v2/token_client.py#L109\nAnd it seems not have caused confusions before.","commit_id":"474bfd1a1d242b15769dfe1eed4e67a5233300c4"}]}