)]}'
{"tempest/common/dynamic_creds.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2b186260e88a2d3267391413f7b43f8bd7e2557c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def _get_admin_project(self):"},{"line_number":145,"context_line":"        if self.identity_version \u003d\u003d \u0027v2\u0027:"},{"line_number":146,"context_line":"            project \u003d ("},{"line_number":147,"context_line":"                self.tenants_admin_client."},{"line_number":148,"context_line":"                list_tenants(params\u003d{\u0027name\u0027: CONF.auth.admin_project_name})"},{"line_number":149,"context_line":"                [\u0027tenants\u0027][0]"},{"line_number":150,"context_line":"            )"},{"line_number":151,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_07712d0f","line":148,"range":{"start_line":147,"start_character":16,"end_line":148,"end_character":29},"updated":"2017-03-03 21:56:35.000000000","message":"this looks odd, why not:\n\n  self.tenants_admin_client.list_tenants(","commit_id":"326fc1f9bb082ba52819073ca1e95dc268e233ba"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"dd129e46636b4736ae0882507018bd7d39315518","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def _get_admin_project(self):"},{"line_number":145,"context_line":"        if self.identity_version \u003d\u003d \u0027v2\u0027:"},{"line_number":146,"context_line":"            project \u003d ("},{"line_number":147,"context_line":"                self.tenants_admin_client."},{"line_number":148,"context_line":"                list_tenants(params\u003d{\u0027name\u0027: CONF.auth.admin_project_name})"},{"line_number":149,"context_line":"                [\u0027tenants\u0027][0]"},{"line_number":150,"context_line":"            )"},{"line_number":151,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_0a177448","line":148,"range":{"start_line":147,"start_character":16,"end_line":148,"end_character":29},"in_reply_to":"ba2be162_07712d0f","updated":"2017-03-03 22:03:38.000000000","message":"I agree, I\u0027ll get back to it.","commit_id":"326fc1f9bb082ba52819073ca1e95dc268e233ba"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"b56a134db9a27f7bb762c7c796563c6843562900","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        user_password \u003d data_utils.rand_password()"},{"line_number":186,"context_line":"        email \u003d data_utils.rand_name("},{"line_number":187,"context_line":"            root, prefix\u003dself.resource_prefix) + \"@example.com\""},{"line_number":188,"context_line":"        user \u003d self.creds_client.create_user("},{"line_number":189,"context_line":"            username, user_password, project, email)"},{"line_number":190,"context_line":"        role_assigned \u003d False"},{"line_number":191,"context_line":"        if admin:"},{"line_number":192,"context_line":"            self.creds_client.assign_user_role(user, project, self.admin_role)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_95a1c6fa","line":189,"range":{"start_line":188,"start_character":8,"end_line":189,"end_character":52},"updated":"2017-03-03 21:17:01.000000000","message":"FIXME: This will probably completely fail with tests run in parallel (or if cleanup isn\u0027t performed correctly) since there is only one admin project. \nTODO:Make the username random also and update the unit tests...","commit_id":"326fc1f9bb082ba52819073ca1e95dc268e233ba"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"4126e42e2d1336df38b82b13650ce14060288d26","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        secgroups_to_delete \u003d resp_body[\u0027security_groups\u0027]"},{"line_number":407,"context_line":"        for secgroup in secgroups_to_delete:"},{"line_number":408,"context_line":"            try:"},{"line_number":409,"context_line":"                nsg_client.delete_security_group(secgroup[\u0027id\u0027])"},{"line_number":410,"context_line":"            except lib_exc.NotFound:"},{"line_number":411,"context_line":"                LOG.warning(\u0027Security group %s, id %s not found for clean-up\u0027,"},{"line_number":412,"context_line":"                            secgroup[\u0027name\u0027], secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_ae77da38","line":409,"updated":"2017-03-08 06:35:26.000000000","message":"Since admin users are added to the same project, and this goes through all the security groups of a project, we\u0027re getting a \u0027in-use\u0027 error in tempest tests because concurrency.","commit_id":"b91e8adce7e5c3757f1c71ce67d7b2a508f00adf"}]}
