)]}'
{"tempest/services/volume/xml/volumes_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1576fd9d9ffe2a4dcbfffca43b3f618a9515e14b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return resp, body"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def detach_volume(self, volume_id):"},{"line_number":174,"context_line":"        \"\"\"Attaches a volume to a given instance on a given mountpoint.\"\"\""},{"line_number":175,"context_line":"        post_body \u003d Element(\"os-detach\")"},{"line_number":176,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 % str(volume_id)"},{"line_number":177,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Fv3Q%3D","line":174,"updated":"2013-08-30 03:02:44.000000000","message":"This comment is not valid.\nThis method is \u0027detach_volume\u0027. So\n s/Attaches/Detaches and s/ on a given mountpoint// ?","commit_id":"5f97ccfe55cdbe1aeaf6b1536b3cfb486e30a0bd"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"ce7904615ac21c9b2edbf83af696d3a93f2ab85a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return resp, body"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def detach_volume(self, volume_id):"},{"line_number":174,"context_line":"        \"\"\"Attaches a volume to a given instance on a given mountpoint.\"\"\""},{"line_number":175,"context_line":"        post_body \u003d Element(\"os-detach\")"},{"line_number":176,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 % str(volume_id)"},{"line_number":177,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2FvkI%3D","line":174,"in_reply_to":"AAAASn%2F%2Fv3Q%3D","updated":"2013-08-30 04:48:06.000000000","message":"Done","commit_id":"5f97ccfe55cdbe1aeaf6b1536b3cfb486e30a0bd"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1576fd9d9ffe2a4dcbfffca43b3f618a9515e14b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\"Uploads a volume in Glance.\"\"\""},{"line_number":184,"context_line":"        post_body \u003d Element(\"os-volume_upload_image\","},{"line_number":185,"context_line":"                            image_name\u003dimage_name)"},{"line_number":186,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 %str(volume_id)"},{"line_number":187,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"},{"line_number":188,"context_line":"        volume \u003d xml_to_json(etree.fromstring(body))"},{"line_number":189,"context_line":"        return resp, volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Fv2c%3D","line":186,"updated":"2013-08-30 03:02:44.000000000","message":"pep8 pointed out\nE225 missing whitespace around operator\n\nhttp://logs.openstack.org/30/44330/2/check/gate-tempest-pep8/b51851b/console.html","commit_id":"5f97ccfe55cdbe1aeaf6b1536b3cfb486e30a0bd"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"ce7904615ac21c9b2edbf83af696d3a93f2ab85a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\"Uploads a volume in Glance.\"\"\""},{"line_number":184,"context_line":"        post_body \u003d Element(\"os-volume_upload_image\","},{"line_number":185,"context_line":"                            image_name\u003dimage_name)"},{"line_number":186,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 %str(volume_id)"},{"line_number":187,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"},{"line_number":188,"context_line":"        volume \u003d xml_to_json(etree.fromstring(body))"},{"line_number":189,"context_line":"        return resp, volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Fvj8%3D","line":186,"in_reply_to":"AAAASn%2F%2Fv2c%3D","updated":"2013-08-30 04:48:06.000000000","message":"Done","commit_id":"5f97ccfe55cdbe1aeaf6b1536b3cfb486e30a0bd"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"b779b381aa504685d5cf7b294ffffd63d798b58b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return vol"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_attachment_from_volume(self, volume):"},{"line_number":60,"context_line":"        \"\"\"Return the element \u0027attachment\u0027 from input volumes"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        return volume[\u0027attachments\u0027][\u0027attachment\u0027]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2FnWA%3D","line":60,"updated":"2013-09-02 13:14:25.000000000","message":"As pep8 suggests. Needs punctuation (full stop at the end of the sentence) and moving the \"\"\" to the same row.","commit_id":"2c335747d91f323c99b0fc511547ae1490a843b4"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ac5292f1c31b4238deb0b4a6a3b84b4f84d339a1","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def attach_volume(self, volume_id, instance_uuid, mountpoint):"},{"line_number":166,"context_line":"        \"\"\"Attaches a volume to a given instance on a given mountpoint.\"\"\""},{"line_number":167,"context_line":"        post_body \u003d Element(\"os-attach\","},{"line_number":168,"context_line":"                            instance_uuid\u003dinstance_uuid,"},{"line_number":169,"context_line":"                            mountpoint\u003dmountpoint"},{"line_number":170,"context_line":"                            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FfWA%3D","line":167,"updated":"2013-09-04 06:26:18.000000000","message":"So far I see from other XML clients xmlns\u003dXMLNS_11 is set for all root elements. Could you check if this is needed here?","commit_id":"789449a321e98f1a5399cf3f607141d975df85c3"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ac5292f1c31b4238deb0b4a6a3b84b4f84d339a1","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def detach_volume(self, volume_id):"},{"line_number":178,"context_line":"        \"\"\"Detaches a volume from an instance.\"\"\""},{"line_number":179,"context_line":"        post_body \u003d Element(\"os-detach\")"},{"line_number":180,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 % str(volume_id)"},{"line_number":181,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"},{"line_number":182,"context_line":"        if body:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FfV8%3D","line":179,"updated":"2013-09-04 06:26:18.000000000","message":"Same here, see below.","commit_id":"789449a321e98f1a5399cf3f607141d975df85c3"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ac5292f1c31b4238deb0b4a6a3b84b4f84d339a1","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def upload_volume(self, volume_id, image_name):"},{"line_number":187,"context_line":"        \"\"\"Uploads a volume in Glance.\"\"\""},{"line_number":188,"context_line":"        post_body \u003d Element(\"os-volume_upload_image\","},{"line_number":189,"context_line":"                            image_name\u003dimage_name)"},{"line_number":190,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 % str(volume_id)"},{"line_number":191,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FfV4%3D","line":188,"updated":"2013-09-04 06:26:18.000000000","message":"Same here, see below.","commit_id":"789449a321e98f1a5399cf3f607141d975df85c3"}]}