)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"899bd0392e1341fe8f3b2def324776079b0922c1","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                test_utils.call_and_ignore_notfound_exc("},{"line_number":184,"context_line":"                    resource_del_func, res)"},{"line_number":185,"context_line":"            except Exception as exc:"},{"line_number":186,"context_line":"                LOG.exception(\u0027Exception raised deleting %s: %s\u0027, res)"},{"line_number":187,"context_line":"                LOG.exception(exc)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_bb6b0384","line":186,"range":{"start_line":186,"start_character":57,"end_line":186,"end_character":63},"updated":"2017-03-13 02:49:12.000000000","message":"one more %s ?","commit_id":"0599b7ae3cc95ef0f6aa1b0e193cd5b4832b3e27"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6ff7c6886af1ad862812df12d086979e134b26ff","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                test_utils.call_and_ignore_notfound_exc("},{"line_number":184,"context_line":"                    resource_del_func, res)"},{"line_number":185,"context_line":"            except Exception as exc:"},{"line_number":186,"context_line":"                LOG.exception(\u0027Exception raised deleting %s: %s\u0027, res)"},{"line_number":187,"context_line":"                LOG.exception(exc)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_de5c251b","line":186,"range":{"start_line":186,"start_character":57,"end_line":186,"end_character":63},"in_reply_to":"9a30ddce_bb6b0384","updated":"2017-03-13 03:55:57.000000000","message":"Oh, thanks. I was thinking to add resource_name here.\n\nDone","commit_id":"0599b7ae3cc95ef0f6aa1b0e193cd5b4832b3e27"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"480b2a09142774fcd9026d944bc4131a27043d4e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                raise"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @classmethod"},{"line_number":178,"context_line":"    def _clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":179,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":180,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":181,"context_line":"        for res in resources:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_0492794c","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":24},"updated":"2017-03-29 14:52:31.000000000","message":"I don\u0027t think this should be private.\nIt\u0027s now a static method, so it could be moved into test utils.\n\nNote that this does not wait for resources to be deleted. \nThis is something that should be fixed... it would be nice to have a test helper that deletes and array of resources and waits for deletion and ignores NotFound.","commit_id":"605bff1c3f9044aff79849684d91df38ae3b8b14"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"eb73ef7e9643dcda02715caf3c8a72ab9648e344","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                raise"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @classmethod"},{"line_number":178,"context_line":"    def _clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":179,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":180,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":181,"context_line":"        for res in resources:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_91ec71bb","line":178,"updated":"2017-03-30 05:01:49.000000000","message":"yeah, it could be. But, I think it can be in another patch.","commit_id":"605bff1c3f9044aff79849684d91df38ae3b8b14"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7247b14dc6ce547bd77d406b1a8dedf92498da37","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @classmethod"},{"line_number":178,"context_line":"    def _clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":179,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":180,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":181,"context_line":"        for res in resources:"},{"line_number":182,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_b5fa5541","line":179,"updated":"2017-03-22 09:01:16.000000000","message":"Thanks! Yeah, it should work. But it increases the complexity of this code a bit. So I\u0027d like to hear another opinion :)","commit_id":"605bff1c3f9044aff79849684d91df38ae3b8b14"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c10f4c0a58b3092fb4011f4e1a525041e8d78bac","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @classmethod"},{"line_number":178,"context_line":"    def _clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":179,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":180,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":181,"context_line":"        for res in resources:"},{"line_number":182,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a22e58a_0b3f4126","line":179,"range":{"start_line":179,"start_character":37,"end_line":179,"end_character":50},"updated":"2017-03-14 06:29:26.000000000","message":"maybe you can get resource name from resouce_del_func:\nresouce_del_func.im_class.__name__.split(\".\")[-1].replace(\"Client\", \"\")","commit_id":"605bff1c3f9044aff79849684d91df38ae3b8b14"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"480b2a09142774fcd9026d944bc4131a27043d4e","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @classmethod"},{"line_number":178,"context_line":"    def _clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":179,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":180,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":181,"context_line":"        for res in resources:"},{"line_number":182,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_a47f4d64","line":179,"in_reply_to":"1a1ced50_b5fa5541","updated":"2017-03-29 14:52:31.000000000","message":"I guess it would be work, but I\u0027m not sure it would be necessary / nice.\nWe could have add a resource_name property in rest_client which by default is implemented by stripping \"Client\" out of the class name... but that would be something for another patch. Client names once taken out of their module are not necessarily unique (see quota, version, flavor etc) so a better implementation could be \u003cmodule\u003e \u003cresource_name\u003e...","commit_id":"605bff1c3f9044aff79849684d91df38ae3b8b14"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4ded8ffdc6f349e7f513d191052cb63447ee3fb5","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":176,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":177,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":178,"context_line":"        for res in resources:"},{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                test_utils.call_and_ignore_notfound_exc("},{"line_number":181,"context_line":"                    resource_del_func, res)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_f1405da7","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":15},"updated":"2017-03-30 05:06:52.000000000","message":"nit: res_id ?","commit_id":"15fb916388921b0b07b47662dc04800a5367d409"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8f91d15064c7875dae5a9ea0b2e3b5ca3586ea04","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def clear_resources(cls, resource_name, resources, resource_del_func):"},{"line_number":176,"context_line":"        LOG.debug(\u0027Clearing %s: %s\u0027, resource_name,"},{"line_number":177,"context_line":"                  \u0027,\u0027.join(map(str, resources)))"},{"line_number":178,"context_line":"        for res in resources:"},{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                test_utils.call_and_ignore_notfound_exc("},{"line_number":181,"context_line":"                    resource_del_func, res)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_fbe3da32","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":15},"in_reply_to":"ffe62b97_f1405da7","updated":"2017-04-11 09:31:42.000000000","message":"oh, yeah, thanks\n\nDone","commit_id":"15fb916388921b0b07b47662dc04800a5367d409"}]}