)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a2d57f0aaaa480fd9b2d7defe171973c3e469ae3","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"    @staticmethod"},{"line_number":1246,"context_line":"    def is_port_security_enabled():"},{"line_number":1247,"context_line":"        return (CONF.network_feature_enabled.port_security or"},{"line_number":1248,"context_line":"                tempest.test.is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"class EncryptionScenarioTest(ScenarioTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_025d3b79","line":1248,"range":{"start_line":1247,"start_character":16,"end_line":1248,"end_character":78},"updated":"2017-03-27 14:46:31.000000000","message":"I am not sure how it will fix or take care of https://bugs.launchpad.net/tempest/+bug/1638487 ?","commit_id":"fcb198b1040ecb5944d65606689e4e2101c7291e"}],"tempest/test.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f3fdef0a970132fc7afcdf862f14411edf70154d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def is_port_security_enabled():"},{"line_number":147,"context_line":"    return (CONF.network_feature_enabled.port_security or"},{"line_number":148,"context_line":"            is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def related_bug(bug, status_code\u003dNone):"},{"line_number":152,"context_line":"    \"\"\"A decorator useful to know solutions from launchpad bug reports"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_0f573b03","line":149,"range":{"start_line":146,"start_character":0,"end_line":149,"end_character":0},"updated":"2017-03-17 05:45:56.000000000","message":"Sorry, but please don\u0027t extend test.py. The module is mess and this new method seems network specific. This general module is not a good place..","commit_id":"6c351c2429c33a579bde6a0885f169ee95fcc39b"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"336a9f90a56a040999e2e680ceee3366ccc59ad8","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def is_port_security_enabled():"},{"line_number":147,"context_line":"    return (CONF.network_feature_enabled.port_security or"},{"line_number":148,"context_line":"            is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def related_bug(bug, status_code\u003dNone):"},{"line_number":152,"context_line":"    \"\"\"A decorator useful to know solutions from launchpad bug reports"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_21e24bd6","line":149,"range":{"start_line":146,"start_character":0,"end_line":149,"end_character":0},"in_reply_to":"1a1ced50_0f573b03","updated":"2017-03-17 08:22:58.000000000","message":"Where would you suggest to put this @oomichi? Even if the module is a li\u0027l bit messy it seems like a good place to me (Although we should refactor this, maybe as a part of the class squash)","commit_id":"6c351c2429c33a579bde6a0885f169ee95fcc39b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f3090f144566c5bc14104ad1c2011baa22948421","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def is_port_security_enabled():"},{"line_number":147,"context_line":"    return (CONF.network_feature_enabled.port_security or"},{"line_number":148,"context_line":"            is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def related_bug(bug, status_code\u003dNone):"},{"line_number":152,"context_line":"    \"\"\"A decorator useful to know solutions from launchpad bug reports"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_3bef86b1","line":149,"range":{"start_line":146,"start_character":0,"end_line":149,"end_character":0},"in_reply_to":"1a1ced50_1babef75","updated":"2017-03-20 17:37:36.000000000","message":"How about putting this method into class NetworkScenarioTest?\nThis method is used from scenario network tests only and NetworkScenarioTest seems a better place.","commit_id":"6c351c2429c33a579bde6a0885f169ee95fcc39b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f2ad35fa49cc72eb9912c3bb32c59e86a7145b72","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def is_port_security_enabled():"},{"line_number":147,"context_line":"    return (CONF.network_feature_enabled.port_security or"},{"line_number":148,"context_line":"            is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def related_bug(bug, status_code\u003dNone):"},{"line_number":152,"context_line":"    \"\"\"A decorator useful to know solutions from launchpad bug reports"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_676d2e04","line":149,"range":{"start_line":146,"start_character":0,"end_line":149,"end_character":0},"in_reply_to":"1a1ced50_21e24bd6","updated":"2017-03-17 11:37:44.000000000","message":"Yeah, please don\u0027t put it in test.py Inline it (i.e don\"t make it a function or put it in the file where it is actually used.).","commit_id":"6c351c2429c33a579bde6a0885f169ee95fcc39b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5e9eaff0411f46d95c1976d1a417630a69a2fccd","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def is_port_security_enabled():"},{"line_number":147,"context_line":"    return (CONF.network_feature_enabled.port_security or"},{"line_number":148,"context_line":"            is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def related_bug(bug, status_code\u003dNone):"},{"line_number":152,"context_line":"    \"\"\"A decorator useful to know solutions from launchpad bug reports"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_4e2722b6","line":149,"range":{"start_line":146,"start_character":0,"end_line":149,"end_character":0},"in_reply_to":"1a1ced50_3bef86b1","updated":"2017-03-20 17:48:53.000000000","message":"Done","commit_id":"6c351c2429c33a579bde6a0885f169ee95fcc39b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9a221b6301f9432aa2ba3219c38ca9e1383c8739","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def is_port_security_enabled():"},{"line_number":147,"context_line":"    return (CONF.network_feature_enabled.port_security or"},{"line_number":148,"context_line":"            is_extension_enabled(\u0027port-security\u0027, \u0027network\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def related_bug(bug, status_code\u003dNone):"},{"line_number":152,"context_line":"    \"\"\"A decorator useful to know solutions from launchpad bug reports"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_1babef75","line":149,"range":{"start_line":146,"start_character":0,"end_line":149,"end_character":0},"in_reply_to":"1a1ced50_676d2e04","updated":"2017-03-17 13:28:39.000000000","message":"The check is used in two places, so I figured I don\u0027t want to repeat it in two places. So you see I am not a seasoned tempest contributor. What would be your guidance on correct placement?","commit_id":"6c351c2429c33a579bde6a0885f169ee95fcc39b"}]}