)]}'
{"tempest/api/compute/servers/test_novnc.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f3b2a70e996f98defbaeac4a084feec508fadeff","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            # security-type is 1, for no authentication, the server"},{"line_number":121,"context_line":"            # does not send the SecurityResult message but proceeds"},{"line_number":122,"context_line":"            # directly to the initialization messages"},{"line_number":123,"context_line":"            if version !\u003d 3.7:"},{"line_number":124,"context_line":"                # The server should send 4 bytes of 0\u0027s if security"},{"line_number":125,"context_line":"                # handshake succeeded"},{"line_number":126,"context_line":"                data \u003d self._websocket.receive_frame()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_445ce37c","line":123,"updated":"2017-03-13 09:52:05.000000000","message":"So which versions are being supported here?\n3.3 is checked above, so this else clause is already 3.7?","commit_id":"d5353d456e74daab1d80aaea0df8f5b29d4c54e7"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"7c5176bd8d56852e752824b3aa7dc02be3fc38a1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            # security-type is 1, for no authentication, the server"},{"line_number":121,"context_line":"            # does not send the SecurityResult message but proceeds"},{"line_number":122,"context_line":"            # directly to the initialization messages"},{"line_number":123,"context_line":"            if version !\u003d 3.7:"},{"line_number":124,"context_line":"                # The server should send 4 bytes of 0\u0027s if security"},{"line_number":125,"context_line":"                # handshake succeeded"},{"line_number":126,"context_line":"                data \u003d self._websocket.receive_frame()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a25e98e_7ac15380","line":123,"in_reply_to":"9a30ddce_2a9964c4","updated":"2017-03-14 03:01:23.000000000","message":"Yes, per the rfc6143 3.3 3.7 and 3.8 are the three published versions. But I don\u0027t know who/where is using RFB 3.7. So it looks like you prefer to make it to be a certain known list. I agree with you by considering currently we can only verify it on RFB 3.3. and RFB 3.8, unless others can give input on who is using other versions of RFB and how can we verify it.\n\nThanks.","commit_id":"d5353d456e74daab1d80aaea0df8f5b29d4c54e7"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"cd3c3872a1555723ce550424ba8732b750b2369e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            # security-type is 1, for no authentication, the server"},{"line_number":121,"context_line":"            # does not send the SecurityResult message but proceeds"},{"line_number":122,"context_line":"            # directly to the initialization messages"},{"line_number":123,"context_line":"            if version !\u003d 3.7:"},{"line_number":124,"context_line":"                # The server should send 4 bytes of 0\u0027s if security"},{"line_number":125,"context_line":"                # handshake succeeded"},{"line_number":126,"context_line":"                data \u003d self._websocket.receive_frame()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_e1093c96","line":123,"in_reply_to":"9a30ddce_445ce37c","updated":"2017-03-13 14:07:34.000000000","message":"The latest RFB is 3.8. The following negotiation process is not supported by 3.7.see： https://tools.ietf.org/html/rfc6143#appendix-A.2","commit_id":"d5353d456e74daab1d80aaea0df8f5b29d4c54e7"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"938f5649a379fa42f87f1f8bda50cab657b4d977","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            # security-type is 1, for no authentication, the server"},{"line_number":121,"context_line":"            # does not send the SecurityResult message but proceeds"},{"line_number":122,"context_line":"            # directly to the initialization messages"},{"line_number":123,"context_line":"            if version !\u003d 3.7:"},{"line_number":124,"context_line":"                # The server should send 4 bytes of 0\u0027s if security"},{"line_number":125,"context_line":"                # handshake succeeded"},{"line_number":126,"context_line":"                data \u003d self._websocket.receive_frame()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_2a9964c4","line":123,"in_reply_to":"9a30ddce_e1093c96","updated":"2017-03-13 16:46:08.000000000","message":"Understood - perhaps the test should assert which RFB versions are supported at line 99.  If we receive a version other than 3.3, 3.7 or 3.8 then we should abort the test case with an easy to understand error.\nThen line 123 can easily just reference the additions in 3.8.\n\nDo we have to support 3.7? (I think you said XS uses 3.3 and qemu is using 3.8?)","commit_id":"d5353d456e74daab1d80aaea0df8f5b29d4c54e7"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"7a5766f115cefcb4be99f05c0fba1e48f48cb6e7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                         \u0027Token must be invalid because the connection \u0027"},{"line_number":88,"context_line":"                         \u0027closed.\u0027)"},{"line_number":89,"context_line":"        # Parse the RFB version from the data to make sure it is valid"},{"line_number":90,"context_line":"        # and greater than or equal to 3.3"},{"line_number":91,"context_line":"        version \u003d float(\"%d.%d\" % (int(data[4:7], base\u003d10),"},{"line_number":92,"context_line":"                                   int(data[8:11], base\u003d10)))"},{"line_number":93,"context_line":"        # Add the max RFB versions supported"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_e73f7cd4","line":90,"updated":"2017-03-14 14:25:18.000000000","message":"Nit: This comment is now slightly wrong - should be \"to make sure it\u0027s a supported version\".","commit_id":"72bef06e950d33b6f158f2b804862056a83969ad"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"076d1976ade63b18d41cb7dfab5662c54cbb9ad8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                         \u0027Token must be invalid because the connection \u0027"},{"line_number":88,"context_line":"                         \u0027closed.\u0027)"},{"line_number":89,"context_line":"        # Parse the RFB version from the data to make sure it is valid"},{"line_number":90,"context_line":"        # and greater than or equal to 3.3"},{"line_number":91,"context_line":"        version \u003d float(\"%d.%d\" % (int(data[4:7], base\u003d10),"},{"line_number":92,"context_line":"                                   int(data[8:11], base\u003d10)))"},{"line_number":93,"context_line":"        # Add the max RFB versions supported"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_533ab937","line":90,"in_reply_to":"3a1ff146_e73f7cd4","updated":"2017-03-15 02:31:04.000000000","message":"Done","commit_id":"72bef06e950d33b6f158f2b804862056a83969ad"}]}