)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4059c2e997939cdb9469641fdb18a42dc68c52c6","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                          CONF.network.build_interval):"},{"line_number":894,"context_line":"            floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":895,"context_line":"                floatingip_id)[\u0027floatingip\u0027]"},{"line_number":896,"context_line":"            self.assertEqual(status, floating_ip[\u0027status\u0027],"},{"line_number":897,"context_line":"                             message\u003d\"FloatingIP: {fp} is at status: {cst}. \""},{"line_number":898,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":899,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_2baa2bd5","line":896,"updated":"2017-03-15 00:14:52.000000000","message":"I think this assertEqual() should be executed when the call_until_true() \u003d\u003d False, too. Otherwise, we can\u0027t check the status.","commit_id":"4dda94e9b4ccf06b63e8a831ab6887b51c933377"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f0f8b1a200543225378defc8af1ec5744625d018","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                          CONF.network.build_interval):"},{"line_number":894,"context_line":"            floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":895,"context_line":"                floatingip_id)[\u0027floatingip\u0027]"},{"line_number":896,"context_line":"            self.assertEqual(status, floating_ip[\u0027status\u0027],"},{"line_number":897,"context_line":"                             message\u003d\"FloatingIP: {fp} is at status: {cst}. \""},{"line_number":898,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":899,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_6bcee35b","line":896,"in_reply_to":"3a1ff146_2baa2bd5","updated":"2017-03-15 00:39:25.000000000","message":"Yes, when call_until_true()\u003d\u003dFalse, we should call assertEqual.\nAnd the current code seems to do so, I don\u0027t catch your meaning?","commit_id":"4dda94e9b4ccf06b63e8a831ab6887b51c933377"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"efd0888205e007eea210e99ec4f867c5a817af18","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                          CONF.network.build_interval):"},{"line_number":894,"context_line":"            floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":895,"context_line":"                floatingip_id)[\u0027floatingip\u0027]"},{"line_number":896,"context_line":"            self.assertEqual(status, floating_ip[\u0027status\u0027],"},{"line_number":897,"context_line":"                             message\u003d\"FloatingIP: {fp} is at status: {cst}. \""},{"line_number":898,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":899,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_7e404a57","line":896,"in_reply_to":"3a1ff146_6bcee35b","updated":"2017-03-15 12:06:51.000000000","message":"@Masayuki, assertEqual() is executed when call_until_true() returns False.","commit_id":"4dda94e9b4ccf06b63e8a831ab6887b51c933377"},{"author":{"_account_id":23204,"name":"Jonte Watford","email":"jonte.watford@intel.com","username":"jwatford"},"change_message_id":"6eb5704987a2e535afabc509bdab83e9a3885452","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                          CONF.network.build_interval):"},{"line_number":894,"context_line":"            floating_ip \u003d self.floating_ips_client.show_floatingip("},{"line_number":895,"context_line":"                floatingip_id)[\u0027floatingip\u0027]"},{"line_number":896,"context_line":"            self.assertEqual(status, floating_ip[\u0027status\u0027],"},{"line_number":897,"context_line":"                             message\u003d\"FloatingIP: {fp} is at status: {cst}. \""},{"line_number":898,"context_line":"                                     \"failed  to reach status: {st}\""},{"line_number":899,"context_line":"                             .format(fp\u003dfloating_ip, cst\u003dfloating_ip[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_4101e7ad","line":896,"in_reply_to":"3a1ff146_6bcee35b","updated":"2017-03-15 15:27:38.000000000","message":"The logic behind \"if not test_utils.call_until_true\" must return false before the assert equal is executed instead of executing assert equal while if not test_utils.call_until_true\" is  \u003d\u003d false. The message is displayed when and if the statement is executed and found to be false after its returns.","commit_id":"4dda94e9b4ccf06b63e8a831ab6887b51c933377"}]}