)]}'
{"tempest/cmd/run.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"897a551be3ffb90f5743d6e706f4af2c73f4e5d3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"import six"},{"line_number":102,"context_line":"from testrepository.commands import run_argv"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"from tempest.cmd import cleanup_service"},{"line_number":106,"context_line":"from tempest.cmd import init"},{"line_number":107,"context_line":"from tempest.cmd import workspace"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_229e9f06","line":104,"updated":"2017-04-28 18:20:38.000000000","message":"We should not put 2 blank lines between *import*","commit_id":"440a09b708972cad5d8e114e42af2a3e1ee22a99"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"897a551be3ffb90f5743d6e706f4af2c73f4e5d3","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        parallel.add_argument(\u0027--serial\u0027, \u0027-t\u0027, dest\u003d\u0027parallel\u0027,"},{"line_number":283,"context_line":"                              action\u003d\u0027store_false\u0027,"},{"line_number":284,"context_line":"                              help\u003d\u0027Run tests serially\u0027)"},{"line_number":285,"context_line":"        parser.add_argument(\u0027--no-state-save\u0027, dest\u003d\u0027no_state\u0027,"},{"line_number":286,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":287,"context_line":"                            help\u003d\"Not to save the state of the cloud before \""},{"line_number":288,"context_line":"                                 \"running tempest. The default behavior is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_c2749bd1","line":285,"range":{"start_line":285,"start_character":29,"end_line":285,"end_character":44},"updated":"2017-04-28 18:20:38.000000000","message":"Why not \"--state-save\" option here like the bug report?\n\nThis patch changes the default behavior and \"--state-save\" seems good for the existing users to keep the default behavior same.","commit_id":"440a09b708972cad5d8e114e42af2a3e1ee22a99"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e59f28022f60a822fd73ad501f46ecff64a22773","unresolved":false,"context_lines":[{"line_number":101,"context_line":"import six"},{"line_number":102,"context_line":"from testrepository.commands import run_argv"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"from tempest.cmd import cleanup_service"},{"line_number":106,"context_line":"from tempest.cmd import init"},{"line_number":107,"context_line":"from tempest.cmd import workspace"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_25af9895","line":104,"updated":"2017-06-09 19:05:29.000000000","message":"We should not add a new blank between import blocks.","commit_id":"577ce2b42ebd470998eeed06043d3e39562ff877"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3df1abc4ad4531e0d82537f9183f5037135b9af0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        if parsed_args.state:"},{"line_number":182,"context_line":"            self._init_state()"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            pass"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if parsed_args.combine:"},{"line_number":187,"context_line":"            temp_stream \u003d tempfile.NamedTemporaryFile()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_c2a7afa7","line":184,"updated":"2017-06-20 05:29:28.000000000","message":"I don\u0027t understand here. Why do we need \u0027else: pass\u0027 here?","commit_id":"a028de16f8b6f2fd51183a676d48108759475aab"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"85aa107f4f5e3dd24801f909c6735acb3ba5416a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        if parsed_args.state:"},{"line_number":182,"context_line":"            self._init_state()"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            pass"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if parsed_args.combine:"},{"line_number":187,"context_line":"            temp_stream \u003d tempfile.NamedTemporaryFile()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_42a27f4d","line":184,"in_reply_to":"7f231b9d_c2a7afa7","updated":"2017-06-20 05:47:14.000000000","message":"We don\u0027t need it but it adds readability to the code","commit_id":"a028de16f8b6f2fd51183a676d48108759475aab"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3df1abc4ad4531e0d82537f9183f5037135b9af0","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return \u0027Run tempest\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _init_state(self):"},{"line_number":216,"context_line":"        print(\"Initializing saved state.\")"},{"line_number":217,"context_line":"        data \u003d {}"},{"line_number":218,"context_line":"        self.global_services \u003d cleanup_service.get_global_cleanup_services()"},{"line_number":219,"context_line":"        self.admin_mgr \u003d credentials.AdminManager()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_a2b6f3db","line":216,"updated":"2017-06-20 05:29:28.000000000","message":"I feel we don\u0027t need this because it\u0027s a bit verbose.","commit_id":"a028de16f8b6f2fd51183a676d48108759475aab"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"85aa107f4f5e3dd24801f909c6735acb3ba5416a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return \u0027Run tempest\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _init_state(self):"},{"line_number":216,"context_line":"        print(\"Initializing saved state.\")"},{"line_number":217,"context_line":"        data \u003d {}"},{"line_number":218,"context_line":"        self.global_services \u003d cleanup_service.get_global_cleanup_services()"},{"line_number":219,"context_line":"        self.admin_mgr \u003d credentials.AdminManager()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_22b0a38b","line":216,"in_reply_to":"7f231b9d_a2b6f3db","updated":"2017-06-20 05:47:14.000000000","message":"Personally I like it having here so as to differentiate between cases where state was initialized and not but if all disagree i would remove it.","commit_id":"a028de16f8b6f2fd51183a676d48108759475aab"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3df1abc4ad4531e0d82537f9183f5037135b9af0","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        parser.add_argument(\u0027--save-state\u0027, dest\u003d\u0027state\u0027,"},{"line_number":285,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":286,"context_line":"                            help\u003d\"To save the state of the cloud before \""},{"line_number":287,"context_line":"                                 \"running tempest.\")"},{"line_number":288,"context_line":"        # output args"},{"line_number":289,"context_line":"        parser.add_argument(\"--subunit\", action\u003d\u0027store_true\u0027,"},{"line_number":290,"context_line":"                            help\u003d\u0027Enable subunit v2 output\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_82bbf7c2","line":287,"updated":"2017-06-20 05:29:28.000000000","message":"The trailing period is unnecessary.","commit_id":"a028de16f8b6f2fd51183a676d48108759475aab"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"85aa107f4f5e3dd24801f909c6735acb3ba5416a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        parser.add_argument(\u0027--save-state\u0027, dest\u003d\u0027state\u0027,"},{"line_number":285,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":286,"context_line":"                            help\u003d\"To save the state of the cloud before \""},{"line_number":287,"context_line":"                                 \"running tempest.\")"},{"line_number":288,"context_line":"        # output args"},{"line_number":289,"context_line":"        parser.add_argument(\"--subunit\", action\u003d\u0027store_true\u0027,"},{"line_number":290,"context_line":"                            help\u003d\u0027Enable subunit v2 output\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_228783b9","line":287,"in_reply_to":"7f231b9d_82bbf7c2","updated":"2017-06-20 05:47:14.000000000","message":"As you said, i would fix it in a following patch.","commit_id":"a028de16f8b6f2fd51183a676d48108759475aab"}]}