)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"47732f4f3bde4dfe390e55d0618e5f10e1a488a1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If the tests about port-security only in Neutron side,when we submit"},{"line_number":13,"context_line":"patch about nova,the test can\u0027t be execute."},{"line_number":14,"context_line":"I think the function of port-security is not only have relationship"},{"line_number":15,"context_line":"with neutron,but also with nova."},{"line_number":16,"context_line":"So I think the test should also be add in tempest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I41e66c4c69daa2a2efaca05f9c1316cc664ab6d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7ffa3b31_71002cac","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":32},"updated":"2017-04-20 07:09:19.000000000","message":"Is this true? Your patch call only neutron apis. So, I think there is no relationship with nova in this patch. Do I miss something?","commit_id":"77c1e35441c14465e325ea8973949fa94c80c18a"}],"tempest/api/network/test_networks.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"ead95cddb8ecaf8e5cf8d6b779f401b9e0d4d809","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        body \u003d self.networks_client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":407,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":410,"context_line":"    @decorators.idempotent_id(\u0027b428bbc6-095e-11e7-a59c-fa163e4fa634\u0027)"},{"line_number":411,"context_line":"    def test_create_update_network_port_security_enabled(self):"},{"line_number":412,"context_line":"        # create network,set port_security_enabled to False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_55b6d83d","line":409,"range":{"start_line":409,"start_character":4,"end_line":409,"end_character":28},"updated":"2017-03-20 15:11:57.000000000","message":"I don\u0027t think this test case should be part of the smoke test.\nPlease remove decorator","commit_id":"5889ba550a059b49a53921ce8b68b71543205946"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"11272e3018071d2939bfab13367fcc523b7d8ffc","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    @decorators.idempotent_id(\u0027b428bbc6-095e-11e7-a59c-fa163e4fa634\u0027)"},{"line_number":410,"context_line":"    def test_toggle_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        body \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        self.assertEqual(False, body[\u0027port_security_enabled\u0027])"},{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        body \u003d self.networks_client.update_network("}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_18b0da89","line":412,"range":{"start_line":412,"start_character":8,"end_line":412,"end_character":12},"updated":"2017-03-21 17:30:25.000000000","message":"nit: change name from body to network","commit_id":"d982a26a9b6dc158d90a2b6f219bc08e1d948d0f"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"4ccdf8e92127a6224802fc555899907de66eb5b8","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    @decorators.idempotent_id(\u0027b428bbc6-095e-11e7-a59c-fa163e4fa634\u0027)"},{"line_number":410,"context_line":"    def test_toggle_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        body \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        self.assertEqual(False, body[\u0027port_security_enabled\u0027])"},{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        body \u003d self.networks_client.update_network("}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_d43d2190","line":412,"range":{"start_line":412,"start_character":8,"end_line":412,"end_character":12},"in_reply_to":"1a1ced50_18b0da89","updated":"2017-03-22 00:19:40.000000000","message":"Done","commit_id":"d982a26a9b6dc158d90a2b6f219bc08e1d948d0f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"997a15708171e8a8155190469bc962ca39ebf989","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @decorators.idempotent_id(\u0027b428bbc6-095e-11e7-a59c-fa163e4fa634\u0027)"},{"line_number":410,"context_line":"    def test_toggle_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        network \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        self.assertEqual(False, network[\u0027port_security_enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_2f2700cb","line":410,"range":{"start_line":410,"start_character":8,"end_line":410,"end_character":41},"updated":"2017-03-22 01:32:55.000000000","message":"will it better to name as test_create_update_network_port_security_enabled?","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"275d71f568cc5e179ada0e08806f5d5d14abc074","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @decorators.idempotent_id(\u0027b428bbc6-095e-11e7-a59c-fa163e4fa634\u0027)"},{"line_number":410,"context_line":"    def test_toggle_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        network \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        self.assertEqual(False, network[\u0027port_security_enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_52393cf1","line":410,"range":{"start_line":410,"start_character":8,"end_line":410,"end_character":41},"in_reply_to":"1a1ced50_2f2700cb","updated":"2017-03-22 06:00:17.000000000","message":"Done","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"997a15708171e8a8155190469bc962ca39ebf989","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def test_toggle_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        network \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        self.assertEqual(False, network[\u0027port_security_enabled\u0027])"},{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_6f2d78a7","line":413,"updated":"2017-03-22 01:32:55.000000000","message":"better to add a blank line here","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"275d71f568cc5e179ada0e08806f5d5d14abc074","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def test_toggle_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        network \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        self.assertEqual(False, network[\u0027port_security_enabled\u0027])"},{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_723e38db","line":413,"in_reply_to":"1a1ced50_6f2d78a7","updated":"2017-03-22 06:00:17.000000000","message":"Done","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4bbfd6bc5b3a19718e3460524704b855bb21d9de","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":417,"context_line":"        self.assertEqual(True, network[\u0027port_security_enabled\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"class BulkNetworkOpsTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_8c4d5d40","line":417,"updated":"2017-03-22 03:36:29.000000000","message":"I agree with zhufl here, and after L.413? And I\u0027m not sure it\u0027s a synchronized or not, though.","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"997a15708171e8a8155190469bc962ca39ebf989","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":417,"context_line":"        self.assertEqual(True, network[\u0027port_security_enabled\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"class BulkNetworkOpsTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_ea06b61a","line":417,"range":{"start_line":417,"start_character":13,"end_line":417,"end_character":24},"updated":"2017-03-22 01:32:55.000000000","message":"you\u0027d better call show_network first before doing the check","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"275d71f568cc5e179ada0e08806f5d5d14abc074","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":417,"context_line":"        self.assertEqual(True, network[\u0027port_security_enabled\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"class BulkNetworkOpsTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_bd1b2172","line":417,"in_reply_to":"1a1ced50_8c4d5d40","updated":"2017-03-22 06:00:17.000000000","message":"Done","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"61b2063267e6388df572dc2c7954f711d07ab6ee","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":417,"context_line":"        self.assertEqual(True, network[\u0027port_security_enabled\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"class BulkNetworkOpsTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_7229d836","line":417,"range":{"start_line":417,"start_character":13,"end_line":417,"end_character":24},"in_reply_to":"1a1ced50_aff76b89","updated":"2017-03-22 05:25:02.000000000","message":"we should check whether network[\u0027port_security_enabled\u0027] is True from the result of show_network, not from update_network.","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"275d71f568cc5e179ada0e08806f5d5d14abc074","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":417,"context_line":"        self.assertEqual(True, network[\u0027port_security_enabled\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"class BulkNetworkOpsTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_9d12e555","line":417,"range":{"start_line":417,"start_character":13,"end_line":417,"end_character":24},"in_reply_to":"1a1ced50_ea06b61a","updated":"2017-03-22 06:00:17.000000000","message":"Done","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"bb01a9d740d7983accb9cd88e8edf313d159470b","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # update port_security_enabled to True"},{"line_number":415,"context_line":"        network \u003d self.networks_client.update_network("},{"line_number":416,"context_line":"            network[\u0027id\u0027], port_security_enabled\u003dTrue)[\u0027network\u0027]"},{"line_number":417,"context_line":"        self.assertEqual(True, network[\u0027port_security_enabled\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"class BulkNetworkOpsTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_aff76b89","line":417,"range":{"start_line":417,"start_character":13,"end_line":417,"end_character":24},"in_reply_to":"1a1ced50_ea06b61a","updated":"2017-03-22 04:52:36.000000000","message":"Hi zhufl,call show_network to check network[\u0027id\u0027] is equal to the before network[id] or other use ???","commit_id":"baf027c9a17c4ec97bf58a74c9ef4d2f8c5a7d66"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac88f32f24d81b633583a8943593b794db513859","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @decorators.idempotent_id(\u0027b428bbc6-095e-11e7-a59c-fa163e4fa634\u0027)"},{"line_number":410,"context_line":"    def test_create_update_network_port_security_enabled(self):"},{"line_number":411,"context_line":"        # create network,set port_security_enabled to False"},{"line_number":412,"context_line":"        body \u003d self.create_network(port_security_enabled\u003dFalse)"},{"line_number":413,"context_line":"        network \u003d self.networks_client.show_network("}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_098a481a","line":410,"updated":"2017-03-31 16:35:38.000000000","message":"This test is similar to Neutron plugin test as https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/test_extension_driver_port_security.py#L57\n\nAre you migrating the test from Neutron into Tempest ?\n\nOne more point is that this test could require port-security extension of Neutron, so we need to add the check of the extension existence.","commit_id":"ff5b823567442b5925b2af902ec3d5041017780d"}]}