)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a0e5f3c6fc62fcccf339a8f001fbf86cfba9082c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"information is very important for users, because users can know"},{"line_number":11,"context_line":"what features are available on clouds. However, Tempest didn\u0027t"},{"line_number":12,"context_line":"test the Cinder API versions in long-term. So this patch adds"},{"line_number":13,"context_line":"the corresponding test."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id5791665d8435fac7552733b0c1126cee4359d00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a1ced50_feef4f84","line":13,"updated":"2017-03-22 08:07:33.000000000","message":"I think it\u0027s better to mention the patch which you already proposed[1] in cinder since your patch is not approved yet.\n\n[1] Id28e26fca0adbdcfb0d905f52ca697a74db3be75","commit_id":"72feecc5c4e2f7bc95f24278ebe0dbc6e3070d91"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ebf49ebb6031957b4e7772b45c0d887661c43053","unresolved":false,"context_lines":[{"line_number":10,"context_line":"information is very important for users, because users can know"},{"line_number":11,"context_line":"what features are available on clouds. However, Tempest didn\u0027t"},{"line_number":12,"context_line":"test the Cinder API versions in long-term. So this patch adds"},{"line_number":13,"context_line":"the corresponding test."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id5791665d8435fac7552733b0c1126cee4359d00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a1ced50_3061fca9","line":13,"in_reply_to":"1a1ced50_feef4f84","updated":"2017-03-22 17:14:37.000000000","message":"TBH, I am not sure what should we mention here.\nThe status code has been checked on test side and implementation side..\n\nThis Tempest implementation itself is common pattern by comparing the other services\u0027 version tests. There is not special thing which we need to write on the commit message..\n\nAnyway I will try it by my thinking.","commit_id":"72feecc5c4e2f7bc95f24278ebe0dbc6e3070d91"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"dfc39580f0104a7046261f9b241e0cca5633905e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      for 300 but Cinder api-ref currently shows 200 and 202 also."},{"line_number":17,"context_line":"      These status codes are never returned actually and the patch"},{"line_number":18,"context_line":"      Id28e26fca0adbdcfb0d905f52ca697a74db3be75 will fix it on"},{"line_number":19,"context_line":"      Cinder side."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Id5791665d8435fac7552733b0c1126cee4359d00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_31f562ec","line":19,"updated":"2017-03-23 09:40:51.000000000","message":"Yeah, this is what I mentioned. Thanks :)","commit_id":"4adae2fff6e78c306ddf28999589ef388464f4e8"}],"tempest/api/volume/v3/test_versions.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"028656c98a5b18b816b8ed53c1c46b9b12fa3af9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class VersionsTest(base.VolumesV3Test):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u002777838fc4-b49b-4c64-9533-166762517369\u0027)"},{"line_number":23,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":24,"context_line":"    def test_list_versions(self):"},{"line_number":25,"context_line":"        versions \u003d self.versions_client.list_versions()[\u0027versions\u0027]"},{"line_number":26,"context_line":"        expected_resources \u003d (\u0027status\u0027, \u0027updated\u0027, \u0027links\u0027, \u0027min_version\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_acd60cc3","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":28},"updated":"2017-03-18 12:11:26.000000000","message":"NIT: I don\u0027t mind really, but I\u0027m not sure we use \u0027smoke\u0027 consistently, I wonder if we should be using it at all?","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c51920c918229a9387befc524f7a1a21777f00e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class VersionsTest(base.VolumesV3Test):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u002777838fc4-b49b-4c64-9533-166762517369\u0027)"},{"line_number":23,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":24,"context_line":"    def test_list_versions(self):"},{"line_number":25,"context_line":"        versions \u003d self.versions_client.list_versions()[\u0027versions\u0027]"},{"line_number":26,"context_line":"        expected_resources \u003d (\u0027status\u0027, \u0027updated\u0027, \u0027links\u0027, \u0027min_version\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_dbdcb2e6","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":28},"in_reply_to":"1a1ced50_acd60cc3","updated":"2017-03-20 17:48:49.000000000","message":"Yeah, I think \"list versions\" API is important for users and the cost of the API is low. So the corresponding test should be smoke I think.\n\nI feel Defcore also should contain the API tests.","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"028656c98a5b18b816b8ed53c1c46b9b12fa3af9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        expected_resources \u003d (\u0027status\u0027, \u0027updated\u0027, \u0027links\u0027, \u0027min_version\u0027,"},{"line_number":27,"context_line":"                              \u0027version\u0027, \u0027media-types\u0027, \u0027id\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        for version in versions:"},{"line_number":30,"context_line":"            for res in expected_resources:"},{"line_number":31,"context_line":"                self.assertIn(res, version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_2ce3fca4","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":43},"updated":"2017-03-18 12:11:26.000000000","message":"I\u0027m not sure, this looks like a schema validation... shouldn\u0027t we add a schema instead?","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c51920c918229a9387befc524f7a1a21777f00e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        expected_resources \u003d (\u0027status\u0027, \u0027updated\u0027, \u0027links\u0027, \u0027min_version\u0027,"},{"line_number":27,"context_line":"                              \u0027version\u0027, \u0027media-types\u0027, \u0027id\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        for version in versions:"},{"line_number":30,"context_line":"            for res in expected_resources:"},{"line_number":31,"context_line":"                self.assertIn(res, version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_bbba966c","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":43},"in_reply_to":"1a1ced50_2ce3fca4","updated":"2017-03-20 17:48:49.000000000","message":"Yeah, we will be able to implement this as schema validation.\nThis API is Cinder and we have gotten consensus to implement schema validation for Cinder API as the next step. So it is nice to implement it :)","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"7049b361d09d4e2c405a1c17b57ebf94653035fb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":24,"context_line":"    def test_list_versions(self):"},{"line_number":25,"context_line":"        # NOTE: The version data is checked on service client side"},{"line_number":26,"context_line":"        #       with JSON-Schema validation. It is enough to just call"},{"line_number":27,"context_line":"        #       the API here."},{"line_number":28,"context_line":"        self.versions_client.list_versions()[\u0027versions\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_948fe473","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":29},"updated":"2017-03-23 10:01:09.000000000","message":"NIT: not sure about the indentation here","commit_id":"4adae2fff6e78c306ddf28999589ef388464f4e8"}],"tempest/lib/api_schema/response/volume/versions.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"92838a2ed0e723e8c12711e63f736560fd834f5c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"list_versions \u003d {"},{"line_number":17,"context_line":"    \u0027status_code\u0027: [300],"},{"line_number":18,"context_line":"    \u0027response_body\u0027: {"},{"line_number":19,"context_line":"        \u0027type\u0027: \u0027object\u0027,"},{"line_number":20,"context_line":"        \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_d30f0586","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":24},"updated":"2017-03-21 17:47:45.000000000","message":"should this include 200 and 202 too?","commit_id":"9552d46b33624332fe4069fb974b7f42b336f10a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c0d2488390b0ef3c90ef13aab7443da7e046e27","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"list_versions \u003d {"},{"line_number":17,"context_line":"    \u0027status_code\u0027: [300],"},{"line_number":18,"context_line":"    \u0027response_body\u0027: {"},{"line_number":19,"context_line":"        \u0027type\u0027: \u0027object\u0027,"},{"line_number":20,"context_line":"        \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_00f69bf8","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":24},"in_reply_to":"1a1ced50_d30f0586","updated":"2017-03-21 21:33:13.000000000","message":"An excellent point ! :-)\nMaybe you pointed it from the api-ref, that might be wrong I guess now. I push https://review.openstack.org/#/c/448289","commit_id":"9552d46b33624332fe4069fb974b7f42b336f10a"}],"tempest/lib/services/volume/v3/versions_client.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"028656c98a5b18b816b8ed53c1c46b9b12fa3af9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def list_versions(self):"},{"line_number":26,"context_line":"        \"\"\"List API versions\"\"\""},{"line_number":27,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        start \u003d time.time()"},{"line_number":30,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_8ce8707e","line":27,"range":{"start_line":27,"start_character":22,"end_line":27,"end_character":50},"updated":"2017-03-18 12:11:26.000000000","message":"Once I fix it, I think this https://review.openstack.org/#/c/443969/ will be a nicer solution :)","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c51920c918229a9387befc524f7a1a21777f00e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def list_versions(self):"},{"line_number":26,"context_line":"        \"\"\"List API versions\"\"\""},{"line_number":27,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        start \u003d time.time()"},{"line_number":30,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_bb71b6e2","line":27,"range":{"start_line":27,"start_character":22,"end_line":27,"end_character":50},"in_reply_to":"1a1ced50_8ce8707e","updated":"2017-03-20 17:48:49.000000000","message":"Yeah, please fix Jenkins\u0027 point on that before :)","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"028656c98a5b18b816b8ed53c1c46b9b12fa3af9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        start \u003d time.time()"},{"line_number":30,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":31,"context_line":"        end \u003d time.time()"},{"line_number":32,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":33,"context_line":"                          resp_body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_6cf33474","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":57},"updated":"2017-03-18 12:11:26.000000000","message":"I guess a note would be useful to explain why you need a raw_request.\nI wonder if we should have instead a flag in rest_client request to skip auth for a request?","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c51920c918229a9387befc524f7a1a21777f00e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        start \u003d time.time()"},{"line_number":30,"context_line":"        resp, body \u003d self.raw_request(version_url, \u0027GET\u0027)"},{"line_number":31,"context_line":"        end \u003d time.time()"},{"line_number":32,"context_line":"        self._log_request(\u0027GET\u0027, version_url, resp, secs\u003d(end - start),"},{"line_number":33,"context_line":"                          resp_body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_bb161653","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":57},"in_reply_to":"1a1ced50_6cf33474","updated":"2017-03-20 17:48:49.000000000","message":"Hi\n\n \u003e I guess a note would be useful to explain why you need a raw_request.\n\nOK, I will.\n\n \u003e I wonder if we should have instead a flag in rest_client request to skip auth for a request?\n\nThat would be a nice idea, I will try it on the different patch because we have already multiple places related to this.","commit_id":"4ae9755f48cae21ab0b7c7c6418e510e945b7244"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"92838a2ed0e723e8c12711e63f736560fd834f5c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class VersionsClient(base_client.BaseClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def list_versions(self):"},{"line_number":27,"context_line":"        \"\"\"List API versions\"\"\""},{"line_number":28,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        start \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_93966d3d","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":31},"updated":"2017-03-21 17:47:45.000000000","message":"Should docstring have API reference:\n\nFor a full list of available parameters, please refer to the official\nAPI reference:\nhttp://developer.openstack.org/api-ref/block-storage/v3#list-all-api-versions","commit_id":"9552d46b33624332fe4069fb974b7f42b336f10a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c0d2488390b0ef3c90ef13aab7443da7e046e27","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class VersionsClient(base_client.BaseClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def list_versions(self):"},{"line_number":27,"context_line":"        \"\"\"List API versions\"\"\""},{"line_number":28,"context_line":"        version_url \u003d self._get_base_version_url()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        start \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_80e28b2d","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":31},"in_reply_to":"1a1ced50_93966d3d","updated":"2017-03-21 21:33:13.000000000","message":"Thanks, ++","commit_id":"9552d46b33624332fe4069fb974b7f42b336f10a"}]}