)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"03c72f39502bbd05c0a02d106007b966009943a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deep unnecessarily."},{"line_number":12,"context_line":"This patch removes set_nic_state for the cleanup."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"NOTE: This method is not used at outside of Tempest."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ida09a3b4098980c1644cc096453c34ef6e1c2a37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a1ced50_477aa0f2","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":52},"updated":"2017-03-20 21:20:31.000000000","message":"heh as far as we know, but since this is not a stable interface it\u0027s ok","commit_id":"126fe985f68aeaf65037c104326ce6b859c01f00"}],"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"03c72f39502bbd05c0a02d106007b966009943a0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return self.exec_command(cmd)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def set_mac_address(self, nic, address):"},{"line_number":83,"context_line":"        self.exec_command(\"sudo ip link set %s down\" % nic)"},{"line_number":84,"context_line":"        cmd \u003d \"sudo ip link set dev {0} address {1}\".format(nic, address)"},{"line_number":85,"context_line":"        self.exec_command(cmd)"},{"line_number":86,"context_line":"        self.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_mac_address(self, nic\u003d\"\"):"},{"line_number":89,"context_line":"        show_nic \u003d \"show {nic} \".format(nic\u003dnic) if nic else \"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_e7738ce5","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":57},"updated":"2017-03-20 21:20:31.000000000","message":"I wonder is the exec_command reuses an ssh connection?\nIf not it may be worth here collating the three commands into one to save on reconnecting again and again.","commit_id":"126fe985f68aeaf65037c104326ce6b859c01f00"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e7af5d0e047c61727e9ac0dbe6b398dde2d2afbe","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return self.exec_command(cmd)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def set_mac_address(self, nic, address):"},{"line_number":83,"context_line":"        self.exec_command(\"sudo ip link set %s down\" % nic)"},{"line_number":84,"context_line":"        cmd \u003d \"sudo ip link set dev {0} address {1}\".format(nic, address)"},{"line_number":85,"context_line":"        self.exec_command(cmd)"},{"line_number":86,"context_line":"        self.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_mac_address(self, nic\u003d\"\"):"},{"line_number":89,"context_line":"        show_nic \u003d \"show {nic} \".format(nic\u003dnic) if nic else \"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_f0977039","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":57},"in_reply_to":"1a1ced50_2dca871b","updated":"2017-03-29 01:55:14.000000000","message":"yes, you are combining the commands in this https://review.openstack.org/#/c/448742/2","commit_id":"126fe985f68aeaf65037c104326ce6b859c01f00"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b0b8cef5945828dc5ccb324b091047456bd0201c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return self.exec_command(cmd)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def set_mac_address(self, nic, address):"},{"line_number":83,"context_line":"        self.exec_command(\"sudo ip link set %s down\" % nic)"},{"line_number":84,"context_line":"        cmd \u003d \"sudo ip link set dev {0} address {1}\".format(nic, address)"},{"line_number":85,"context_line":"        self.exec_command(cmd)"},{"line_number":86,"context_line":"        self.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_mac_address(self, nic\u003d\"\"):"},{"line_number":89,"context_line":"        show_nic \u003d \"show {nic} \".format(nic\u003dnic) if nic else \"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_2dca871b","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":57},"in_reply_to":"1a1ced50_6daabf86","updated":"2017-03-22 17:05:16.000000000","message":"After some investigation for set_mac_address(), I am not sure we need to do that because set_mac_address() is called from test_network_basic_ops only on OpenStack projects.\nIt would be nice to remove the method also.","commit_id":"126fe985f68aeaf65037c104326ce6b859c01f00"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"138943bc1edff05f5b9aea4575bdf17597711853","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return self.exec_command(cmd)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def set_mac_address(self, nic, address):"},{"line_number":83,"context_line":"        self.exec_command(\"sudo ip link set %s down\" % nic)"},{"line_number":84,"context_line":"        cmd \u003d \"sudo ip link set dev {0} address {1}\".format(nic, address)"},{"line_number":85,"context_line":"        self.exec_command(cmd)"},{"line_number":86,"context_line":"        self.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_mac_address(self, nic\u003d\"\"):"},{"line_number":89,"context_line":"        show_nic \u003d \"show {nic} \".format(nic\u003dnic) if nic else \"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_6daabf86","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":57},"in_reply_to":"1a1ced50_e7738ce5","updated":"2017-03-22 17:00:09.000000000","message":"That is a nice point, yeah exec_command() reconnects on each call because it calls _get_ssh_connection() internally.\nSo it would be nice to merge these calls into a single.\nBut this patch doesn\u0027t do that because this patch just removes the wrapper method and current patch doesn\u0027t change anything related to this reconnection.\n\nI will follow this point with another patch.","commit_id":"126fe985f68aeaf65037c104326ce6b859c01f00"}]}
